From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31CFAC433EF for ; Mon, 6 Dec 2021 12:57:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B33396B007B; Mon, 6 Dec 2021 07:57:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AE25C6B007D; Mon, 6 Dec 2021 07:57:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9A9D16B007E; Mon, 6 Dec 2021 07:57:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0070.hostedemail.com [216.40.44.70]) by kanga.kvack.org (Postfix) with ESMTP id 86C6B6B007B for ; Mon, 6 Dec 2021 07:57:23 -0500 (EST) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 4827E18131204 for ; Mon, 6 Dec 2021 12:57:13 +0000 (UTC) X-FDA: 78887369946.23.53A0B88 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf11.hostedemail.com (Postfix) with ESMTP id D1B87F0000AA for ; Mon, 6 Dec 2021 12:57:12 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DC1E36126B; Mon, 6 Dec 2021 12:57:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CD260C341C5; Mon, 6 Dec 2021 12:57:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1638795431; bh=iWcUSdfMi/yZYvDDPgFhXATx0z6jQgrGR+qiCes0fK0=; h=From:To:Cc:Subject:Date:In-Reply-To:From; b=hojjVnJQAhKABdFEd6m8jGpjFA3yZZvmkf1eQ/qqflPuqvM+K2uD61xv42VC35Oku z9TIeCxPnIA/06lCMjLAfHt3s59WfNwTVpcJXXDlW9u2OrDQ4qCaivJI+tnCqMXZHp RvIuS1ko/Qtgycrh2v0+czMydlVIIao+FVrafq7cBKfHi3feNeI/T9iTjbQ7oIIAWu PrK4w95ykrVQ4VH+gdOx4M//XhbdBD2N4bRom3HDFp3NEqYAqfKVaLp3j/vlvIjPEc xbmYxZcCKAtzxizG5ox6kUdt74d/OQSRIKCmbMF0YB+AbIg+s947ZpkKGEsH+z1Ndy 9Gj888RYBFeMg== From: SeongJae Park To: Xin Hao Cc: sj@kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V2] mm/damon: Modify damon_rand() macro to static inline function Date: Mon, 6 Dec 2021 12:57:08 +0000 Message-Id: <20211206125708.6443-1-sj@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <110ffcd4e420c86c42b41ce2bc9f0fe6a4f32cd3.1638795127.git.xhao@linux.alibaba.com> X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: D1B87F0000AA X-Stat-Signature: p7hg1m555gjun5kxktwuruz4111giar3 Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=hojjVnJQ; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf11.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org X-HE-Tag: 1638795432-988926 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 6 Dec 2021 20:52:43 +0800 Xin Hao wrote: > The damon_rand() func can not be implemented as a macro. > Example: > damon_rand(a++, b); > The value of 'a' will be incremented twice, This is obviously > unreasonable, So there fix it. > > Fixes: b9a6ac4e4ede ("mm/damon: adaptively adjust regions") > Reported-by: Andrew Morton > Signed-off-by: Xin Hao Reviewed-by: SeongJae Park Thanks, SJ > --- > include/linux/damon.h | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/include/linux/damon.h b/include/linux/damon.h > index c6df025d8704..a58046cd45e6 100644 > --- a/include/linux/damon.h > +++ b/include/linux/damon.h > @@ -19,7 +19,10 @@ > #define DAMOS_MAX_SCORE (99) > > /* Get a random number in [l, r) */ > -#define damon_rand(l, r) (l + prandom_u32_max(r - l)) > +static inline unsigned long damon_rand(unsigned long l, unsigned long r) > +{ > + return l + prandom_u32_max(r - l); > +} > > /** > * struct damon_addr_range - Represents an address region of [@start, @end). > -- > 2.31.0 > >