From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7430C4321E for ; Thu, 16 Dec 2021 11:42:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 417C86B0071; Thu, 16 Dec 2021 06:42:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3C7F46B0073; Thu, 16 Dec 2021 06:42:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2680B6B0074; Thu, 16 Dec 2021 06:42:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay031.a.hostedemail.com [64.99.140.31]) by kanga.kvack.org (Postfix) with ESMTP id 14B6A6B0071 for ; Thu, 16 Dec 2021 06:42:14 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id DA2C621D3E for ; Thu, 16 Dec 2021 11:42:03 +0000 (UTC) X-FDA: 78923468526.04.CF4FADA Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by imf03.hostedemail.com (Postfix) with ESMTP id 9806820011 for ; Thu, 16 Dec 2021 11:42:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1639654922; x=1671190922; h=date:from:to:cc:subject:message-id:mime-version; bh=EYNC8PMElkTDktdIWtkkjEzXScJVQFi4qPkxLSq1DyY=; b=QpjfiazjhNn5sWFxg52x/tWfUACV8jk4gwMKrlDgyMYdxHvKtDxdWlT9 82liy8ON0YH9dR6Wtet2WHdB3MplSMX7gyWtDmmYeg/OoEmXVQ1QUnAc5 l59EVxKoR1RhIEnnAPPtSkQ8xY3FClFckALPgFdrkRBOqMmxudfobhlIM NH23D7QBSjXs6Jo0J0jeHiTvnZ5X2oB9um8muYevBl95WfxGlWrvB4127 vY0yNBJsiII/LDFdBhei7Nrytm8oYbCvvVX0IYPiY9w5BSUfuG6fjoEP8 h6vLnld1Dy9MEAc67LzShglmrxG2qfZxdjlBa4fW0ztj2ts6ZcKw/UGI+ w==; X-IronPort-AV: E=McAfee;i="6200,9189,10199"; a="300243988" X-IronPort-AV: E=Sophos;i="5.88,211,1635231600"; d="scan'208";a="300243988" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Dec 2021 03:42:00 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,211,1635231600"; d="scan'208";a="615121937" Received: from lkp-server02.sh.intel.com (HELO 9f38c0981d9f) ([10.239.97.151]) by orsmga004.jf.intel.com with ESMTP; 16 Dec 2021 03:41:58 -0800 Received: from kbuild by 9f38c0981d9f with local (Exim 4.92) (envelope-from ) id 1mxp93-00034n-GW; Thu, 16 Dec 2021 11:41:57 +0000 Date: Thu, 16 Dec 2021 19:41:25 +0800 From: kernel test robot To: Jakub Jelinek Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org, "Peter Zijlstra (Intel)" , Andrew Morton , Linux Memory Management List Subject: arch/mips/mm/tlbex.c:2599 check_pabits() warn: always true condition '(fillbits >= ((__builtin_constant_p(0)) ?(((0) < 2) ?0:63 - __builtin_clzll(0)):((4 <= 4)) ?__ilog2_u32(0):__ilog2_u64(0))) => (0-u32max >= 0)' Message-ID: <202112161929.ccx97Im9-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Queue-Id: 9806820011 X-Stat-Signature: 6id9w4sujjutpdtstkturb193gfei5ew Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Qpjfiazj; spf=none (imf03.hostedemail.com: domain of lkp@intel.com has no SPF policy when checking 134.134.136.31) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com X-Rspamd-Server: rspam10 X-HE-Tag: 1639654922-933557 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 2b14864acbaaf03d9c01982e243a84632524c3ac commit: 2f78788b55baa3410b1ec91a576286abe1ad4d6a ilog2: improve ilog2 for constant arguments date: 1 year ago config: mips-randconfig-m031-20211216 (https://download.01.org/0day-ci/archive/20211216/202112161929.ccx97Im9-lkp@intel.com/config) compiler: mips64-linux-gcc (GCC) 11.2.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot New smatch warnings: arch/mips/mm/tlbex.c:2599 check_pabits() warn: always true condition '(fillbits >= ((__builtin_constant_p(0)) ?(((0) < 2) ?0:63 - __builtin_clzll(0)):((4 <= 4)) ?__ilog2_u32(0):__ilog2_u64(0))) => (0-u32max >= 0)' Old smatch warnings: arch/mips/mm/tlbex.c:1681 iPTE_LW() warn: curly braces intended? arch/mips/mm/tlbex.c:1713 iPTE_SW() warn: inconsistent indenting vim +2599 arch/mips/mm/tlbex.c c5b367835cfc7a Steven J. Hill 2015-02-26 2569 00bf1c691d082c Paul Burton 2015-09-22 2570 static void check_pabits(void) 00bf1c691d082c Paul Burton 2015-09-22 2571 { 00bf1c691d082c Paul Burton 2015-09-22 2572 unsigned long entry; 00bf1c691d082c Paul Burton 2015-09-22 2573 unsigned pabits, fillbits; 00bf1c691d082c Paul Burton 2015-09-22 2574 00bf1c691d082c Paul Burton 2015-09-22 2575 if (!cpu_has_rixi || !_PAGE_NO_EXEC) { 00bf1c691d082c Paul Burton 2015-09-22 2576 /* 00bf1c691d082c Paul Burton 2015-09-22 2577 * We'll only be making use of the fact that we can rotate bits 00bf1c691d082c Paul Burton 2015-09-22 2578 * into the fill if the CPU supports RIXI, so don't bother 00bf1c691d082c Paul Burton 2015-09-22 2579 * probing this for CPUs which don't. 00bf1c691d082c Paul Burton 2015-09-22 2580 */ 00bf1c691d082c Paul Burton 2015-09-22 2581 return; 00bf1c691d082c Paul Burton 2015-09-22 2582 } 00bf1c691d082c Paul Burton 2015-09-22 2583 00bf1c691d082c Paul Burton 2015-09-22 2584 write_c0_entrylo0(~0ul); 00bf1c691d082c Paul Burton 2015-09-22 2585 back_to_back_c0_hazard(); 00bf1c691d082c Paul Burton 2015-09-22 2586 entry = read_c0_entrylo0(); 00bf1c691d082c Paul Burton 2015-09-22 2587 00bf1c691d082c Paul Burton 2015-09-22 2588 /* clear all non-PFN bits */ 00bf1c691d082c Paul Burton 2015-09-22 2589 entry &= ~((1 << MIPS_ENTRYLO_PFN_SHIFT) - 1); 00bf1c691d082c Paul Burton 2015-09-22 2590 entry &= ~(MIPS_ENTRYLO_RI | MIPS_ENTRYLO_XI); 00bf1c691d082c Paul Burton 2015-09-22 2591 00bf1c691d082c Paul Burton 2015-09-22 2592 /* find a lower bound on PABITS, and upper bound on fill bits */ 00bf1c691d082c Paul Burton 2015-09-22 2593 pabits = fls_long(entry) + 6; 00bf1c691d082c Paul Burton 2015-09-22 2594 fillbits = max_t(int, (int)BITS_PER_LONG - pabits, 0); 00bf1c691d082c Paul Burton 2015-09-22 2595 00bf1c691d082c Paul Burton 2015-09-22 2596 /* minus the RI & XI bits */ 00bf1c691d082c Paul Burton 2015-09-22 2597 fillbits -= min_t(unsigned, fillbits, 2); 00bf1c691d082c Paul Burton 2015-09-22 2598 00bf1c691d082c Paul Burton 2015-09-22 @2599 if (fillbits >= ilog2(_PAGE_NO_EXEC)) 00bf1c691d082c Paul Burton 2015-09-22 2600 fill_includes_sw_bits = true; 00bf1c691d082c Paul Burton 2015-09-22 2601 00bf1c691d082c Paul Burton 2015-09-22 2602 pr_debug("Entry* registers contain %u fill bits\n", fillbits); 00bf1c691d082c Paul Burton 2015-09-22 2603 } 00bf1c691d082c Paul Burton 2015-09-22 2604 :::::: The code at line 2599 was first introduced by commit :::::: 00bf1c691d082c1945fdba032c03a9a82e9e7e61 MIPS: tlbex: Avoid placing software PTE bits in Entry* PFN fields :::::: TO: Paul Burton :::::: CC: Ralf Baechle --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org