From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79DAFC433F5 for ; Tue, 21 Dec 2021 09:04:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 09AE36B0071; Tue, 21 Dec 2021 04:04:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 023006B0073; Tue, 21 Dec 2021 04:04:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E2D086B0074; Tue, 21 Dec 2021 04:04:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0062.hostedemail.com [216.40.44.62]) by kanga.kvack.org (Postfix) with ESMTP id D4EDD6B0071 for ; Tue, 21 Dec 2021 04:04:48 -0500 (EST) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id A1EC7180EB70F for ; Tue, 21 Dec 2021 09:04:48 +0000 (UTC) X-FDA: 78941216256.21.2EF9097 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf04.hostedemail.com (Postfix) with ESMTP id 2CE084003A for ; Tue, 21 Dec 2021 09:04:47 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 492B168BEB; Tue, 21 Dec 2021 10:04:42 +0100 (CET) Date: Tue, 21 Dec 2021 10:04:41 +0100 From: Christoph Hellwig To: Logan Gunthorpe Cc: linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, linux-block@vger.kernel.org, linux-pci@vger.kernel.org, linux-mm@kvack.org, iommu@lists.linux-foundation.org, Stephen Bates , Christoph Hellwig , Dan Williams , Jason Gunthorpe , Christian =?iso-8859-1?Q?K=F6nig?= , John Hubbard , Don Dutile , Matthew Wilcox , Daniel Vetter , Jakowski Andrzej , Minturn Dave B , Jason Ekstrand , Dave Hansen , Xiong Jianxin , Bjorn Helgaas , Ira Weiny , Robin Murphy , Martin Oliveira , Chaitanya Kulkarni Subject: Re: [PATCH v4 16/23] iov_iter: introduce iov_iter_get_pages_[alloc_]flags() Message-ID: <20211221090441.GC7949@lst.de> References: <20211117215410.3695-1-logang@deltatee.com> <20211117215410.3695-17-logang@deltatee.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211117215410.3695-17-logang@deltatee.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspamd-Queue-Id: 2CE084003A X-Stat-Signature: ot98s4kgg1x7pazz19beobsjcse41syg Authentication-Results: imf04.hostedemail.com; dkim=none; dmarc=none; spf=none (imf04.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de X-Rspamd-Server: rspam02 X-HE-Tag: 1640077487-786474 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: All these new helpers should be _GPL exports, keeping the existing ones (which should never have been non-GPL exports as tiny wrappers around GUP-fast) as out of line wrappers.