From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F324C433EF for ; Thu, 23 Dec 2021 12:10:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A2E3A6B0072; Thu, 23 Dec 2021 07:10:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9DE696B0073; Thu, 23 Dec 2021 07:10:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8A6536B0074; Thu, 23 Dec 2021 07:10:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0009.hostedemail.com [216.40.44.9]) by kanga.kvack.org (Postfix) with ESMTP id 7AEEE6B0072 for ; Thu, 23 Dec 2021 07:10:11 -0500 (EST) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 352D888CC2 for ; Thu, 23 Dec 2021 12:10:11 +0000 (UTC) X-FDA: 78948941022.18.B4BEB5C Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf26.hostedemail.com (Postfix) with ESMTP id B628A140042 for ; Thu, 23 Dec 2021 12:10:10 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5547961E42; Thu, 23 Dec 2021 12:10:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 628C8C36AE9; Thu, 23 Dec 2021 12:10:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1640261408; bh=b3e8H965kWzk3cG0vkvJacFJ3asiauTNbErKaauV7j4=; h=From:To:Cc:Subject:Date:In-Reply-To:From; b=DVM0F+dLfiX5uczkFXfqSnBtMonUxOS2DwWyUTTC16zXXZhs1QtM2xCl8P9sfaVZ7 rwZ8x8lz+WR/UzLsI5iDSgcV0BiPHJiegixlKmLYqEQXuWyu/O/Dz92DYD581MCr47 HCB3B1k57VA6qHG6ydGL9hm7YwQBi0iUX6EB/sBXXHFQMwS/rLOWWzVrsi4H2xp+8t m3QC7sgPN7RvN2/T6CfjKxNpNpCS/baaywD4iN+Kiqc4aeWc8fERaSw2TFvgoVBWYO YTgjkvZ1akX0dZR6T1WHBXDcu2yRgle27jkJo6BprW6Ky/H6KSW8tYqnnJOZWEqE1o +up5HBvdpiWJA== From: SeongJae Park To: Guoqing Jiang Cc: sj@kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org Subject: Re: [PATCH] mm/damon: move the implementation of damon_insert_region to damon.h Date: Thu, 23 Dec 2021 12:10:04 +0000 Message-Id: <20211223121004.20736-1-sj@kernel.org> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 In-Reply-To: <20211223085703.6142-1-guoqing.jiang@linux.dev> Content-Type: text/plain; charset=UTF-8 X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: B628A140042 X-Stat-Signature: anbudpgzppcpuo17d1n13yfkhkosfmqu Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=DVM0F+dL; spf=pass (imf26.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-HE-Tag: 1640261410-250670 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 23 Dec 2021 16:57:03 +0800 Guoqing Jiang wrote: > Usually, inline function is declared static since it should sit between > storage and type. And implement it in a header file if used by multiple > files. >=20 > And this change also fixes compile issue when backport damon to 5.10. >=20 > mm/damon/vaddr.c: In function =E2=80=98damon_va_evenly_split_region=E2=80= =99: > ./include/linux/damon.h:425:13: error: inlining failed in call to =E2=80= =98always_inline=E2=80=99 =E2=80=98damon_insert_region=E2=80=99: function= body not available > 425 | inline void damon_insert_region(struct damon_region *r, > | ^~~~~~~~~~~~~~~~~~~ > mm/damon/vaddr.c:86:3: note: called from here > 86 | damon_insert_region(n, r, next, t); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >=20 > Signed-off-by: Guoqing Jiang Thank you for this patch! Reviewed-by: SeongJae Park Thanks, SJ > --- > include/linux/damon.h | 13 +++++++++++-- > mm/damon/core.c | 11 ----------- > 2 files changed, 11 insertions(+), 13 deletions(-) >=20 > diff --git a/include/linux/damon.h b/include/linux/damon.h > index b4d4be3cc987..c0b03a8ef0d7 100644 > --- a/include/linux/damon.h > +++ b/include/linux/damon.h > @@ -422,9 +422,18 @@ struct damon_ctx { > #ifdef CONFIG_DAMON > =20 > struct damon_region *damon_new_region(unsigned long start, unsigned lo= ng end); > -inline void damon_insert_region(struct damon_region *r, > + > +/* > + * Add a region between two other regions > + */ > +static inline void damon_insert_region(struct damon_region *r, > struct damon_region *prev, struct damon_region *next, > - struct damon_target *t); > + struct damon_target *t) > +{ > + __list_add(&r->list, &prev->list, &next->list); > + t->nr_regions++; > +} > + > void damon_add_region(struct damon_region *r, struct damon_target *t); > void damon_destroy_region(struct damon_region *r, struct damon_target = *t); > =20 > diff --git a/mm/damon/core.c b/mm/damon/core.c > index e92497895202..01f6347385b4 100644 > --- a/mm/damon/core.c > +++ b/mm/damon/core.c > @@ -53,17 +53,6 @@ struct damon_region *damon_new_region(unsigned long = start, unsigned long end) > return region; > } > =20 > -/* > - * Add a region between two other regions > - */ > -inline void damon_insert_region(struct damon_region *r, > - struct damon_region *prev, struct damon_region *next, > - struct damon_target *t) > -{ > - __list_add(&r->list, &prev->list, &next->list); > - t->nr_regions++; > -} > - > void damon_add_region(struct damon_region *r, struct damon_target *t) > { > list_add_tail(&r->list, &t->regions_list); > --=20 > 2.26.2