From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 511ADC433EF for ; Fri, 14 Jan 2022 22:08:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DBFF26B0159; Fri, 14 Jan 2022 17:08:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D6CC56B015B; Fri, 14 Jan 2022 17:08:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C35466B015C; Fri, 14 Jan 2022 17:08:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0134.hostedemail.com [216.40.44.134]) by kanga.kvack.org (Postfix) with ESMTP id B09C06B0159 for ; Fri, 14 Jan 2022 17:08:58 -0500 (EST) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 722EC9675D for ; Fri, 14 Jan 2022 22:08:58 +0000 (UTC) X-FDA: 79030283556.29.E7EF0D9 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf28.hostedemail.com (Postfix) with ESMTP id B49F1C0011 for ; Fri, 14 Jan 2022 22:08:57 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 9399CCE2384; Fri, 14 Jan 2022 22:08:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B32DEC36AED; Fri, 14 Jan 2022 22:08:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1642198133; bh=OEr23vaDxvm6QNKQAFBebrhz6efR0tnYgbOQuxOfUbI=; h=Date:From:To:Subject:In-Reply-To:From; b=ldadwEOjh9XwSw7AQIVUBDy+R+Kogjb5/jz2EKoHjbGN53kCFljdasINAkyCkHgZL 8LXOSuwXP0OJsvO83deZ4/1DkgpgW9Z3dUIVutqu9VAHEPj9IxVI6fMSHPIqrp6tzF RWIcFejmvED6ff/ey9tgrFjhdK+6YA+Sy2BuyAx4= Date: Fri, 14 Jan 2022 14:08:53 -0800 From: Andrew Morton To: akpm@linux-foundation.org, colin.i.king@gmail.com, linux-mm@kvack.org, mm-commits@vger.kernel.org, torvalds@linux-foundation.org Subject: [patch 108/146] mm/migrate: remove redundant variables used in a for-loop Message-ID: <20220114220853.LyjnURLZU%akpm@linux-foundation.org> In-Reply-To: <20220114140222.6b14f0061194d3200000c52d@linux-foundation.org> User-Agent: s-nail v14.8.16 X-Stat-Signature: pegyddrr7npnwmp4jyez9xjjdnngw3rr Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=ldadwEOj; dmarc=none; spf=pass (imf28.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: B49F1C0011 X-HE-Tag: 1642198137-289539 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Colin Ian King Subject: mm/migrate: remove redundant variables used in a for-loop The variable addr is being set and incremented in a for-loop but not actually being used. It is redundant and so addr and also variable start can be removed. Link: https://lkml.kernel.org/r/20211221185729.609630-1-colin.i.king@gmail.com Signed-off-by: Colin Ian King Signed-off-by: Andrew Morton --- mm/migrate.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) --- a/mm/migrate.c~mm-migrate-remove-redundant-variables-used-in-a-for-loop +++ a/mm/migrate.c @@ -2481,8 +2481,7 @@ static bool migrate_vma_check_page(struc static void migrate_vma_unmap(struct migrate_vma *migrate) { const unsigned long npages = migrate->npages; - const unsigned long start = migrate->start; - unsigned long addr, i, restore = 0; + unsigned long i, restore = 0; bool allow_drain = true; lru_add_drain(); @@ -2528,7 +2527,7 @@ static void migrate_vma_unmap(struct mig } } - for (addr = start, i = 0; i < npages && restore; addr += PAGE_SIZE, i++) { + for (i = 0; i < npages && restore; i++) { struct page *page = migrate_pfn_to_page(migrate->src[i]); if (!page || (migrate->src[i] & MIGRATE_PFN_MIGRATE)) _