From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29FA2C433F5 for ; Fri, 14 Jan 2022 22:09:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AD78F6B0177; Fri, 14 Jan 2022 17:09:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A5FE36B0179; Fri, 14 Jan 2022 17:09:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 94E836B017A; Fri, 14 Jan 2022 17:09:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0121.hostedemail.com [216.40.44.121]) by kanga.kvack.org (Postfix) with ESMTP id 83CD96B0177 for ; Fri, 14 Jan 2022 17:09:44 -0500 (EST) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 4E4AB7C37A for ; Fri, 14 Jan 2022 22:09:44 +0000 (UTC) X-FDA: 79030285488.07.F2A3196 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf03.hostedemail.com (Postfix) with ESMTP id DE78A2000A for ; Fri, 14 Jan 2022 22:09:43 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id E6C83B825F5; Fri, 14 Jan 2022 22:09:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 727F3C36AE5; Fri, 14 Jan 2022 22:09:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1642198181; bh=2A3XM+2UG12YFp8tc/9YQ+vPnJHFwu+rf8Z18zCW6+8=; h=Date:From:To:Subject:In-Reply-To:From; b=ZddWNWtWUwf4PmALBRLCaJPGzEix6KczzKBT0xjCL8R14380kArlTHoA6ctPf9osx OnDBDGfMaZDYh/aXrRAhbxj1AdxVWckhP6K7Lxr0lWKUNd0N9MkQCvFZTMSXm+1uYw y9UUlOvgATrhVCcMN2G0iMMsPcE+oQOkoq2iPPOw= Date: Fri, 14 Jan 2022 14:09:40 -0800 From: Andrew Morton To: akpm@linux-foundation.org, linux-mm@kvack.org, mm-commits@vger.kernel.org, sj@kernel.org, songmuchun@bytedance.com, torvalds@linux-foundation.org, xhao@linux.alibaba.com Subject: [patch 123/146] mm/damon/core: use abs() instead of diff_of() Message-ID: <20220114220940.B19d9XhL-%akpm@linux-foundation.org> In-Reply-To: <20220114140222.6b14f0061194d3200000c52d@linux-foundation.org> User-Agent: s-nail v14.8.16 X-Rspamd-Queue-Id: DE78A2000A X-Stat-Signature: w6jrm4x7oujoe8xmyrqbf6wayimyiwyy Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=ZddWNWtW; spf=pass (imf03.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-Rspamd-Server: rspam07 X-HE-Tag: 1642198183-308598 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Xin Hao Subject: mm/damon/core: use abs() instead of diff_of() In kernel, we can use abs(a - b) to get the absolute value, So there is no need to redefine a new one. Link: https://lkml.kernel.org/r/b24e7b82d9efa90daf150d62dea171e19390ad0b.1636989871.git.xhao@linux.alibaba.com Signed-off-by: Xin Hao Reviewed-by: Muchun Song Reviewed-by: SeongJae Park Signed-off-by: Andrew Morton --- mm/damon/core.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) --- a/mm/damon/core.c~mm-damon-core-using-function-abs-instead-of-diff_of +++ a/mm/damon/core.c @@ -750,8 +750,6 @@ static void damon_merge_two_regions(stru damon_destroy_region(r, t); } -#define diff_of(a, b) (a > b ? a - b : b - a) - /* * Merge adjacent regions having similar access frequencies * @@ -765,13 +763,13 @@ static void damon_merge_regions_of(struc struct damon_region *r, *prev = NULL, *next; damon_for_each_region_safe(r, next, t) { - if (diff_of(r->nr_accesses, r->last_nr_accesses) > thres) + if (abs(r->nr_accesses - r->last_nr_accesses) > thres) r->age = 0; else r->age++; if (prev && prev->ar.end == r->ar.start && - diff_of(prev->nr_accesses, r->nr_accesses) <= thres && + abs(prev->nr_accesses - r->nr_accesses) <= thres && sz_damon_region(prev) + sz_damon_region(r) <= sz_limit) damon_merge_two_regions(t, prev, r); else _