From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0943DC433EF for ; Thu, 20 Jan 2022 02:08:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 76FBD6B0088; Wed, 19 Jan 2022 21:08:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 71ED76B0089; Wed, 19 Jan 2022 21:08:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 60E0C6B008A; Wed, 19 Jan 2022 21:08:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0107.hostedemail.com [216.40.44.107]) by kanga.kvack.org (Postfix) with ESMTP id 4EDF06B0088 for ; Wed, 19 Jan 2022 21:08:12 -0500 (EST) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 0A21B91E3A for ; Thu, 20 Jan 2022 02:08:12 +0000 (UTC) X-FDA: 79049030382.22.738561B Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf17.hostedemail.com (Postfix) with ESMTP id 8D0C24002A for ; Thu, 20 Jan 2022 02:08:11 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D75256157F; Thu, 20 Jan 2022 02:08:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0D5B8C004E1; Thu, 20 Jan 2022 02:08:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1642644490; bh=j2cofkI3mNswBUXxEt4eNVtlnxBYvQn69ZcQZ+MG/dE=; h=Date:From:To:Subject:In-Reply-To:From; b=BfJd1O81DsHDPqSvg3ICBa9z4VEYI/9VfublE7OtzGJjwXjwrD37jOUt8A7AhIGFz R1uHqfsjWDjJK6CE5Tjabf6bl81cqKtb/8t7rSdlMmZeDaz8lLQm4X1DIxsvR7KCaS 2uwfvSdg/UP8J4tIFmXdSp7Xnl5GP2SY9x3GQRBM= Date: Wed, 19 Jan 2022 18:08:09 -0800 From: Andrew Morton To: akpm@linux-foundation.org, linux-mm@kvack.org, luo.penghao@zte.com.cn, mcgrof@kernel.org, mm-commits@vger.kernel.org, torvalds@linux-foundation.org, zealci@zte.com.cn Subject: [patch 09/55] sysctl: remove redundant ret assignment Message-ID: <20220120020809.QepbJ2Fov%akpm@linux-foundation.org> In-Reply-To: <20220119180714.9e187ce100e4510de3cd9f7d@linux-foundation.org> User-Agent: s-nail v14.8.16 X-Rspamd-Queue-Id: 8D0C24002A X-Stat-Signature: yy7cgg9aikab1nswnp69nqsmsp7hucu6 Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=BfJd1O81; spf=pass (imf17.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-Rspamd-Server: rspam07 X-HE-Tag: 1642644491-742125 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: luo penghao Subject: sysctl: remove redundant ret assignment Subsequent if judgments will assign new values to ret, so the statement here should be deleted The clang_analyzer complains as follows: fs/proc/proc_sysctl.c: Value stored to 'ret' is never read Link: https://lkml.kernel.org/r/20211230063622.586360-1-luo.penghao@zte.com.cn Signed-off-by: luo penghao Reported-by: Zeal Robot Acked-by: Luis Chamberlain Signed-off-by: Andrew Morton --- fs/proc/proc_sysctl.c | 1 - 1 file changed, 1 deletion(-) --- a/fs/proc/proc_sysctl.c~sysctl-remove-redundant-ret-assignment +++ a/fs/proc/proc_sysctl.c @@ -1053,7 +1053,6 @@ static int sysctl_follow_link(struct ctl struct ctl_dir *dir; int ret; - ret = 0; spin_lock(&sysctl_lock); root = (*pentry)->data; set = lookup_header_set(root); _