From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3D06C43217 for ; Tue, 25 Jan 2022 17:59:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 88C2B6B0073; Tue, 25 Jan 2022 12:59:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7EE826B0074; Tue, 25 Jan 2022 12:59:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 666896B0075; Tue, 25 Jan 2022 12:59:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0144.hostedemail.com [216.40.44.144]) by kanga.kvack.org (Postfix) with ESMTP id 51AC86B0073 for ; Tue, 25 Jan 2022 12:59:17 -0500 (EST) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 029601816C8B9 for ; Tue, 25 Jan 2022 17:59:17 +0000 (UTC) X-FDA: 79069571154.19.A33D481 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf12.hostedemail.com (Postfix) with ESMTP id 62CE240009 for ; Tue, 25 Jan 2022 17:59:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1643133555; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tQwnOxnoIr5kWKtczEX49APK7YeWZviqLQA1sp5peAU=; b=QjHh+Hp8TizOE4FgVulGUllZmBkvmk5dtJVN74+84RUT7cKIdFXDrGu3PWSEh8P3NjJvs1 agTsfTuTjzioaRv+tQYvoONcr0Dkf9UJJ7WJ6rsj3GxLA7lanU+oCTkAw62tUHN+L19xFy 6silaCCw/sO8Bru5wCqGg9JDsPrJNuw= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-465-9SlfRf5ZPYKPwLZXLYbkSg-1; Tue, 25 Jan 2022 12:59:13 -0500 X-MC-Unique: 9SlfRf5ZPYKPwLZXLYbkSg-1 Received: by mail-ej1-f70.google.com with SMTP id ky6-20020a170907778600b0068e4bd99fd1so3757220ejc.15 for ; Tue, 25 Jan 2022 09:59:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=tQwnOxnoIr5kWKtczEX49APK7YeWZviqLQA1sp5peAU=; b=TdIw8iSgNUs1EE14ZMEqWcirV6Hq6FVf/f5vsMm2dd3F3QPdeLrT3uYIvjbNIm+MKX YdrfX48vMai1sR66sPlee82N4pURF/MOPIccKnwbJtBk0WnLCyJZz8hkrdStAckMsO1P 1wkwfNJz3cqAKMnSeWBbq3pkMjJwN7P6n6lttwPsQgsC0oCDHr7rRjoLqERBm2LZtILm 9cpECFRaAkqJR8Gz6TqQ7ONRLQr50Jx6G+83RjQYIWyVV1QApxRY0tPsL6uNtSoUVK0J VxBWKrZob70c2meItS/TpY2gDSzy79WJOckefrcaoo7vs15PeZa4wLne4oV1G6hU7Q+O DFUw== X-Gm-Message-State: AOAM533azvuXCj4Yaw16v+Zh00hM0peSRMQuqqDwo5IP2zA58UPmZOGd HUCMZB3E5BGVwu0AXdkauQ8IUjoED7HktUxEjMkuNLuriJy8Hgr/Ty2FPEFkNND0C3NddpBMUiz qY3EeEwBZBds= X-Received: by 2002:a17:907:72c4:: with SMTP id du4mr9152832ejc.243.1643133552675; Tue, 25 Jan 2022 09:59:12 -0800 (PST) X-Google-Smtp-Source: ABdhPJz7m6XPepvwD9UHHPdetVwWNbg/dFQ1MV8dbRVv9I9eBjYFCvpX/V21GrFvuzJV6aICXTe9mQ== X-Received: by 2002:a17:907:72c4:: with SMTP id du4mr9152815ejc.243.1643133552428; Tue, 25 Jan 2022 09:59:12 -0800 (PST) Received: from redhat.com ([176.12.185.204]) by smtp.gmail.com with ESMTPSA id d5sm8562973edz.78.2022.01.25.09.59.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Jan 2022 09:59:11 -0800 (PST) Date: Tue, 25 Jan 2022 12:59:08 -0500 From: "Michael S. Tsirkin" To: Miaohe Lin Cc: akpm@linux-foundation.org, david@redhat.com, virtualization@lists.linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/balloon_compaction: make balloon page compaction callbacks static Message-ID: <20220125125853-mutt-send-email-mst@kernel.org> References: <20220125132221.2220-1-linmiaohe@huawei.com> MIME-Version: 1.0 In-Reply-To: <20220125132221.2220-1-linmiaohe@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Stat-Signature: 9rrkysctegu8oe9t8zoh5x7achr4y1g8 X-Rspam-User: nil Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QjHh+Hp8; spf=none (imf12.hostedemail.com: domain of mst@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=mst@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 62CE240009 X-HE-Tag: 1643133555-481663 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jan 25, 2022 at 09:22:21PM +0800, Miaohe Lin wrote: > Since commit b1123ea6d3b3 ("mm: balloon: use general non-lru movable page > feature"), these functions are called via balloon_aops callbacks. They're > not called directly outside this file. So make them static and clean up > the relevant code. > > Signed-off-by: Miaohe Lin Acked-by: Michael S. Tsirkin I'll queue this unless someone else does first. > --- > include/linux/balloon_compaction.h | 22 ---------------------- > mm/balloon_compaction.c | 6 +++--- > 2 files changed, 3 insertions(+), 25 deletions(-) > > diff --git a/include/linux/balloon_compaction.h b/include/linux/balloon_compaction.h > index 338aa27e4773..edb7f6d41faa 100644 > --- a/include/linux/balloon_compaction.h > +++ b/include/linux/balloon_compaction.h > @@ -80,12 +80,6 @@ static inline void balloon_devinfo_init(struct balloon_dev_info *balloon) > > #ifdef CONFIG_BALLOON_COMPACTION > extern const struct address_space_operations balloon_aops; > -extern bool balloon_page_isolate(struct page *page, > - isolate_mode_t mode); > -extern void balloon_page_putback(struct page *page); > -extern int balloon_page_migrate(struct address_space *mapping, > - struct page *newpage, > - struct page *page, enum migrate_mode mode); > > /* > * balloon_page_insert - insert a page into the balloon's page list and make > @@ -155,22 +149,6 @@ static inline void balloon_page_delete(struct page *page) > list_del(&page->lru); > } > > -static inline bool balloon_page_isolate(struct page *page) > -{ > - return false; > -} > - > -static inline void balloon_page_putback(struct page *page) > -{ > - return; > -} > - > -static inline int balloon_page_migrate(struct page *newpage, > - struct page *page, enum migrate_mode mode) > -{ > - return 0; > -} > - > static inline gfp_t balloon_mapping_gfp_mask(void) > { > return GFP_HIGHUSER; > diff --git a/mm/balloon_compaction.c b/mm/balloon_compaction.c > index 907fefde2572..4b8eab4b3f45 100644 > --- a/mm/balloon_compaction.c > +++ b/mm/balloon_compaction.c > @@ -203,7 +203,7 @@ EXPORT_SYMBOL_GPL(balloon_page_dequeue); > > #ifdef CONFIG_BALLOON_COMPACTION > > -bool balloon_page_isolate(struct page *page, isolate_mode_t mode) > +static bool balloon_page_isolate(struct page *page, isolate_mode_t mode) > > { > struct balloon_dev_info *b_dev_info = balloon_page_device(page); > @@ -217,7 +217,7 @@ bool balloon_page_isolate(struct page *page, isolate_mode_t mode) > return true; > } > > -void balloon_page_putback(struct page *page) > +static void balloon_page_putback(struct page *page) > { > struct balloon_dev_info *b_dev_info = balloon_page_device(page); > unsigned long flags; > @@ -230,7 +230,7 @@ void balloon_page_putback(struct page *page) > > > /* move_to_new_page() counterpart for a ballooned page */ > -int balloon_page_migrate(struct address_space *mapping, > +static int balloon_page_migrate(struct address_space *mapping, > struct page *newpage, struct page *page, > enum migrate_mode mode) > { > -- > 2.23.0