From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E216C433EF for ; Fri, 28 Jan 2022 14:21:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8B1966B00C3; Fri, 28 Jan 2022 09:21:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8600F6B00C5; Fri, 28 Jan 2022 09:21:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7011B6B00C6; Fri, 28 Jan 2022 09:21:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0029.hostedemail.com [216.40.44.29]) by kanga.kvack.org (Postfix) with ESMTP id 5E6A96B00C3 for ; Fri, 28 Jan 2022 09:21:42 -0500 (EST) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 1806E181D2090 for ; Fri, 28 Jan 2022 14:21:42 +0000 (UTC) X-FDA: 79079909244.05.F22BD7D Received: from mail-qv1-f41.google.com (mail-qv1-f41.google.com [209.85.219.41]) by imf24.hostedemail.com (Postfix) with ESMTP id 2779318001B for ; Fri, 28 Jan 2022 14:21:41 +0000 (UTC) Received: by mail-qv1-f41.google.com with SMTP id s6so5909789qvv.11 for ; Fri, 28 Jan 2022 06:21:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=makDagrHRlU7vaXpIkbBqsJmR2imX/hQ0vT1IyZGbe8=; b=hagW1D3vrAXgmIdAaPuyb0ZYpBBI5GPj5cGf4t4VMPl2Hby0LDAfvZWMHlJD4RNPqz udQ6uMwMCSFght7z8OXaOlANPe89fBH+JadGzhs2iy3sYKIgrM8DNT9kykuob784vNJb /Y/FgIYpTCK+z7cKXzoYjO1GyqMmNfC0h5hNyGY73VQ5CoPXpXPP9nyVMuQ4vWD+VQga 0hYXfzvwCLnChzgjp4NqFihb4T9f8dI0raxoWaXnXY+5G5GDrUXCHtUcKwBORYZObA9Y YPaqcPq/4bzPj+zORYsBg7/S7b+i2mhRoE+TwNrxyzVcDs3wf6ttmJBlILKVUF4beVAI 0u4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=makDagrHRlU7vaXpIkbBqsJmR2imX/hQ0vT1IyZGbe8=; b=qXFpvV3kblIBf51YB7Hv0/pDIsYaB/WhN3Y6gB7T+LBxcwTh04CbDud4BdYBC+iR7n yz7cH41qTlnHnvWgM4mG36cj6SNeEAZHj+IbgCz3qBb6WsD6evcJcmgsizLHkTLHBVxw 2ufb0xycV28YhnSB0AYx5EukJ/9oTci8paMy+3ZPHyysOkgjDvdriAls3vsidHvHkEYq fpqYKSx3u59uD+ctIMs9I7kkYVewPxXtCxoa1BnZS4OKj6UcqqnKNOF6Nndjtjd5wVQy c7bYhx1i3Nb0MrIX6/tqFJlmT7BltJdn5vjrYQTfdFlCxzkSpBa5XU6BSvGh/TIjh4VS hXyg== X-Gm-Message-State: AOAM533j8P+UYqyTn7qefXdpLh/CS4AT3EZpYppl85YblkzQOv/KRgOF yo3IqzpV+wNEBB+BBWuplzuSpA== X-Google-Smtp-Source: ABdhPJw4cx6/r5UFZ4KcHMvTw88cPD84uAemPNZJJIK7lCC9YLt9fXRF4PueHdJDgL+a1AuPlHcoPg== X-Received: by 2002:a05:6214:519a:: with SMTP id kl26mr7027757qvb.68.1643379700472; Fri, 28 Jan 2022 06:21:40 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-162-113-129.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.113.129]) by smtp.gmail.com with ESMTPSA id o4sm3070925qtw.53.2022.01.28.06.21.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Jan 2022 06:21:39 -0800 (PST) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1nDS8A-007UXM-Bu; Fri, 28 Jan 2022 10:21:38 -0400 Date: Fri, 28 Jan 2022 10:21:38 -0400 From: Jason Gunthorpe To: Logan Gunthorpe Cc: linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, linux-block@vger.kernel.org, linux-pci@vger.kernel.org, linux-mm@kvack.org, iommu@lists.linux-foundation.org, Stephen Bates , Christoph Hellwig , Dan Williams , Christian =?utf-8?B?S8O2bmln?= , John Hubbard , Don Dutile , Matthew Wilcox , Daniel Vetter , Jakowski Andrzej , Minturn Dave B , Jason Ekstrand , Dave Hansen , Xiong Jianxin , Bjorn Helgaas , Ira Weiny , Robin Murphy , Martin Oliveira , Chaitanya Kulkarni , Ralph Campbell , Alex Sierra Subject: Re: [PATCH v5 02/24] mm: remove extra ZONE_DEVICE struct page refcount Message-ID: <20220128142138.GU8034@ziepe.ca> References: <20220128002614.6136-1-logang@deltatee.com> <20220128002614.6136-3-logang@deltatee.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220128002614.6136-3-logang@deltatee.com> X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 2779318001B X-Rspam-User: nil Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=ziepe.ca header.s=google header.b=hagW1D3v; dmarc=none; spf=pass (imf24.hostedemail.com: domain of jgg@ziepe.ca designates 209.85.219.41 as permitted sender) smtp.mailfrom=jgg@ziepe.ca X-Stat-Signature: iixnymjnfn5y6yrz7xpboawednomnfwp X-HE-Tag: 1643379701-517693 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jan 27, 2022 at 05:25:52PM -0700, Logan Gunthorpe wrote: > From: Ralph Campbell > > ZONE_DEVICE struct pages have an extra reference count that complicates the > code for put_page() and several places in the kernel that need to check the > reference count to see that a page is not being used (gup, compaction, > migration, etc.). Clean up the code so the reference count doesn't need to > be treated specially for ZONE_DEVICE. > > [logang: dropped no longer used section from mm.h including > page_is_devmap_managed, rebased on v5.17-rc1 (possibly poorly)] > Signed-off-by: Ralph Campbell > Signed-off-by: Alex Sierra > Signed-off-by: Logan Gunthorpe > Reviewed-by: Christoph Hellwig > --- > arch/powerpc/kvm/book3s_hv_uvmem.c | 2 +- > drivers/gpu/drm/nouveau/nouveau_dmem.c | 2 +- > fs/dax.c | 4 +- > include/linux/dax.h | 2 +- > include/linux/memremap.h | 7 +-- > include/linux/mm.h | 44 ---------------- > lib/test_hmm.c | 2 +- > mm/internal.h | 8 +++ > mm/memcontrol.c | 6 +-- > mm/memremap.c | 70 +++++++------------------- > mm/migrate.c | 5 -- > mm/page_alloc.c | 3 ++ > mm/swap.c | 45 ++--------------- > 13 files changed, 46 insertions(+), 154 deletions(-) This patch still can't be applied until the FSDAX issues are solved, right? See my remarks the last time it was posted.. Jason