From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A78DDC433F5 for ; Mon, 31 Jan 2022 01:47:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A68416B0073; Sun, 30 Jan 2022 20:47:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A16B26B00A9; Sun, 30 Jan 2022 20:47:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8DE866B00AA; Sun, 30 Jan 2022 20:47:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.a.hostedemail.com [64.99.140.24]) by kanga.kvack.org (Postfix) with ESMTP id 804826B0073 for ; Sun, 30 Jan 2022 20:47:46 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id 22A86609A7 for ; Mon, 31 Jan 2022 01:47:46 +0000 (UTC) X-FDA: 79088895732.01.BCDC7E6 Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) by imf21.hostedemail.com (Postfix) with ESMTP id AC3DF1C000A for ; Mon, 31 Jan 2022 01:47:45 +0000 (UTC) Received: by mail-ej1-f51.google.com with SMTP id jx6so38096418ejb.0 for ; Sun, 30 Jan 2022 17:47:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:reply-to:references:mime-version :content-disposition:in-reply-to:user-agent; bh=GkhcVI15gZvcXdR5pviGmh2yWHBWlCX9+d8RaY4e+NM=; b=PfyBxdltlF5w8FdwbosIkSlZzhAS88lLwzicvgGmn7xMF0OiLXyFp7jBJ+KYSOI8tr NbPMvTbcV4JbZNNp20xGFl3AMeb/E+EMXetLXJwImVXPbXX1kWO6/DDtB7T2mDRL3cyp 4WgU+haILaHGlh+fgujO8pp7nejO5xH8eEnak74PC/dNK6jU8ClUnq7oO4M3AeM0exEH ZOvXBdgV7hP7WUEUXXxJ0TaXCPNbO2iCYVuxqGSjBA234DinG1NHNrZ7t2sV1Pkwi58t DTDDI4UG3KN/ephUzZ/QvJEDWEbtuY/qVcNiXhKuWk2Tf673dInDX8sgdpMUTh4VNO58 6TFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:reply-to :references:mime-version:content-disposition:in-reply-to:user-agent; bh=GkhcVI15gZvcXdR5pviGmh2yWHBWlCX9+d8RaY4e+NM=; b=70vqi5mkqvCBAbJUaJ1N686TKqpN69NeWeTwLL0oCPBGb68jPAZtSTGPV9PXQ4Zf6U owvZu/ZKbkC7V9GXGpjvzxKTAaDBVjuVjNgv5z0NkmwMveCWShhcjmRQ7sSEQk/Q/LLb yMpHcOCoAvaJG5OufOIxcmlDQ14X8a3ZI4SBy/6uwblVkkZJk+/UulEe+kwfz4itSOBN 5e31UVvpXHPrWPvE8/RjiRJPbURyQTZ7Umhz76Ka8CVO5gwVJhvUSBYfuG1yIesGe1Ft 4KA31RTSf/OyjPcO8CemmDUl4sYg9MG5nG/T15xhzAgMrLnyOhHMzM7grIKajV5+KEaz a62w== X-Gm-Message-State: AOAM532x35REO6uz5XJLUYNcF5X8kFV4zdkUxUCQCdetupLih11oNYaA kUW6Mj0/L3ss7hI4tbjpM2M= X-Google-Smtp-Source: ABdhPJzfYskGQVCQ6wlLyAtq1snJ/WfxGxvPFR8YnzeiPFr+T1v1iY4Je9WzafGVZ+KwY9OEoJrNxw== X-Received: by 2002:a17:907:9726:: with SMTP id jg38mr7677174ejc.384.1643593664095; Sun, 30 Jan 2022 17:47:44 -0800 (PST) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id hq28sm10407000ejc.204.2022.01.30.17.47.43 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 30 Jan 2022 17:47:43 -0800 (PST) Date: Mon, 31 Jan 2022 01:47:42 +0000 From: Wei Yang To: akpm@linux-foundation.org Cc: hannes@cmpxchg.org, mhocko@kernel.org, vdavydov.dev@gmail.com, akpm@linux-foundation.org, shakeelb@google.com, guro@fb.com, vbabka@suse.cz, willy@infradead.org, songmuchun@bytedance.com, shy828301@gmail.com, surenb@google.com, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 1/4] mm/memcg: use NUMA_NO_NODE to indicate allocation from unspecified node Message-ID: <20220131014742.oxcrctcg6sqwvzij@master> Reply-To: Wei Yang References: <20220111010302.8864-1-richard.weiyang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220111010302.8864-1-richard.weiyang@gmail.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: AC3DF1C000A X-Stat-Signature: mcemz5t3xput69hcq1admargw3yafa38 Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=PfyBxdlt; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf21.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.51 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com X-Rspam-User: nil X-HE-Tag: 1643593665-608832 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi, Andrew Would you pick up this patch set, or prefer me to send a v2? On Tue, Jan 11, 2022 at 01:02:59AM +0000, Wei Yang wrote: >Instead of use "-1", let's use NUMA_NO_NODE for consistency. > >Signed-off-by: Wei Yang >--- > mm/memcontrol.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/mm/memcontrol.c b/mm/memcontrol.c >index 2ed5f2a0879d..11715f7323c0 100644 >--- a/mm/memcontrol.c >+++ b/mm/memcontrol.c >@@ -5054,7 +5054,7 @@ static int alloc_mem_cgroup_per_node_info(struct mem_cgroup *memcg, int node) > * function. > */ > if (!node_state(node, N_NORMAL_MEMORY)) >- tmp = -1; >+ tmp = NUMA_NO_NODE; > pn = kzalloc_node(sizeof(*pn), GFP_KERNEL, tmp); > if (!pn) > return 1; >-- >2.33.1 -- Wei Yang Help you, Help me