From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88E91C433F5 for ; Mon, 31 Jan 2022 23:44:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 22D388D0036; Mon, 31 Jan 2022 18:44:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1DCC08D0028; Mon, 31 Jan 2022 18:44:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 07E3C8D0036; Mon, 31 Jan 2022 18:44:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0061.hostedemail.com [216.40.44.61]) by kanga.kvack.org (Postfix) with ESMTP id EDD7F8D0028 for ; Mon, 31 Jan 2022 18:44:02 -0500 (EST) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id AEADF181CB165 for ; Mon, 31 Jan 2022 23:44:02 +0000 (UTC) X-FDA: 79092212724.07.8B2A1F6 Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) by imf08.hostedemail.com (Postfix) with ESMTP id 4FA74160004 for ; Mon, 31 Jan 2022 23:44:02 +0000 (UTC) Received: by mail-lf1-f45.google.com with SMTP id x23so30341823lfc.0 for ; Mon, 31 Jan 2022 15:44:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=+h8DeuUfkcjLos3BviUGDVOpxtzirtyuHipEzyipWwg=; b=LEHAp+tjvjupiksn3rRU+MTYTYJP1zmZug2s1ZZldzoTJGpYo9m+xIPjubK2rtcde8 GPVx0URubvo/jJvle5RTJhnlLC6JqkPwVNpFtC6I83045f95Guvh3joXjYsjHykGAlhq 92OP3IdGZsIVkSJitzv8T5+TJfntyXg5hJSlvUP6BKmhR65VEndbO031zvU3CMnXmYk9 37chJ05w0IkvWVqNAA3kZqvLNIDXrV27x1B83Wu+CnJ9lk9O+BCi95z2rkMNtZXgJub7 vR4PpZz9noMFzfCD8iynifIes6TpoGPVFMyIInGkSWaFrJWp7gVEPpedEqol12ZjoTY0 Ef8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=+h8DeuUfkcjLos3BviUGDVOpxtzirtyuHipEzyipWwg=; b=TLn9QyKlbKv8Riei/2t9T3Rf6esli4BhOcm/8V/igyRHPjMjBxO4YMUPc40D57Dflr /EdVTdgTq1GKN4TVFG5TR+CgVDftNKbgqjj4Z7Uph9LlrJDqYRbduYgckxDG7K2qEMqM t3zW66wG0hmaRdNapgSywrV1GNa5jLiTEgUTBfRWfNNyYE71vKVLU18CBVvPcVkwenIs UJueyI4laxCZkBLMUPO+hGUZRkLUaX2v09OTxo4BW9zEBN9INaB4XjMfkY8kgMlQfBwP EuGjEC4KHf42zUFuF6P3ug2/0eIomjWK2YEtO07vMyhPBpb6ZInxw+T9l/Bp22DohndR 3z0Q== X-Gm-Message-State: AOAM5334LA8tfgq7gwe0SWqm+FH7QUU6INoNoS+tqSp6BeWGlOFUMrUU SdhwJ0yBSsuo9mWX9YexAZHrdA== X-Google-Smtp-Source: ABdhPJy9muQCEl5VEBzDXlXUJUJcCiNqcoX+SUeTK/d+sBX/xKeTfWiTXJNIQJsO4DDl7bWle3JZBg== X-Received: by 2002:a05:6512:1116:: with SMTP id l22mr16771617lfg.219.1643672640599; Mon, 31 Jan 2022 15:44:00 -0800 (PST) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id m12sm3812652lfj.90.2022.01.31.15.43.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Jan 2022 15:43:59 -0800 (PST) Received: by box.localdomain (Postfix, from userid 1000) id 5452110458C; Tue, 1 Feb 2022 02:44:37 +0300 (+03) Date: Tue, 1 Feb 2022 02:44:37 +0300 From: "Kirill A. Shutemov" To: Dave Hansen Cc: "Kirill A. Shutemov" , Borislav Petkov , Andy Lutomirski , Sean Christopherson , Andrew Morton , Joerg Roedel , Ard Biesheuvel , Andi Kleen , Kuppuswamy Sathyanarayanan , David Rientjes , Vlastimil Babka , Tom Lendacky , Thomas Gleixner , Peter Zijlstra , Paolo Bonzini , Ingo Molnar , Varad Gautam , Dario Faggioli , Brijesh Singh , Mike Rapoport , David Hildenbrand , x86@kernel.org, linux-mm@kvack.org, linux-coco@lists.linux.dev, linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv3 2/7] efi/x86: Get full memory map in allocate_e820() Message-ID: <20220131234437.twazkxvsdukhq2xs@box.shutemov.name> References: <20220128205906.27503-1-kirill.shutemov@linux.intel.com> <20220128205906.27503-3-kirill.shutemov@linux.intel.com> <101a4497-ae17-ab69-640d-667c79da639b@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <101a4497-ae17-ab69-640d-667c79da639b@intel.com> X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 4FA74160004 X-Stat-Signature: oq9jfec9f6sk8cfsa5w5hf41bzam5tpd Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=shutemov-name.20210112.gappssmtp.com header.s=20210112 header.b=LEHAp+tj; dmarc=none; spf=none (imf08.hostedemail.com: domain of kirill@shutemov.name has no SPF policy when checking 209.85.167.45) smtp.mailfrom=kirill@shutemov.name X-Rspam-User: nil X-HE-Tag: 1643672642-825132 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jan 31, 2022 at 02:38:42PM -0800, Dave Hansen wrote: > On 1/28/22 12:59, Kirill A. Shutemov wrote: > > Modify allocate_e820() to get a full memory map. > > Dumb question time: why doesn't the current code get a full memory map? > This looks simpler. What's the downside? Memory consumption? Yeah, it requires memory allocation that has to be freed back. Otherwise I don't see any downsides. There are several more EFI calls, but it should not make a noticable difference on boot time. -- Kirill A. Shutemov