From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15B2AC433F5 for ; Tue, 1 Feb 2022 02:41:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9CC4E8D004F; Mon, 31 Jan 2022 21:41:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 97B268D0028; Mon, 31 Jan 2022 21:41:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 843F28D004F; Mon, 31 Jan 2022 21:41:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0005.hostedemail.com [216.40.44.5]) by kanga.kvack.org (Postfix) with ESMTP id 751EA8D0028 for ; Mon, 31 Jan 2022 21:41:55 -0500 (EST) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 3CE86181CB2DE for ; Tue, 1 Feb 2022 02:41:55 +0000 (UTC) X-FDA: 79092660990.29.0FC9444 Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) by imf11.hostedemail.com (Postfix) with ESMTP id CA1B240004 for ; Tue, 1 Feb 2022 02:41:54 +0000 (UTC) Received: by mail-ej1-f51.google.com with SMTP id s13so49439536ejy.3 for ; Mon, 31 Jan 2022 18:41:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:reply-to:references:mime-version :content-disposition:in-reply-to:user-agent; bh=o+aNazM92DpchyM2fptN7BUFRXkWjezucT0stoL0ipM=; b=Tcd/oRvHBzzZewL8wbSRs0n2QUG6q4SMMfSwuxSP4LVbmDVHyh4Ie7anUyNyxxW7Q4 QswsnH0dFPkvXVyyGqDB/235lIqcPs9kXcuu4+dQXs8ywtHH82qMHQaW+MbZDg7hc0Kp PKuyOCEyq7YcN+uHXx2zUU7htCTgU63fYHKkcq1Dz5nj1Tay8FySEwy9Jvb+eVNHeD5r NfoVVWZNi/Qn1KAR1UdvARqBwL499XJ3GtenMyOw0XnYpt+XuYo9g6N+cp4703Cew+6n TisZdLekqzSIPfWawz02ooqsk3ebtk8+FdI2kb/Xcjkj/ILcx5XOWRxwqJpqc7E2gjuW 7aDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:reply-to :references:mime-version:content-disposition:in-reply-to:user-agent; bh=o+aNazM92DpchyM2fptN7BUFRXkWjezucT0stoL0ipM=; b=QdrUfcaKz+4usA5XLsVnTLGQJMxGylj359DkoV9ss30pR3lLlXBTsP3xPFs9eWIqn/ vnk/sgGPJ9xT3ar30sbZ1TQmjSxu+TWNJ7iC5b823iHnVoXHFG8vJxx7WLz+2WcWsCu0 LAjIN0jhF0F/+S7QxUIlEF5S2FkYW3WyiDUfP4p742wqrZOh3I8wYSA4jS1jr/kmlp1O J08oglFsdHyZIIXsQpxwaqNVmxx0noG9I8h5ht+k7uZICEEcIJqmzwlzdfO5OnBdMkfe 7ivU/G4XmQXnga3NZlziK92JNHoZP581hHcsWqAgKX83gyHn/lSRR9+DKi5GOQw4fVSZ MQbg== X-Gm-Message-State: AOAM532Qi+gdDZkMyIlr+butRmxRIynTOgMHXdwnU0oc83ZFqBf8Oz5G yAQ0baUrujN29RWYZlAW2iA= X-Google-Smtp-Source: ABdhPJzYqv1vgovmdPPLB4hXAVGSzSDZt5gDd3jOAh2KUerPN9Y55dKa0R39LxalcjdM2uu8dmviMQ== X-Received: by 2002:a17:907:60cf:: with SMTP id hv15mr18907361ejc.702.1643683313812; Mon, 31 Jan 2022 18:41:53 -0800 (PST) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id a11sm18670116edv.76.2022.01.31.18.41.53 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 31 Jan 2022 18:41:53 -0800 (PST) Date: Tue, 1 Feb 2022 02:41:52 +0000 From: Wei Yang To: Michal Hocko Cc: Andrew Morton , linux-mm@kvack.org, LKML , David Hildenbrand , Alexey Makhalov , Dennis Zhou , Eric Dumazet , Oscar Salvador , Tejun Heo , Christoph Lameter , Nico Pache , Wei Yang , Rafael Aquini , Michal Hocko Subject: Re: [PATCH 3/6] mm, memory_hotplug: drop arch_free_nodedata Message-ID: <20220201024152.uqksmmethxs4q2pe@master> Reply-To: Wei Yang References: <20220127085305.20890-1-mhocko@kernel.org> <20220127085305.20890-4-mhocko@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220127085305.20890-4-mhocko@kernel.org> User-Agent: NeoMutt/20170113 (1.7.2) X-Rspam-User: nil X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: CA1B240004 X-Stat-Signature: 4wp4q8yxpp3ptixkisypj76h4r9ad9ne Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="Tcd/oRvH"; spf=pass (imf11.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.51 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-HE-Tag: 1643683314-470037 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jan 27, 2022 at 09:53:02AM +0100, Michal Hocko wrote: >From: Michal Hocko > >Prior to "mm: handle uninitialized numa nodes gracefully" memory hotplug >used to allocate pgdat when memory has been added to a node >(hotadd_init_pgdat) arch_free_nodedata has been only used in the >failure path because once the pgdat is exported (to be visible >by NODA_DATA(nid)) it cannot really be freed because there is no >synchronization available for that. > >pgdat is allocated for each possible nodes now so the memory hotplug >doesn't need to do the ever use arch_free_nodedata so drop it. > >This patch doesn't introduce any functional change. > >Acked-by: Rafael Aquini >Signed-off-by: Michal Hocko Reviewed-by: Wei Yang -- Wei Yang Help you, Help me