Re: [PATCH 4/6] mm, memory_hotplug: reorganize new pgdat initialization

Oscar Salvador
2022-02-17T10:40:37Z

On Thu, Jan 27, 2022 at 03:44:21PM +0100, Michal Hocko wrote:
> > I feel like we should be initializing all of this only once, just after
> > allocating the node. There should be no difference between a node we're
> > reusing and a "fresh" node. IOW, memory offlining should be resetting
> > all state accordingly when the last memory goes away.
> >
> > But I might be wrong and this patch looks like an improvement, as you
> > say, without functional change
>
> Yeah, I really wanted to have this simple and straightforward. To be
> completely honest I am not even sure this is necessary. Something really
> woth looking at.

Seizing the opportunity that I had to look at this code and at x86's
numa init code again I am preparing something to further sort this out and
simplify it a bit.

So I will have something soon unless someone beats me to it first.

--
Oscar Salvador
SUSE Labs