From: Wei Yang <richard.weiyang@gmail.com>
To: Michal Hocko <mhocko@suse.com>
Cc: Wei Yang <richard.weiyang@gmail.com>,
akpm@linux-foundation.org, mgorman@techsingularity.net,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/memory_hotplug: build zonelist for managed_zone
Date: Tue, 1 Feb 2022 06:33:38 +0000 [thread overview]
Message-ID: <20220201063338.u4ux2jsgctuo7tex@master> (raw)
In-Reply-To: <Yfe48O7eBWSe0LjK@dhcp22.suse.cz>
On Mon, Jan 31, 2022 at 11:24:48AM +0100, Michal Hocko wrote:
>> >> This patch restore the original behavior by using the same criteria to
>> >> add a zone in zonelist during memory hotplug.
>> >
>> >Why?
>> >
>>
>> In case we online a populated zone, but not managed. Then this zone will not
>> be in zonelist. Right?
>
>yeah. We can theoretically end up with a zone without any managed menory
>on the zonelists. But my primary question is why do we need this change?
Currently I don't see a real case for this.
>Does it fix any existing problem? Does it make the code easier to
>read/understand? Does it improve performance? Every patch should have a
>justification. Your changelog merely lists the history and then states
>the new behavior without any explanation of why that is needed or
>desired. See?
I don't have such reason now.
>--
>Michal Hocko
>SUSE Labs
--
Wei Yang
Help you, Help me
next prev parent reply other threads:[~2022-02-01 6:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-27 1:20 [PATCH] mm/memory_hotplug: build zonelist for managed_zone Wei Yang
2022-01-27 8:28 ` Michal Hocko
2022-01-29 0:26 ` Wei Yang
2022-01-31 10:24 ` Michal Hocko
2022-02-01 6:33 ` Wei Yang [this message]
2022-01-27 8:39 ` David Hildenbrand
2022-01-29 0:27 ` Wei Yang
2022-01-31 10:53 ` David Hildenbrand
2022-02-01 7:00 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220201063338.u4ux2jsgctuo7tex@master \
--to=richard.weiyang@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).