From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <owner-linux-mm@kvack.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 60DE5C433EF
	for <linux-mm@archiver.kernel.org>; Wed,  2 Feb 2022 14:35:55 +0000 (UTC)
Received: by kanga.kvack.org (Postfix)
	id DA0ED8D010F; Wed,  2 Feb 2022 09:35:54 -0500 (EST)
Received: by kanga.kvack.org (Postfix, from userid 40)
	id D4FE08D00F9; Wed,  2 Feb 2022 09:35:54 -0500 (EST)
X-Delivered-To: int-list-linux-mm@kvack.org
Received: by kanga.kvack.org (Postfix, from userid 63042)
	id C17C98D010F; Wed,  2 Feb 2022 09:35:54 -0500 (EST)
X-Delivered-To: linux-mm@kvack.org
Received: from forelay.hostedemail.com (smtprelay0189.hostedemail.com [216.40.44.189])
	by kanga.kvack.org (Postfix) with ESMTP id B20ED8D00F9
	for <linux-mm@kvack.org>; Wed,  2 Feb 2022 09:35:54 -0500 (EST)
Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251])
	by forelay03.hostedemail.com (Postfix) with ESMTP id 7671280F3DE7
	for <linux-mm@kvack.org>; Wed,  2 Feb 2022 14:35:54 +0000 (UTC)
X-FDA: 79098089028.26.2E54A48
Received: from verein.lst.de (verein.lst.de [213.95.11.211])
	by imf15.hostedemail.com (Postfix) with ESMTP id CAC0EA0003
	for <linux-mm@kvack.org>; Wed,  2 Feb 2022 14:35:53 +0000 (UTC)
Received: by verein.lst.de (Postfix, from userid 2407)
	id 5087468AFE; Wed,  2 Feb 2022 15:35:49 +0100 (CET)
Date: Wed, 2 Feb 2022 15:35:49 +0100
From: Christoph Hellwig <hch@lst.de>
To: David Hildenbrand <david@redhat.com>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>,
	Hugh Dickins <hughd@google.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	David Rientjes <rientjes@google.com>,
	Shakeel Butt <shakeelb@google.com>,
	John Hubbard <jhubbard@nvidia.com>,
	Jason Gunthorpe <jgg@nvidia.com>,
	Mike Kravetz <mike.kravetz@oracle.com>,
	Mike Rapoport <rppt@linux.ibm.com>, Yang Shi <shy828301@gmail.com>,
	"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
	Matthew Wilcox <willy@infradead.org>,
	Vlastimil Babka <vbabka@suse.cz>, Jann Horn <jannh@google.com>,
	Michal Hocko <mhocko@kernel.org>, Nadav Amit <namit@vmware.com>,
	Rik van Riel <riel@surriel.com>, Roman Gushchin <guro@fb.com>,
	Andrea Arcangeli <aarcange@redhat.com>,
	Peter Xu <peterx@redhat.com>, Donald Dutile <ddutile@redhat.com>,
	Christoph Hellwig <hch@lst.de>, Oleg Nesterov <oleg@redhat.com>,
	Jan Kara <jack@suse.cz>, Liang Zhang <zhangliang5@huawei.com>,
	linux-mm@kvack.org
Subject: Re: [PATCH v3 7/9] mm/swapfile: remove stale reuse_swap_page()
Message-ID: <20220202143549.GA24789@lst.de>
References: <20220131162940.210846-1-david@redhat.com> <20220131162940.210846-8-david@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220131162940.210846-8-david@redhat.com>
User-Agent: Mutt/1.5.17 (2007-11-01)
X-Stat-Signature: 8mmbbgsxcdjwjxezu3w7ewqhs553xjbh
X-Rspam-User: nil
Authentication-Results: imf15.hostedemail.com;
	dkim=none;
	dmarc=none;
	spf=none (imf15.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de
X-Rspamd-Server: rspam02
X-Rspamd-Queue-Id: CAC0EA0003
X-HE-Tag: 1643812553-123203
X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4
Sender: owner-linux-mm@kvack.org
Precedence: bulk
X-Loop: owner-majordomo@kvack.org
List-ID: <linux-mm.kvack.org>

On Mon, Jan 31, 2022 at 05:29:37PM +0100, David Hildenbrand wrote:
> All users are gone, let's remove it. We'll let SWP_STABLE_WRITES stick
> around for now, as it might come in handy in the near future.

I don't think leaving a flag that has no user an a completely trivial
place to set it around is a good idea.  This is a classic case of
bitrot.