From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A3BDC433F5 for ; Fri, 4 Feb 2022 17:56:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A22C86B0072; Fri, 4 Feb 2022 12:56:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9AB976B0073; Fri, 4 Feb 2022 12:56:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 84BE66B0074; Fri, 4 Feb 2022 12:56:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.27]) by kanga.kvack.org (Postfix) with ESMTP id 70DD96B0072 for ; Fri, 4 Feb 2022 12:56:44 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id 2A6488036B for ; Fri, 4 Feb 2022 17:56:44 +0000 (UTC) X-FDA: 79105852728.02.7641985 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf20.hostedemail.com (Postfix) with ESMTP id 8BAB51C0002 for ; Fri, 4 Feb 2022 17:56:43 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 9E1ECB83830; Fri, 4 Feb 2022 17:56:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DD5A8C340F3; Fri, 4 Feb 2022 17:56:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1643997401; bh=ljC+ZB7/P+JNIOZfeDuwZx/G/aLrfvXi55fo2JuPMkc=; h=Date:To:From:In-Reply-To:Subject:From; b=iVFRSLVS4zTx/ESaCCgL/qi5VM47ASBWcx6WB5A+9A57VSRnCRlZ+a/Uatm6HXK13 PID+hD6Ad9F6nSQxr1401nbqkAK1ukGa8EzDM1Ojo915tAXuCqK2peTgQiZuYm+iyv GUs+gDPdnDihqJTN/YmknJxQxf9cHU0Cei2OI/2w= Received: by hp1 (sSMTP sendmail emulation); Fri, 04 Feb 2022 09:56:39 -0800 Date: Fri, 04 Feb 2022 09:56:39 -0800 To: vbabka@suse.cz,linux@roeck-us.net,francesco.dolcini@toradex.com,david@redhat.com,bot@kernelci.org,aisheng.dong@nxp.com,chenwandun@huawei.com,akpm@linux-foundation.org,linux-mm@kvack.org,mm-commits@vger.kernel.org,torvalds@linux-foundation.org,akpm@linux-foundation.org From: Andrew Morton In-Reply-To: <20220203204836.88dcebe504f440686cc63a60@linux-foundation.org> Subject: [patch 01/10] Revert "mm/page_isolation: unset migratetype directly for non Buddy page" Message-Id: <20220204175639.DD5A8C340F3@smtp.kernel.org> X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 8BAB51C0002 X-Stat-Signature: jqg5tug16mdf1ndfbben996mihfcp6gj Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=iVFRSLVS; dmarc=none; spf=pass (imf20.hostedemail.com: domain of akpm@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@kernel.org X-Rspam-User: nil X-HE-Tag: 1643997403-434187 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Chen Wandun Subject: Revert "mm/page_isolation: unset migratetype directly for non Buddy page" This reverts commit 721fb891ad0b3956d5c168b2931e3e5e4fb7ca40. commit 721fb891ad0b ("mm/page_isolation: unset migratetype directly for non Buddy page") will result memory that should in buddy disappear by mistake. move_freepages_block move all pages in pageblock instead of pages indicated by input parameter, so if input pages is not in buddy but other pages in pageblock is in buddy, it will result in page out of control. Link: https://lkml.kernel.org/r/20220126024436.13921-1-chenwandun@huawei.com Fixes: 721fb891ad0b ("mm/page_isolation: unset migratetype directly for non Buddy page") Signed-off-by: Chen Wandun Reported-by: "kernelci.org bot" Acked-by: David Hildenbrand Tested-by: Dong Aisheng Tested-by: Francesco Dolcini Acked-by: Vlastimil Babka Tested-by: Guenter Roeck Signed-off-by: Andrew Morton --- mm/page_isolation.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/mm/page_isolation.c~revert-mm-page_isolation-unset-migratetype-directly-for-non-buddy-page +++ a/mm/page_isolation.c @@ -115,7 +115,7 @@ static void unset_migratetype_isolate(st * onlining - just onlined memory won't immediately be considered for * allocation. */ - if (!isolated_page && PageBuddy(page)) { + if (!isolated_page) { nr_pages = move_freepages_block(zone, page, migratetype, NULL); __mod_zone_freepage_state(zone, nr_pages, migratetype); } _