Re: [PATCH RFC v1] tmpfs: support for file creation time

Jean Delvare
2022-02-09T14:27:41Z

On Sat, 5 Feb 2022 15:12:33 +0100, Xavier Roche wrote:
> Various filesystems (including ext4) now support file creation time.
> This patch tentatively adds such support for tmpfs-based filesystems.
>
> The reason is that creation time has been supported on an increasing number
> of filesystems (this information can be retrieved through the statx()
> userland function), and its support for tmpfs would add consistency.
> Example of use includes checking the creation time of an ephemeral status file
> being updated (such as a "work in progress" placeholder), to get two time
> points (starting point and last update).
>
> Note that I am nothing but a new contributor, and while this patch has
> been tested (and userland results checked), the logic might be broken.
>
> Signed-off-by: Xavier Roche <xavier.roche@algolia.com>
> ---
> include/linux/shmem_fs.h | 1 +
> mm/shmem.c | 11 +++++++++++
> 2 files changed, 12 insertions(+)
> (...)

Tested-by: Jean Delvare <jdelvare@suse.de>

Code looks reasonable, but take my review with a grain of salt as this
isn't my area.

Reviewed-by: Jean Delvare <jdelvare@suse.de>

--
Jean Delvare
SUSE L3 Support