From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F36ACC433F5 for ; Mon, 7 Feb 2022 17:39:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 655CA6B0075; Mon, 7 Feb 2022 12:39:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6055D6B0078; Mon, 7 Feb 2022 12:39:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4A5C86B007B; Mon, 7 Feb 2022 12:39:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0117.hostedemail.com [216.40.44.117]) by kanga.kvack.org (Postfix) with ESMTP id 3BD986B0075 for ; Mon, 7 Feb 2022 12:39:14 -0500 (EST) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id F2D0D94FDC for ; Mon, 7 Feb 2022 17:39:13 +0000 (UTC) X-FDA: 79116694986.13.AA814F2 Received: from server.lespinasse.org (server.lespinasse.org [63.205.204.226]) by imf01.hostedemail.com (Postfix) with ESMTP id 88A2740007 for ; Mon, 7 Feb 2022 17:39:13 +0000 (UTC) DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=lespinasse.org; i=@lespinasse.org; q=dns/txt; s=srv-54-ed; t=1644255550; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to : from; bh=N9DuAothrqG9nC60VlENZY3tmDm8PUH3W5VZewotNvk=; b=HuciXOYUEVzuxkHzcPxkWdIaJU+mV9e9A9bKswY6UMA9agbasPfj1deeMZN1cxrjgWVbV ++1806jS1RsPKt5BA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lespinasse.org; i=@lespinasse.org; q=dns/txt; s=srv-54-rsa; t=1644255550; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to : from; bh=N9DuAothrqG9nC60VlENZY3tmDm8PUH3W5VZewotNvk=; b=Ld6HgFYAffThRNAh94Shpci4MPicTr6mHeIQAfUyUbjrkI0zRGACCA72Zf2fN/agDIrDk P5Yxx6pGMvV25JVPFIvQpW18XiYHjE4QNnqXblaRIWKFdKm3Yv2PSZrKdlVgbV8O7GBQ4GF L82GQwFuT/49kxH6BySuJnD9pLncR4nBSM2evayXIVq71rFiYKFlfaBjWH3Ne9yqfWNGM1i Jli87AjSGcRpnGVjiSPNbKgpM7i7rd2OLGsv2ahPBna59MVRGXs40qZbKBW7X3nP4afS7yg 3+rEW0WZ7ij5i01kcz+Czku6wnU76ZyKPldhFqzfDxFSHLp5J5TKkD9T7bZA== Received: by server.lespinasse.org (Postfix, from userid 1000) id E9436160B2E; Mon, 7 Feb 2022 09:39:10 -0800 (PST) Date: Mon, 7 Feb 2022 09:39:10 -0800 From: Michel Lespinasse To: Liam Howlett Cc: Michel Lespinasse , Linux-MM , "linux-kernel@vger.kernel.org" , Andrew Morton , "kernel-team@fb.com" , Laurent Dufour , Jerome Glisse , Peter Zijlstra , Michal Hocko , Vlastimil Babka , Davidlohr Bueso , Matthew Wilcox , Rik van Riel , Paul McKenney , Song Liu , Suren Baghdasaryan , Minchan Kim , Joel Fernandes , David Rientjes , Axel Rasmussen , Andy Lutomirski Subject: Re: [PATCH v2 03/35] mmap locking API: name the return values Message-ID: <20220207173910.GA12302@lespinasse.org> References: <20220128131006.67712-1-michel@lespinasse.org> <20220128131006.67712-4-michel@lespinasse.org> <20220131161737.cclyx2ntil3opted@revolver> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220131161737.cclyx2ntil3opted@revolver> User-Agent: Mutt/1.10.1 (2018-07-13) X-Stat-Signature: 3abtcy79z8x8ss9bfrker53utu68cnze X-Rspam-User: nil Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=lespinasse.org header.s=srv-54-ed header.b=HuciXOYU; dkim=pass header.d=lespinasse.org header.s=srv-54-rsa header.b=Ld6HgFYA; spf=pass (imf01.hostedemail.com: domain of michel@lespinasse.org designates 63.205.204.226 as permitted sender) smtp.mailfrom=michel@lespinasse.org; dmarc=pass (policy=none) header.from=lespinasse.org X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 88A2740007 X-HE-Tag: 1644255553-590683 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jan 31, 2022 at 04:17:43PM +0000, Liam Howlett wrote: > * Michel Lespinasse [220128 08:10]: > > In the mmap locking API, the *_killable() functions return an error > > (or 0 on success), and the *_trylock() functions return a boolean > > (true on success). > > > > Rename the return values "int error" and "bool ok", respectively, > > rather than using "ret" for both cases which I find less readable. > > Would it be better to add function documentation in regards to return > types? I think changing the variables does help, but putting a block > with Return: would work best. That would work, I guess. I'm not sure what it says about our general coding style, that the comment would kinda stick out like a sore thumb compared to the rest of the file, or of similar include files (say, other lock definitions). I don't care very strongly either way. -- Michel "walken" Lespinasse