From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B614BC433EF for ; Thu, 10 Feb 2022 00:15:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 053EA6B0078; Wed, 9 Feb 2022 19:15:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0032A6B007B; Wed, 9 Feb 2022 19:15:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E0D3E6B007D; Wed, 9 Feb 2022 19:15:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0098.hostedemail.com [216.40.44.98]) by kanga.kvack.org (Postfix) with ESMTP id CEBA06B0078 for ; Wed, 9 Feb 2022 19:15:46 -0500 (EST) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 882698249980 for ; Thu, 10 Feb 2022 00:15:46 +0000 (UTC) X-FDA: 79124951892.08.22B16A0 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf24.hostedemail.com (Postfix) with ESMTP id 0AAD4180005 for ; Thu, 10 Feb 2022 00:15:45 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 82470B82357; Thu, 10 Feb 2022 00:15:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2148DC340E7; Thu, 10 Feb 2022 00:15:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1644452143; bh=cVKFqAFG3zPV6J/CjgGaFvwXD5OgrFOgrpo4gsmJUeQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=phEtI6Cvaqd+FZzdeR9eeKnFhkz3QpycG4WecQtRh4cOSyryKW84CyrRkEuJYoSzP 7YhVq8RR4/L9mZF5MtkKHc1gAhQ0WLI4Q4qEVay55YfNF9HYXidUL+FVoolYwu0Yn4 E9ZJHbLMEiXgvuhYDd+rp7aa5gNlE33b5TjOxQiY= Date: Wed, 9 Feb 2022 16:15:42 -0800 From: Andrew Morton To: Alistair Popple Cc: kernel test robot , Linux Memory Management List Subject: Re: [linux-next:master] BUILD REGRESSION 10207e3a840b47b5eae573486a88fb6e29884f77 Message-Id: <20220209161542.b7b831432382b0bd749b3e1f@linux-foundation.org> In-Reply-To: <2400639.Lmb4oXArpK@nvdebian> References: <62040d19.VuzxHXu6YHcwxBQ1%lkp@intel.com> <20220209113446.b8d3261e881e4780dd5f0dc7@linux-foundation.org> <2400639.Lmb4oXArpK@nvdebian> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=phEtI6Cv; dmarc=none; spf=pass (imf24.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org X-Rspamd-Server: rspam03 X-Rspam-User: X-Stat-Signature: di69in1i9ksh5dhsbon8kkmdk31a65zs X-Rspamd-Queue-Id: 0AAD4180005 X-HE-Tag: 1644452145-742190 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 10 Feb 2022 11:09:55 +1100 Alistair Popple wrote: > On Thursday, 10 February 2022 6:34:46 AM AEDT Andrew Morton wrote: > > On Thu, 10 Feb 2022 02:51:05 +0800 kernel test robot wrote: > > > > > tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > > > branch HEAD: 10207e3a840b47b5eae573486a88fb6e29884f77 Add linux-next specific files for 20220209 > > > > > > Error/Warning reports: > > > > > > https://lore.kernel.org/linux-mm/202201251833.Hon4gcuF-lkp@intel.com > > > https://lore.kernel.org/linux-mm/202201290705.x0MS0OCH-lkp@intel.com > > > https://lore.kernel.org/llvm/202202092059.9gegO2oq-lkp@intel.com > > > > > > ... > > > > > > ld: gup.c:(.text+0x1eff): undefined reference to `migrate_vma_pages' > > > ld: gup.c:(.text+0x1f44): undefined reference to `migrate_vma_finalize' > > > > Presumably CONFIG_MIGRATION=y, CONFIG_DEVICE_PRIVATE=n, so these > > functions aren't built. > > > > Methinks Alistair's "mm/gup.c: migrate device coherent pages when > > pinning instead of failing" needs some repair, please. > > Yes, that's the cause. The fix[1] from SeongJae looks correct. Yup. > What's easier > for you - taking that fix or me posting a v3 of my series including that now? > > [1] - https://lore.kernel.org/linux-mm/20220209094158.21941-3-sj@kernel.org/ > Grabbing the little fixup is much simpler and easier, thanks.