From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <owner-linux-mm@kvack.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17])
	by smtp.lore.kernel.org (Postfix) with ESMTP id D72C1C433FE
	for <linux-mm@archiver.kernel.org>; Thu, 10 Feb 2022 15:23:13 +0000 (UTC)
Received: by kanga.kvack.org (Postfix)
	id 65E026B0071; Thu, 10 Feb 2022 10:23:13 -0500 (EST)
Received: by kanga.kvack.org (Postfix, from userid 40)
	id 5E7996B0075; Thu, 10 Feb 2022 10:23:13 -0500 (EST)
X-Delivered-To: int-list-linux-mm@kvack.org
Received: by kanga.kvack.org (Postfix, from userid 63042)
	id 488026B007B; Thu, 10 Feb 2022 10:23:13 -0500 (EST)
X-Delivered-To: linux-mm@kvack.org
Received: from forelay.hostedemail.com (smtprelay0161.hostedemail.com [216.40.44.161])
	by kanga.kvack.org (Postfix) with ESMTP id 3A9476B0071
	for <linux-mm@kvack.org>; Thu, 10 Feb 2022 10:23:13 -0500 (EST)
Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251])
	by forelay04.hostedemail.com (Postfix) with ESMTP id ED64C918BC
	for <linux-mm@kvack.org>; Thu, 10 Feb 2022 15:23:12 +0000 (UTC)
X-FDA: 79127238666.08.DC4D71A
Received: from verein.lst.de (verein.lst.de [213.95.11.211])
	by imf22.hostedemail.com (Postfix) with ESMTP id 5A349C0005
	for <linux-mm@kvack.org>; Thu, 10 Feb 2022 15:23:12 +0000 (UTC)
Received: by verein.lst.de (Postfix, from userid 2407)
	id 4F79068AFE; Thu, 10 Feb 2022 16:23:08 +0100 (CET)
Date: Thu, 10 Feb 2022 16:23:08 +0100
From: Christoph Hellwig <hch@lst.de>
To: Alistair Popple <apopple@nvidia.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Dan Williams <dan.j.williams@intel.com>,
	Christoph Hellwig <hch@lst.de>,
	Felix Kuehling <Felix.Kuehling@amd.com>,
	Alex Deucher <alexander.deucher@amd.com>,
	Christian =?iso-8859-1?Q?K=F6nig?= <christian.koenig@amd.com>,
	"Pan, Xinhui" <Xinhui.Pan@amd.com>, Ben Skeggs <bskeggs@redhat.com>,
	Karol Herbst <kherbst@redhat.com>, Lyude Paul <lyude@redhat.com>,
	Jason Gunthorpe <jgg@ziepe.ca>,
	Logan Gunthorpe <logang@deltatee.com>,
	Ralph Campbell <rcampbell@nvidia.com>, linux-kernel@vger.kernel.org,
	amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	nouveau@lists.freedesktop.org, nvdimm@lists.linux.dev,
	linux-mm@kvack.org
Subject: Re: [PATCH 13/27] mm: move the migrate_vma_* device migration code
 into it's own file
Message-ID: <20220210152308.GA13344@lst.de>
References: <20220210072828.2930359-1-hch@lst.de> <20220210072828.2930359-14-hch@lst.de> <2160837.zdNQNePZV9@nvdebian>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <2160837.zdNQNePZV9@nvdebian>
User-Agent: Mutt/1.5.17 (2007-11-01)
X-Rspamd-Server: rspam11
X-Rspam-User: 
X-Stat-Signature: ghs1jcpd7yjxga7m7k31or66cnjg9t7p
Authentication-Results: imf22.hostedemail.com;
	dkim=none;
	dmarc=none;
	spf=none (imf22.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de
X-Rspamd-Queue-Id: 5A349C0005
X-HE-Tag: 1644506592-649551
Content-Transfer-Encoding: quoted-printable
X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4
Sender: owner-linux-mm@kvack.org
Precedence: bulk
X-Loop: owner-majordomo@kvack.org
List-ID: <linux-mm.kvack.org>

On Thu, Feb 10, 2022 at 09:35:10PM +1100, Alistair Popple wrote:
> I got the following build error:
>=20
> /data/source/linux/mm/migrate_device.c: In function =E2=80=98migrate_vm=
a_collect_pmd=E2=80=99:
> /data/source/linux/mm/migrate_device.c:242:3: error: implicit declarati=
on of function =E2=80=98flush_tlb_range=E2=80=99; did you mean =E2=80=98f=
lush_pmd_tlb_range=E2=80=99? [-Werror=3Dimplicit-function-declaration]
>   242 |   flush_tlb_range(walk->vma, start, end);
>       |   ^~~~~~~~~~~~~~~
>       |   flush_pmd_tlb_range
>=20
> Including asm/tlbflush.h in migrate_device.c fixed it for me.

Yes, the buildbot also complained about this, but somehow in my test
configfs it got pulled in implicitly.