linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] net: dsa: qca8k: fix noderef.cocci warnings
  2022-02-10 12:55 [linux-next:master 2956/4901] drivers/net/dsa/qca8k.c:422:37-43: ERROR: application of sizeof to pointer kernel test robot
@ 2022-02-10 12:46 ` kernel test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2022-02-10 12:46 UTC (permalink / raw)
  To: Ansuel Smith
  Cc: kbuild-all, Linux Memory Management List, Andrew Lunn,
	Vivien Didelot, Florian Fainelli, Vladimir Oltean, Jakub Kicinski,
	netdev, linux-kernel

From: kernel test robot <lkp@intel.com>

drivers/net/dsa/qca8k.c:422:37-43: ERROR: application of sizeof to pointer

 sizeof when applied to a pointer typed expression gives the size of
 the pointer

Generated by: scripts/coccinelle/misc/noderef.cocci

Fixes: 90386223f44e ("net: dsa: qca8k: add support for larger read/write size with mgmt Ethernet")
CC: Ansuel Smith <ansuelsmth@gmail.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   395a61741f7ea29e1f4a0d6e160197fe8e377572
commit: 90386223f44e2a751d7e9e9ac8f78ea33358a891 [2956/4901] net: dsa: qca8k: add support for larger read/write size with mgmt Ethernet
:::::: branch date: 5 hours ago
:::::: commit date: 8 days ago

 qca8k.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/net/dsa/qca8k.c
+++ b/drivers/net/dsa/qca8k.c
@@ -419,7 +419,7 @@ qca8k_regmap_read(void *ctx, uint32_t re
 	u16 r1, r2, page;
 	int ret;
 
-	if (!qca8k_read_eth(priv, reg, val, sizeof(val)))
+	if (!qca8k_read_eth(priv, reg, val, sizeof(*val)))
 		return 0;
 
 	qca8k_split_addr(reg, &r1, &r2, &page);


^ permalink raw reply	[flat|nested] 2+ messages in thread

* [linux-next:master 2956/4901] drivers/net/dsa/qca8k.c:422:37-43: ERROR: application of sizeof to pointer
@ 2022-02-10 12:55 kernel test robot
  2022-02-10 12:46 ` [PATCH] net: dsa: qca8k: fix noderef.cocci warnings kernel test robot
  0 siblings, 1 reply; 2+ messages in thread
From: kernel test robot @ 2022-02-10 12:55 UTC (permalink / raw)
  To: Ansuel Smith; +Cc: kbuild-all, Linux Memory Management List

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   395a61741f7ea29e1f4a0d6e160197fe8e377572
commit: 90386223f44e2a751d7e9e9ac8f78ea33358a891 [2956/4901] net: dsa: qca8k: add support for larger read/write size with mgmt Ethernet
config: xtensa-randconfig-c003-20220208 (https://download.01.org/0day-ci/archive/20220210/202202102036.lklvUIqh-lkp@intel.com/config)
compiler: xtensa-linux-gcc (GCC) 11.2.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


cocci warnings: (new ones prefixed by >>)
>> drivers/net/dsa/qca8k.c:422:37-43: ERROR: application of sizeof to pointer

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-02-10 12:55 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-02-10 12:55 [linux-next:master 2956/4901] drivers/net/dsa/qca8k.c:422:37-43: ERROR: application of sizeof to pointer kernel test robot
2022-02-10 12:46 ` [PATCH] net: dsa: qca8k: fix noderef.cocci warnings kernel test robot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).