From: Oleg Nesterov <oleg@redhat.com>
To: Hugh Dickins <hughd@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Liam Howlett <liam.howlett@oracle.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH mmotm] mempolicy: mbind_range() set_policy() after vma_merge()
Date: Fri, 4 Mar 2022 19:06:37 +0100 [thread overview]
Message-ID: <20220304180636.GD19636@redhat.com> (raw)
In-Reply-To: <319e4db9-64ae-4bca-92f0-ade85d342ff@google.com>
On 03/03, Hugh Dickins wrote:
>
> Just delete that optimization now (though it could be made conditional
> on vma not having a set_policy). Also remove the "next" variable:
> it turned out to be blameless, but also pointless.
>
> Fixes: 3964acd0dbec ("mm: mempolicy: fix mbind_range() && vma_adjust() interaction")
I can't believe I ever looked at this code ;)
Acked-by: Oleg Nesterov <oleg@redhat.com>
offtopic question... can't vma_replace_policy() check vm_ops && vm_ops->set_policy
at the start, before mpol_dup() ?
Oleg.
next prev parent reply other threads:[~2022-03-04 18:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-04 4:36 [PATCH mmotm] mempolicy: mbind_range() set_policy() after vma_merge() Hugh Dickins
2022-03-04 18:06 ` Oleg Nesterov [this message]
2022-03-04 22:33 ` Hugh Dickins
2022-03-04 18:49 ` Liam Howlett
2022-03-04 19:05 ` Liam Howlett
2022-03-04 22:48 ` Hugh Dickins
2022-03-05 2:00 ` Liam Howlett
2022-03-05 2:28 ` Hugh Dickins
2022-03-08 16:05 ` Liam Howlett
2022-03-08 21:32 ` Hugh Dickins
2022-03-09 12:41 ` Vlastimil Babka
2022-03-09 19:10 ` Liam Howlett
2022-03-11 9:33 ` Hugh Dickins
2022-03-11 8:54 ` Hugh Dickins
2022-03-11 12:47 ` Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220304180636.GD19636@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=liam.howlett@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox