From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D493C433EF for ; Thu, 10 Mar 2022 04:18:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 927538D0002; Wed, 9 Mar 2022 23:18:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8D7188D0001; Wed, 9 Mar 2022 23:18:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 79EA98D0002; Wed, 9 Mar 2022 23:18:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.a.hostedemail.com [64.99.140.24]) by kanga.kvack.org (Postfix) with ESMTP id 688F68D0001 for ; Wed, 9 Mar 2022 23:18:19 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id 2DF13808E0 for ; Thu, 10 Mar 2022 04:18:19 +0000 (UTC) X-FDA: 79227169518.01.AF5BFBF Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf30.hostedemail.com (Postfix) with ESMTP id 8B13F8000B for ; Thu, 10 Mar 2022 04:18:18 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 28E62B8245B; Thu, 10 Mar 2022 04:18:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 72070C340E8; Thu, 10 Mar 2022 04:18:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1646885895; bh=6iSEJ3wU3FzUZTv0RzpHgZNG0F9nHjVBdsz7P6dvBMA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=oA40XrOAotQlxjyxfmZX6SWY05dOajakzPs0J6WPXeSEmIxnP48zQfs7IjgUHnSGC VnsuFcTcEa7qlci4CQSScUpiNJomY96FDfGDBwwkod5zGwQUNiRdL4KUlrE2F4f+h+ T4PJImeuf2zRADaazJhmGjz2hnrAHgQCTPgL9yfc= Date: Wed, 9 Mar 2022 20:18:14 -0800 From: Andrew Morton To: Paolo Bonzini Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Michael Ellerman , Dennis Zhou , Tejun Heo , Christoph Lameter , Johannes Weiner , Michal Hocko , Vladimir Davydov , linux-mm@kvack.org, cgroups@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH 3/3] KVM: use vcalloc/__vcalloc for very large allocations Message-Id: <20220309201814.241f39d9ed2f6671c636ece4@linux-foundation.org> In-Reply-To: <20220308105918.615575-4-pbonzini@redhat.com> References: <20220308105918.615575-1-pbonzini@redhat.com> <20220308105918.615575-4-pbonzini@redhat.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 8B13F8000B X-Stat-Signature: hjaxhze178jqbnd6go5sxi19df9wm1f7 Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=oA40XrOA; spf=pass (imf30.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-Rspam-User: X-HE-Tag: 1646885898-14800 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 8 Mar 2022 05:59:18 -0500 Paolo Bonzini wrote: > Allocations whose size is related to the memslot size can be arbitrarily > large. Do not use kvzalloc/kvcalloc, as those are limited to "not crazy" > sizes that fit in 32 bits. Now that it is available, they can use either > vcalloc or __vcalloc, the latter if accounting is required. > > Cc: stable@vger.kernel.org Please fully describe the end user visible runtime effects when proposing a -stable backport. And when not proposing a -stable backport, come to that...