From: Jason Gunthorpe <jgg@ziepe.ca>
To: "Mika Penttilä" <mpenttil@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
apopple@nvidia.com, jhubbard@nvidia.com, rcampbell@nvidia.com,
vbabka@suse.cz
Subject: Re: [PATCH v2] mm/hmm/test: simplify hmm test code: use miscdevice instead of char dev
Date: Thu, 17 Mar 2022 11:15:39 -0300 [thread overview]
Message-ID: <20220317141539.GD64706@ziepe.ca> (raw)
In-Reply-To: <0f53c5ff-1711-861d-9a12-0634d4ab9fca@redhat.com>
On Thu, Mar 17, 2022 at 08:58:52AM +0200, Mika Penttilä wrote:
> @@ -1225,7 +1232,11 @@ static int dmirror_device_init(struct dmirror_device
> *mdevice, int id)
>
> cdev_init(&mdevice->cdevice, &dmirror_fops);
> mdevice->cdevice.owner = THIS_MODULE;
> - ret = cdev_add(&mdevice->cdevice, dev, 1);
> + device_initialize(&mdevice->device);
> + dev_set_name(&mdevice->device, "%s", dmirror_device_names[id]);
> + mdevice->device.devt = dev;
> +
> + ret = cdev_device_add(&mdevice->cdevice, &mdevice->device);
> if (ret)
> return ret;
Right, miscdev isn't that helpful in the end..
Jason
next prev parent reply other threads:[~2022-03-17 14:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-11 3:30 [PATCH v2] mm/hmm/test: simplify hmm test code: use miscdevice instead of char dev mpenttil
2022-03-11 6:15 ` John Hubbard
2022-03-11 6:18 ` Mika Penttilä
2022-03-14 18:24 ` Jason Gunthorpe
2022-03-15 3:22 ` Mika Penttilä
2022-03-15 18:39 ` Jason Gunthorpe
2022-03-17 5:47 ` Mika Penttilä
2022-03-17 6:58 ` Mika Penttilä
2022-03-17 14:15 ` Jason Gunthorpe [this message]
2022-03-18 2:34 ` Mika Penttilä
2022-03-18 2:58 ` John Hubbard
2022-03-18 12:40 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220317141539.GD64706@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=apopple@nvidia.com \
--cc=jhubbard@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mpenttil@redhat.com \
--cc=rcampbell@nvidia.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox