Re: [PATCH 1/2] mm/vmscan: reclaim only affects managed_zones

David Hildenbrand
2022-03-28T07:33:56Z

On 27.03.22 04:41, Wei Yang wrote:
> As mentioned in commit 6aa303defb74 ("mm, vmscan: only allocate and
> reclaim from zones with pages managed by the buddy allocator") , reclaim
> only affects managed_zones.
>
> Let's adjust the code and comment accordingly.
>
> Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
> ---
> mm/vmscan.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index 7ad54b770bb1..89745cf34386 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -1031,7 +1031,7 @@ static bool skip_throttle_noprogress(pg_data_t *pgdat)
> for (i = 0; i < MAX_NR_ZONES; i++) {
> struct zone *zone = pgdat->node_zones + i;
>
> - if (!populated_zone(zone))
> + if (!managed_zone(zone))
> continue;
>
> reclaimable += zone_reclaimable_pages(zone);
> @@ -3912,7 +3912,7 @@ static bool pgdat_balanced(pg_data_t *pgdat, int order, int highest_zoneidx)
> }
>
> /*
> - * If a node has no populated zone within highest_zoneidx, it does not
> + * If a node has no managed zone within highest_zoneidx, it does not
> * need balancing by definition. This can happen if a zone-restricted
> * allocation tries to wake a remote kswapd.
> */

Reviewed-by: David Hildenbrand <david@redhat.com>

--
Thanks,

David / dhildenb