From: Christoph Hellwig <hch@lst.de>
To: Omar Sandoval <osandov@osandov.com>
Cc: linux-mm@kvack.org, kexec@lists.infradead.org,
Andrew Morton <akpm@linux-foundation.org>,
Uladzislau Rezki <urezki@gmail.com>,
Christoph Hellwig <hch@lst.de>, Cliff Wickman <cpw@sgi.com>,
x86@kernel.org, kernel-team@fb.com
Subject: Re: [PATCH] mm/vmalloc: fix spinning drain_vmap_work after reading from /proc/vmcore
Date: Wed, 6 Apr 2022 06:42:44 +0200 [thread overview]
Message-ID: <20220406044244.GA9959@lst.de> (raw)
In-Reply-To: <75014514645de97f2d9e087aa3df0880ea311b77.1649187356.git.osandov@fb.com>
On Tue, Apr 05, 2022 at 12:40:31PM -0700, Omar Sandoval wrote:
> A simple way to "fix" this would be to make set_iounmap_nonlazy() set
> vmap_lazy_nr to lazy_max_pages() instead of lazy_max_pages() + 1. But, I
> think it'd be better to get rid of this hack of clobbering vmap_lazy_nr.
> Instead, this fix makes __copy_oldmem_page() explicitly drain the vmap
> areas itself.
This fixes the bug and the interface also is better than what we had
before. But a vmap/iounmap_eager would seem even better. But hey,
right now it has one caller in always built іn x86 arch code, so maybe
it isn't worth spending more effort on this.
next prev parent reply other threads:[~2022-04-06 4:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-05 19:40 [PATCH] mm/vmalloc: fix spinning drain_vmap_work after reading from /proc/vmcore Omar Sandoval
2022-04-05 20:28 ` Uladzislau Rezki
2022-04-06 4:42 ` Christoph Hellwig [this message]
2022-04-06 9:13 ` Uladzislau Rezki
2022-04-06 9:59 ` Baoquan He
2022-04-06 20:16 ` Omar Sandoval
2022-04-07 2:32 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220406044244.GA9959@lst.de \
--to=hch@lst.de \
--cc=akpm@linux-foundation.org \
--cc=cpw@sgi.com \
--cc=kernel-team@fb.com \
--cc=kexec@lists.infradead.org \
--cc=linux-mm@kvack.org \
--cc=osandov@osandov.com \
--cc=urezki@gmail.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).