From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19A9FC433F5 for ; Sun, 10 Apr 2022 06:26:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 08BB66B0071; Sun, 10 Apr 2022 02:26:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 03BB36B0073; Sun, 10 Apr 2022 02:26:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E458C6B0074; Sun, 10 Apr 2022 02:26:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0220.hostedemail.com [216.40.44.220]) by kanga.kvack.org (Postfix) with ESMTP id D28A66B0071 for ; Sun, 10 Apr 2022 02:26:25 -0400 (EDT) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 7C9F9AA488 for ; Sun, 10 Apr 2022 06:26:25 +0000 (UTC) X-FDA: 79339985130.27.770AE76 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf30.hostedemail.com (Postfix) with ESMTP id C331880004 for ; Sun, 10 Apr 2022 06:26:24 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id E057168AFE; Sun, 10 Apr 2022 08:26:20 +0200 (CEST) Date: Sun, 10 Apr 2022 08:26:20 +0200 From: Christoph Hellwig To: Christoph =?iso-8859-1?Q?B=F6hmwalder?= Cc: Christoph Hellwig , dm-devel@redhat.com, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-um@lists.infradead.org, linux-block@vger.kernel.org, drbd-dev@lists.linbit.com, nbd@other.debian.org, ceph-devel@vger.kernel.org, virtualization@lists.linux-foundation.org, xen-devel@lists.xenproject.org, Jens Axboe , linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, jfs-discussion@lists.sourceforge.net, linux-nilfs@vger.kernel.org, ntfs3@lists.linux.dev, ocfs2-devel@oss.oracle.com, linux-mm@kvack.org, "Martin K . Petersen" , Coly Li Subject: Re: [PATCH 24/27] block: remove QUEUE_FLAG_DISCARD Message-ID: <20220410062620.GA16234@lst.de> References: <20220409045043.23593-1-hch@lst.de> <20220409045043.23593-25-hch@lst.de> <72e9bd34-3380-e305-65f0-a17306f5bd08@linbit.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <72e9bd34-3380-e305-65f0-a17306f5bd08@linbit.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Stat-Signature: qw93euye63hoq5nx4yyzqhn1ehsh4ryf X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: C331880004 Authentication-Results: imf30.hostedemail.com; dkim=none; spf=none (imf30.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de; dmarc=none X-Rspam-User: X-HE-Tag: 1649571984-504983 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Apr 09, 2022 at 10:15:33AM +0200, Christoph B=F6hmwalder wrote: > On 09.04.22 06:50, Christoph Hellwig wrote: >> Just use a non-zero max_discard_sectors as an indicator for discard >> support, similar to what is done for write zeroes. >> >> The only places where needs special attention is the RAID5 driver, >> which must clear discard support for security reasons by default, >> even if the default stacking rules would allow for it. >> >> Signed-off-by: Christoph Hellwig >> Reviewed-by: Martin K. Petersen >> Acked-by: Christoph B=F6hmwalder [b= trfs] > > I think you may have a typo there: my ACK was for drbd, not btrfs. Indeed, sorry.