From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31D3DC433F5 for ; Sun, 10 Apr 2022 17:06:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 44C586B0071; Sun, 10 Apr 2022 13:06:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3FBA86B0073; Sun, 10 Apr 2022 13:06:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 29B6F6B0074; Sun, 10 Apr 2022 13:06:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.a.hostedemail.com [64.99.140.24]) by kanga.kvack.org (Postfix) with ESMTP id 1A9C66B0071 for ; Sun, 10 Apr 2022 13:06:22 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id D36DA20B47 for ; Sun, 10 Apr 2022 17:06:21 +0000 (UTC) X-FDA: 79341597762.19.5AFB349 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by imf26.hostedemail.com (Postfix) with ESMTP id A3CB0140005 for ; Sun, 10 Apr 2022 17:06:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1649610380; x=1681146380; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=Oe0uo85RHYlHvwbBuRSLH6b9IzXe4SR7cGvmloC3CS4=; b=eAoCghZFDkNQg4fKsN0xp+fBSDm4blMccCdfQpsxFJGChf+QjM+7KjIK usz6Zt5qDWSPupaEPwxeCToGKfv85+SNDMkygKQWvgywgxp9y53vMuMhG aDkZ+up6iE3s3B28GGs/EdW8IUkFJwvQB8Jke+Z5wK3Siole59MoaaMU8 htlfnj8ij3Q/b15ce07FrH/IHCJ53eEvpQGG/OofyTyUMc29MKjMSHp59 GWaWJtMNZ9tgCO+wf01YP239xhiXT+Jmgm1gTkI9LGAUhFRh3t58/WxjO 6XSTwtLD6B5YitppVngKIi6DjiCbg9yNrcLAXCUQKmJThkQ62EpjaWaOd Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10313"; a="260831380" X-IronPort-AV: E=Sophos;i="5.90,250,1643702400"; d="scan'208";a="260831380" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Apr 2022 10:06:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,250,1643702400"; d="scan'208";a="659759710" Received: from lkp-server02.sh.intel.com (HELO d3fc50ef50de) ([10.239.97.151]) by orsmga004.jf.intel.com with ESMTP; 10 Apr 2022 10:06:12 -0700 Received: from kbuild by d3fc50ef50de with local (Exim 4.95) (envelope-from ) id 1ndb0t-0000yN-Lb; Sun, 10 Apr 2022 17:06:11 +0000 Date: Mon, 11 Apr 2022 01:06:07 +0800 From: kernel test robot To: Zach O'Keefe , Alex Shi , David Hildenbrand , David Rientjes , Matthew Wilcox , Michal Hocko , Pasha Tatashin , SeongJae Park , Song Liu , Vlastimil Babka , Yang Shi , Zi Yan , linux-mm@kvack.org Cc: kbuild-all@lists.01.org, Andrea Arcangeli , Andrew Morton , Linux Memory Management List , Arnd Bergmann , Axel Rasmussen , Chris Kennelly , Chris Zankel , Helge Deller , Hugh Dickins , Ivan Kokshaysky , "James E.J. Bottomley" , Jens Axboe , "Kirill A. Shutemov" , Matt Turner , Max Filippov , Miaohe Lin , Minchan Kim , Patrick Xia Subject: Re: [PATCH 06/12] mm/khugepaged: remove khugepaged prefix from shared collapse functions Message-ID: <202204110041.MnMCeEi6-lkp@intel.com> References: <20220410135445.3897054-7-zokeefe@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220410135445.3897054-7-zokeefe@google.com> User-Agent: Mutt/1.10.1 (2018-07-13) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=eAoCghZF; spf=none (imf26.hostedemail.com: domain of lkp@intel.com has no SPF policy when checking 192.55.52.120) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com X-Stat-Signature: 6i7ew1eb661zp5i77tpuh5cqhupwgjnt X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: A3CB0140005 X-HE-Tag: 1649610380-978595 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Zach, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on hnaz-mm/master] url: https://github.com/intel-lab-lkp/linux/commits/Zach-O-Keefe/mm-userspace-hugepage-collapse/20220410-215722 base: https://github.com/hnaz/linux-mm master config: arc-allyesconfig (https://download.01.org/0day-ci/archive/20220411/202204110041.MnMCeEi6-lkp@intel.com/config) compiler: arceb-elf-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/18407cfcbdad0f4e11dfe2e40028687fc64093c5 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Zach-O-Keefe/mm-userspace-hugepage-collapse/20220410-215722 git checkout 18407cfcbdad0f4e11dfe2e40028687fc64093c5 # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arc SHELL=/bin/bash If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): mm/khugepaged.c: In function 'find_pmd_or_thp_or_none': mm/khugepaged.c:1019:9: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement] 1019 | pmd_t pmde; | ^~~~~ mm/khugepaged.c: In function 'khugepaged': mm/khugepaged.c:2355:32: error: initialization of 'struct page * (*)(struct collapse_control *, gfp_t, int)' {aka 'struct page * (*)(struct collapse_control *, unsigned int, int)'} from incompatible pointer type 'struct page * (*)(struct collapse_control *, gfp_t)' {aka 'struct page * (*)(struct collapse_control *, unsigned int)'} [-Werror=incompatible-pointer-types] 2355 | .alloc_hpage = &khugepaged_alloc_page, | ^ mm/khugepaged.c:2355:32: note: (near initialization for 'cc.alloc_hpage') mm/khugepaged.c: At top level: mm/khugepaged.c:2469:5: warning: no previous prototype for 'madvise_collapse_errno' [-Wmissing-prototypes] 2469 | int madvise_collapse_errno(enum scan_result r) | ^~~~~~~~~~~~~~~~~~~~~~ mm/khugepaged.c:914:12: warning: 'khugepaged_find_target_node' defined but not used [-Wunused-function] 914 | static int khugepaged_find_target_node(struct collapse_control *cc) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ mm/khugepaged.c: In function 'collapse_file': >> mm/khugepaged.c:863:55: warning: array subscript -2147483648 is below array bounds of 'int[1]' [-Warray-bounds] 863 | if (max_value == cc->node_load[nid]) { | ~~~~~~~~~~~~~^~~~~ mm/khugepaged.c:91:13: note: while referencing 'node_load' 91 | int node_load[MAX_NUMNODES]; | ^~~~~~~~~ mm/khugepaged.c: In function 'collapse_huge_page': >> mm/khugepaged.c:863:55: warning: array subscript -2147483648 is below array bounds of 'int[1]' [-Warray-bounds] 863 | if (max_value == cc->node_load[nid]) { | ~~~~~~~~~~~~~^~~~~ mm/khugepaged.c:91:13: note: while referencing 'node_load' 91 | int node_load[MAX_NUMNODES]; | ^~~~~~~~~ cc1: some warnings being treated as errors vim +863 mm/khugepaged.c b46e756f5e4703 Kirill A. Shutemov 2016-07-26 847 18407cfcbdad0f Zach O'Keefe 2022-04-10 848 static int find_target_node(struct collapse_control *cc) b46e756f5e4703 Kirill A. Shutemov 2016-07-26 849 { b46e756f5e4703 Kirill A. Shutemov 2016-07-26 850 int nid, target_node = 0, max_value = 0; b46e756f5e4703 Kirill A. Shutemov 2016-07-26 851 b46e756f5e4703 Kirill A. Shutemov 2016-07-26 852 /* find first node with max normal pages hit */ b46e756f5e4703 Kirill A. Shutemov 2016-07-26 853 for (nid = 0; nid < MAX_NUMNODES; nid++) b6a99a2eb2cc19 Zach O'Keefe 2022-04-10 854 if (cc->node_load[nid] > max_value) { b6a99a2eb2cc19 Zach O'Keefe 2022-04-10 855 max_value = cc->node_load[nid]; b46e756f5e4703 Kirill A. Shutemov 2016-07-26 856 target_node = nid; b46e756f5e4703 Kirill A. Shutemov 2016-07-26 857 } b46e756f5e4703 Kirill A. Shutemov 2016-07-26 858 b46e756f5e4703 Kirill A. Shutemov 2016-07-26 859 /* do some balance if several nodes have the same hit record */ b6a99a2eb2cc19 Zach O'Keefe 2022-04-10 860 if (target_node <= cc->last_target_node) b6a99a2eb2cc19 Zach O'Keefe 2022-04-10 861 for (nid = cc->last_target_node + 1; nid < MAX_NUMNODES; b6a99a2eb2cc19 Zach O'Keefe 2022-04-10 862 nid++) { b6a99a2eb2cc19 Zach O'Keefe 2022-04-10 @863 if (max_value == cc->node_load[nid]) { b46e756f5e4703 Kirill A. Shutemov 2016-07-26 864 target_node = nid; b46e756f5e4703 Kirill A. Shutemov 2016-07-26 865 break; b46e756f5e4703 Kirill A. Shutemov 2016-07-26 866 } b6a99a2eb2cc19 Zach O'Keefe 2022-04-10 867 } b46e756f5e4703 Kirill A. Shutemov 2016-07-26 868 b6a99a2eb2cc19 Zach O'Keefe 2022-04-10 869 cc->last_target_node = target_node; b46e756f5e4703 Kirill A. Shutemov 2016-07-26 870 return target_node; b46e756f5e4703 Kirill A. Shutemov 2016-07-26 871 } b46e756f5e4703 Kirill A. Shutemov 2016-07-26 872 -- 0-DAY CI Kernel Test Service https://01.org/lkp