From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B20BDC433F5 for ; Wed, 13 Apr 2022 21:27:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 190116B0072; Wed, 13 Apr 2022 17:27:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 13E4D6B0073; Wed, 13 Apr 2022 17:27:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 005646B0074; Wed, 13 Apr 2022 17:27:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0084.hostedemail.com [216.40.44.84]) by kanga.kvack.org (Postfix) with ESMTP id E60066B0072 for ; Wed, 13 Apr 2022 17:27:53 -0400 (EDT) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 972BEAA22B for ; Wed, 13 Apr 2022 21:27:53 +0000 (UTC) X-FDA: 79353143226.27.FA0F140 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf03.hostedemail.com (Postfix) with ESMTP id 122872000C for ; Wed, 13 Apr 2022 21:27:52 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 16CB1B82791; Wed, 13 Apr 2022 21:27:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 64E3CC385A6; Wed, 13 Apr 2022 21:27:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1649885269; bh=FjG2+pX9sQXWdwJMeAX8PPPWjqJFcjuWd0aqHp4WLGg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=sPnv/kKsjBuE1m9S0VgEQlrr7YDHXoHzcjdekSxcuS0Y+jPYJHw8m7oD590PzBAHg 9YB7FAInDU1LFenE05jW8OU8l7TzPWqoje15Zr1f+fzFsU2dwgB0SxGxTtIz/g6uDs GA8emcpTSpdOxICqPFifzDZxGYOXKRtOyNhKAa9w= Date: Wed, 13 Apr 2022 14:27:48 -0700 From: Andrew Morton To: "Alex Xu (Hello71)" Cc: Vlastimil Babka , Daniel Colascione , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Alexey Dobriyan , linux-api@vger.kernel.org Subject: Re: [PATCH] mm/smaps_rollup: return empty file for kthreads instead of ESRCH Message-Id: <20220413142748.a5796e31e567a6205c850ae7@linux-foundation.org> In-Reply-To: <20220413211357.26938-1-alex_y_xu@yahoo.ca> References: <20220413211357.26938-1-alex_y_xu.ref@yahoo.ca> <20220413211357.26938-1-alex_y_xu@yahoo.ca> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: fr6buq1e8bjkh7t4oxp4resizdeo4o8y Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="sPnv/kKs"; spf=pass (imf03.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 122872000C X-HE-Tag: 1649885272-738491 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 13 Apr 2022 17:13:57 -0400 "Alex Xu (Hello71)" wrote: > This restores the behavior prior to 258f669e7e88 ("mm: > /proc/pid/smaps_rollup: convert to single value seq_file"), making it > once again consistent with maps and smaps, and allowing patterns like > awk '$1=="Anonymous:"{x+=$2}END{print x}' /proc/*/smaps_rollup to work. > Searching all Debian packages for "smaps_rollup" did not find any > programs which would be affected by this change. Thanks. 258f669e7e88 was 4 years ago, so I guess a -stable backport isn't really needed. However, we need to be concerned about causing new regressions, and I don't think you've presented enough information for this to be determined. So please provide us with a full description of how the smaps_rollup output will be altered by this patch. Quoting example output would be helpful.