From: Zqiang <qiang1.zhang@intel.com>
To: ryabinin.a.a@gmail.com, dvyukov@google.com, akpm@linux-foundation.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: [PATCH] kasan: Prevent cpu_quarantine corruption when CPU offline and cache shrink occur at same time
Date: Thu, 14 Apr 2022 10:59:25 +0800 [thread overview]
Message-ID: <20220414025925.2423818-1-qiang1.zhang@intel.com> (raw)
The kasan_quarantine_remove_cache() is called in kmem_cache_shrink()/
destroy(), the kasan_quarantine_remove_cache() call is protected by
cpuslock in kmem_cache_destroy(), can ensure serialization with
kasan_cpu_offline(). however the kasan_quarantine_remove_cache() call
is not protected by cpuslock in kmem_cache_shrink(), when CPU going
offline and cache shrink occur at same time, the cpu_quarantine may be
corrupted by interrupt(per_cpu_remove_cache operation). so add
cpu_quarantine offline flags check in per_cpu_remove_cache().
Signed-off-by: Zqiang <qiang1.zhang@intel.com>
---
mm/kasan/quarantine.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/mm/kasan/quarantine.c b/mm/kasan/quarantine.c
index 0e33d30abb8d..51a8192d49cf 100644
--- a/mm/kasan/quarantine.c
+++ b/mm/kasan/quarantine.c
@@ -330,6 +330,8 @@ static void per_cpu_remove_cache(void *arg)
struct cpu_shrink_qlist *sq;
#endif
q = this_cpu_ptr(&cpu_quarantine);
+ if (READ_ONCE(q->offline))
+ return;
#ifndef CONFIG_PREEMPT_RT
qlist_move_cache(q, &to_free, cache);
qlist_free_all(&to_free, cache);
--
2.25.1
next reply other threads:[~2022-04-14 2:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-14 2:59 Zqiang [this message]
2022-04-21 22:07 ` [PATCH] kasan: Prevent cpu_quarantine corruption when CPU offline and cache shrink occur at same time Andrew Morton
2022-04-22 9:27 ` Dmitry Vyukov
2022-04-25 14:25 ` Zhang, Qiang1
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220414025925.2423818-1-qiang1.zhang@intel.com \
--to=qiang1.zhang@intel.com \
--cc=akpm@linux-foundation.org \
--cc=dvyukov@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ryabinin.a.a@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).