From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 780DEC433F5 for ; Tue, 19 Apr 2022 08:15:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EFC9C8D005D; Tue, 19 Apr 2022 04:15:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EAC1F8D0047; Tue, 19 Apr 2022 04:15:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D9B2E8D005D; Tue, 19 Apr 2022 04:15:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.26]) by kanga.kvack.org (Postfix) with ESMTP id CAC728D0047 for ; Tue, 19 Apr 2022 04:15:24 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 9BE7C60E03 for ; Tue, 19 Apr 2022 08:15:24 +0000 (UTC) X-FDA: 79372918968.24.3C4EEBE Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf08.hostedemail.com (Postfix) with ESMTP id 9F4E9160007 for ; Tue, 19 Apr 2022 08:15:22 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id D071868D06; Tue, 19 Apr 2022 10:15:18 +0200 (CEST) Date: Tue, 19 Apr 2022 10:15:17 +0200 From: Christoph Hellwig To: Ming Lei Cc: Christoph Hellwig , Jens Axboe , linux-block@vger.kernel.org, linux-mm@kvack.org, linux-xfs@vger.kernel.org, Changhui Zhong Subject: Re: [PATCH V2] block: avoid io timeout in case of sync polled dio Message-ID: <20220419081517.GA6427@lst.de> References: <20220415034703.2081695-1-ming.lei@redhat.com> <20220415051844.GA22762@lst.de> <20220416054913.GA7405@lst.de> <20220418051234.GA3559@lst.de> <20220419053924.GA31720@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Authentication-Results: imf08.hostedemail.com; dkim=none; spf=none (imf08.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de; dmarc=none X-Stat-Signature: pb5i1kn4gfbctepod1i7wguftyiad88x X-Rspamd-Queue-Id: 9F4E9160007 X-Rspamd-Server: rspam04 X-Rspam-User: X-HE-Tag: 1650356122-493724 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Apr 19, 2022 at 03:47:26PM +0800, Ming Lei wrote: > I agree to remove it because it is legacy poll interface, and very likely > no one use it since the problem to be addressed can easily be exposed by > sync polled dio sanity test or 'blktests block/007'. > > I'd suggest to switch sync polled dio into non-polled silently, just with > logging sort of 'sync polled io is obsolete, please use io_uring for io > polling', or any other idea? We've carefully define RWF_HIPRI to just be a hint. So I don't think logging an error would be all that useful.