From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 734CFC433F5 for ; Fri, 22 Apr 2022 19:55:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0D8E46B0078; Fri, 22 Apr 2022 15:55:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0611D6B007D; Fri, 22 Apr 2022 15:55:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DCFFE6B007E; Fri, 22 Apr 2022 15:55:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.26]) by kanga.kvack.org (Postfix) with ESMTP id CABAC6B0078 for ; Fri, 22 Apr 2022 15:55:47 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id A992A206CD for ; Fri, 22 Apr 2022 19:55:47 +0000 (UTC) X-FDA: 79385570334.19.B5AEE20 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf04.hostedemail.com (Postfix) with ESMTP id B67F54002A for ; Fri, 22 Apr 2022 19:55:44 +0000 (UTC) Received: from pps.filterd (m0098393.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 23MJb8I3016570; Fri, 22 Apr 2022 19:55:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding; s=pp1; bh=uY0Z6msCCH9KzE009HO1twr/mIvovXgZnjZLx+NVgAE=; b=nIIZJAv0fvAwuej9k4W2ANK++bg/JdZ26uocRoaEqXvKEPT47GMarA1yUxWOBgAHTf76 YM85CYilX4g0bxafOndy2KThIvQhpRqYIoe4Kct5/ex7IATlx5vLTbnw1t0MkALatWcs HuLF2FTQBx3ax6GYl4tMhC1n/KVUortCxt9M4BAiAD2qvIuUkSHbIFhBmafYOQcmjcwr mXt6SWSZWnn0hjn4W8Um+H4u2yIsInywh58alLCso7kMCzuHfwjwH/NNqeLVTDl2Cucm YP2gjXd1U3CHcnl58ejez88GdcWjSxOsiGRrIo19qwwVJ260QY+7k0Sk4+CiQ03vW/Fs Qg== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 3fjn0ykhqh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 22 Apr 2022 19:55:45 +0000 Received: from m0098393.ppops.net (m0098393.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 23MJjAEA015282; Fri, 22 Apr 2022 19:55:44 GMT Received: from ppma03ams.nl.ibm.com (62.31.33a9.ip4.static.sl-reverse.com [169.51.49.98]) by mx0a-001b2d01.pphosted.com with ESMTP id 3fjn0ykhq0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 22 Apr 2022 19:55:44 +0000 Received: from pps.filterd (ppma03ams.nl.ibm.com [127.0.0.1]) by ppma03ams.nl.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 23MJhTBF027247; Fri, 22 Apr 2022 19:55:42 GMT Received: from b06cxnps4075.portsmouth.uk.ibm.com (d06relay12.portsmouth.uk.ibm.com [9.149.109.197]) by ppma03ams.nl.ibm.com with ESMTP id 3ffne8st22-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 22 Apr 2022 19:55:42 +0000 Received: from d06av25.portsmouth.uk.ibm.com (d06av25.portsmouth.uk.ibm.com [9.149.105.61]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 23MJtdkQ40305124 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 22 Apr 2022 19:55:39 GMT Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3855711C050; Fri, 22 Apr 2022 19:55:39 +0000 (GMT) Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E883311C052; Fri, 22 Apr 2022 19:55:35 +0000 (GMT) Received: from li-6e1fa1cc-351b-11b2-a85c-b897023bb5f3.ibm.com.com (unknown [9.43.112.230]) by d06av25.portsmouth.uk.ibm.com (Postfix) with ESMTP; Fri, 22 Apr 2022 19:55:35 +0000 (GMT) From: Jagdish Gediya To: linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org Cc: baolin.wang@linux.alibaba.com, dave.hansen@linux.intel.com, ying.huang@intel.com, aneesh.kumar@linux.ibm.com, shy828301@gmail.com, weixugc@google.com, gthelen@google.com, dan.j.williams@intel.com, Jagdish Gediya Subject: [PATCH v3 3/7] drivers/base/node: Add support to write node_states[] via sysfs Date: Sat, 23 Apr 2022 01:25:12 +0530 Message-Id: <20220422195516.10769-4-jvgediya@linux.ibm.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220422195516.10769-1-jvgediya@linux.ibm.com> References: <20220422195516.10769-1-jvgediya@linux.ibm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: yOg7QkFiteOgPwyb7WJin5XJOPO6WZ_O X-Proofpoint-ORIG-GUID: m18RbXrSxa4x2MrQV8mNB9H0Ke2nlc6w X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.858,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-04-22_06,2022-04-22_01,2022-02-23_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=999 bulkscore=0 impostorscore=0 suspectscore=0 mlxscore=0 spamscore=0 phishscore=0 priorityscore=1501 lowpriorityscore=0 adultscore=0 malwarescore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2204220083 X-Stat-Signature: 1ysbs5uky9xgh8zmkyosnzxyrk518sne Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=nIIZJAv0; spf=pass (imf04.hostedemail.com: domain of jvgediya@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=jvgediya@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: B67F54002A X-HE-Tag: 1650657344-315596 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Current /sys/devices/system/node/* interface doesn't support to write node_states[], however write support is needed in case users want to set them manually e.g. when user want to override default N_DEMOTION_TARGETS found by the kernel. Rename existing _NODE_ATTR to _NODE_ATTR_RO and introduce new _NODE_ATTR_RW which can be used for node_states[] which can be written from sysfs. It may be necessary to validate written values and take action based on them in a state specific way so a callback 'write' is introduced in 'struct node_attr'. A new function demotion_targets_write() is added to validate the input nodes for N_DEMOTION_TARGETS which should be subset of N_MEMORY and to build new demotion list based on new nodes. Signed-off-by: Jagdish Gediya --- drivers/base/node.c | 62 +++++++++++++++++++++++++++++++++++---------- 1 file changed, 49 insertions(+), 13 deletions(-) diff --git a/drivers/base/node.c b/drivers/base/node.c index 6eef22e6413e..e03eedbc421b 100644 --- a/drivers/base/node.c +++ b/drivers/base/node.c @@ -20,6 +20,7 @@ #include #include #include +#include static struct bus_type node_subsys = { .name = "node", @@ -1013,6 +1014,7 @@ void unregister_one_node(int nid) struct node_attr { struct device_attribute attr; enum node_states state; + int (*write)(nodemask_t nodes); }; static ssize_t show_node_state(struct device *dev, @@ -1024,23 +1026,57 @@ static ssize_t show_node_state(struct device *dev, nodemask_pr_args(&node_states[na->state])); } -#define _NODE_ATTR(name, state) \ - { __ATTR(name, 0444, show_node_state, NULL), state } +static ssize_t store_node_state(struct device *s, + struct device_attribute *attr, + const char *buf, size_t count) +{ + nodemask_t nodes; + struct node_attr *na = container_of(attr, struct node_attr, attr); + + if (nodelist_parse(buf, nodes)) + return -EINVAL; + + if (na->write) { + if (na->write(nodes)) + return -EINVAL; + } else { + node_states[na->state] = nodes; + } + + return count; +} + +static int demotion_targets_write(nodemask_t nodes) +{ + if (nodes_subset(nodes, node_states[N_MEMORY])) { + node_states[N_DEMOTION_TARGETS] = nodes; + set_migration_target_nodes(); + return 0; + } + + return -EINVAL; +} + +#define _NODE_ATTR_RO(name, state) \ + { __ATTR(name, 0444, show_node_state, NULL), state, NULL } + +#define _NODE_ATTR_RW(name, state, write_fn) \ + { __ATTR(name, 0644, show_node_state, store_node_state), state, write_fn } static struct node_attr node_state_attr[] = { - [N_POSSIBLE] = _NODE_ATTR(possible, N_POSSIBLE), - [N_ONLINE] = _NODE_ATTR(online, N_ONLINE), - [N_NORMAL_MEMORY] = _NODE_ATTR(has_normal_memory, N_NORMAL_MEMORY), + [N_POSSIBLE] = _NODE_ATTR_RO(possible, N_POSSIBLE), + [N_ONLINE] = _NODE_ATTR_RO(online, N_ONLINE), + [N_NORMAL_MEMORY] = _NODE_ATTR_RO(has_normal_memory, N_NORMAL_MEMORY), #ifdef CONFIG_HIGHMEM - [N_HIGH_MEMORY] = _NODE_ATTR(has_high_memory, N_HIGH_MEMORY), + [N_HIGH_MEMORY] = _NODE_ATTR_RO(has_high_memory, N_HIGH_MEMORY), #endif - [N_MEMORY] = _NODE_ATTR(has_memory, N_MEMORY), - [N_CPU] = _NODE_ATTR(has_cpu, N_CPU), - [N_GENERIC_INITIATOR] = _NODE_ATTR(has_generic_initiator, - N_GENERIC_INITIATOR), - [N_DEMOTION_TARGETS] = _NODE_ATTR(demotion_targets, - N_DEMOTION_TARGETS), - + [N_MEMORY] = _NODE_ATTR_RO(has_memory, N_MEMORY), + [N_CPU] = _NODE_ATTR_RO(has_cpu, N_CPU), + [N_GENERIC_INITIATOR] = _NODE_ATTR_RO(has_generic_initiator, + N_GENERIC_INITIATOR), + [N_DEMOTION_TARGETS] = _NODE_ATTR_RW(demotion_targets, + N_DEMOTION_TARGETS, + demotion_targets_write), }; static struct attribute *node_state_attrs[] = { -- 2.35.1