From: David Vernet <void@manifault.com>
To: akpm@linux-foundation.org
Cc: tj@kernel.org, roman.gushchin@linux.dev,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
cgroups@vger.kernel.org, hannes@cmpxchg.org, mhocko@kernel.org,
shakeelb@google.com, kernel-team@fb.com, void@manifault.com
Subject: [PATCH v2 0/5] Fix bugs in memcontroller cgroup tests
Date: Sat, 23 Apr 2022 08:56:15 -0700 [thread overview]
Message-ID: <20220423155619.3669555-1-void@manifault.com> (raw)
tools/testing/selftests/cgroup/test_memcontrol.c contains a set of
testcases which validate expected behavior of the cgroup memory controller.
Roman Gushchin recently sent out a patchset that fixed a few issues in the
test. This patchset continues that effort by fixing a few more issues that
were causing non-deterministic failures in the suite. With this patchset,
I'm unable to reproduce any more errors after running the tests in a
continuous loop for many iterations. Before, I was able to reproduce at
least one of the errors fixed in this patchset with just one or two runs.
Changelog:
v2:
- Fixed the comment headers in test_memcg_min() and test_memcg_low() to
reflect the new ordering of child cgroups in those tests.
- Fixed the comment I added in test_memcg_oom_group_leaf_events() to use /* */
for multiline comments, as is the norm according to the kernel style guide.
- Changed some of the conditional logic in test_memcg_oom_group_leaf_events()
that checks for OOM event counts based on memory_localevents to be more
intuitive.
David Vernet (5):
cgroups: Refactor children cgroups in memcg tests
cgroup: Account for memory_recursiveprot in test_memcg_low()
cgroup: Account for memory_localevents in
test_memcg_oom_group_leaf_events()
cgroup: Removing racy check in test_memcg_sock()
cgroup: Fix racy check in alloc_pagecache_max_30M() helper function
tools/testing/selftests/cgroup/cgroup_util.c | 12 +++
tools/testing/selftests/cgroup/cgroup_util.h | 1 +
.../selftests/cgroup/test_memcontrol.c | 77 ++++++++++++-------
3 files changed, 64 insertions(+), 26 deletions(-)
--
2.30.2
next reply other threads:[~2022-04-23 15:56 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-23 15:56 David Vernet [this message]
2022-04-23 15:56 ` [PATCH v2 1/5] cgroups: Refactor children cgroups in memcg tests David Vernet
2022-04-26 1:56 ` Roman Gushchin
2022-04-23 15:56 ` [PATCH v2 2/5] cgroup: Account for memory_recursiveprot in test_memcg_low() David Vernet
2022-04-27 14:09 ` Michal Koutný
2022-04-29 1:03 ` David Vernet
2022-04-29 9:26 ` Michal Koutný
2022-05-06 16:40 ` David Vernet
2022-05-09 15:09 ` Johannes Weiner
2022-05-10 0:44 ` Andrew Morton
2022-05-10 17:43 ` Michal Koutný
2022-05-11 17:53 ` Johannes Weiner
2022-05-12 17:27 ` Michal Koutný
2022-04-23 15:56 ` [PATCH v2 3/5] cgroup: Account for memory_localevents in test_memcg_oom_group_leaf_events() David Vernet
2022-04-23 15:56 ` [PATCH v2 4/5] cgroup: Removing racy check in test_memcg_sock() David Vernet
2022-04-23 15:56 ` [PATCH v2 5/5] cgroup: Fix racy check in alloc_pagecache_max_30M() helper function David Vernet
2022-05-12 17:04 ` [PATCH v2 0/5] Fix bugs in memcontroller cgroup tests Michal Koutný
2022-05-12 17:30 ` David Vernet
2022-05-12 17:44 ` David Vernet
2022-05-13 17:18 ` [PATCH 0/4] memcontrol selftests fixups Michal Koutný
2022-05-13 17:18 ` [PATCH 1/4] selftests: memcg: Fix compilation Michal Koutný
2022-05-13 17:40 ` David Vernet
2022-05-13 18:53 ` Roman Gushchin
2022-05-13 19:09 ` Roman Gushchin
2022-05-13 17:18 ` [PATCH 2/4] selftests: memcg: Expect no low events in unprotected sibling Michal Koutný
2022-05-13 17:42 ` David Vernet
2022-05-13 18:54 ` Roman Gushchin
2022-05-18 15:54 ` Michal Koutný
2022-05-13 17:18 ` [PATCH 3/4] selftests: memcg: Adjust expected reclaim values of protected cgroups Michal Koutný
2022-05-13 18:52 ` Roman Gushchin
2022-05-13 17:18 ` [PATCH 4/4] selftests: memcg: Remove protection from top level memcg Michal Koutný
2022-05-13 18:59 ` Roman Gushchin
2022-05-18 0:24 ` Andrew Morton
2022-05-18 0:52 ` Roman Gushchin
2022-05-18 15:44 ` Michal Koutný
2022-05-13 19:14 ` David Vernet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220423155619.3669555-1-void@manifault.com \
--to=void@manifault.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=roman.gushchin@linux.dev \
--cc=shakeelb@google.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).