From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9EE5C433F5 for ; Tue, 26 Apr 2022 21:47:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4F44A6B0078; Tue, 26 Apr 2022 17:47:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4A4DE6B007B; Tue, 26 Apr 2022 17:47:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 36D446B007D; Tue, 26 Apr 2022 17:47:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.27]) by kanga.kvack.org (Postfix) with ESMTP id 28B156B0078 for ; Tue, 26 Apr 2022 17:47:30 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id BB335210A9 for ; Tue, 26 Apr 2022 21:47:28 +0000 (UTC) X-FDA: 79400366976.22.1667BEE Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf29.hostedemail.com (Postfix) with ESMTP id 8AFD1120052 for ; Tue, 26 Apr 2022 21:47:25 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3E37D617A6; Tue, 26 Apr 2022 21:47:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 84A94C385A0; Tue, 26 Apr 2022 21:47:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1651009646; bh=OBc49pEpmw94Z3LTNT+1ZEl3AxnNDkvwdkoJ76RsPdE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=C05IRe/EZdNo1P3lkapYohJZ28Lmud+jonrtlMnKahAdMaHFBeZNB1A3N/jslOUf/ fyPOWLMUG+dGAZ4ehAqDJzZnvpVrgcWEDxC2+RHY5F9TDj2bN4B0rYrkO+rsLQm4W1 YRk/QgmV12fSkqH6+BYIsO8U1p5VBRucthLAEqsM= Date: Tue, 26 Apr 2022 14:47:25 -0700 From: Andrew Morton To: Wei Yang Cc: linux-mm@kvack.org Subject: Re: [PATCH 2/3] mm/vmscan: filter empty page_list at the beginning Message-Id: <20220426144725.1ed8a96638b33c38cb961aa9@linux-foundation.org> In-Reply-To: <20220426021743.21007-2-richard.weiyang@gmail.com> References: <20220426021743.21007-1-richard.weiyang@gmail.com> <20220426021743.21007-2-richard.weiyang@gmail.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 8AFD1120052 X-Stat-Signature: dx6j5z35iwi5qw5qpedy7yt6kfr5yura Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="C05IRe/E"; spf=pass (imf29.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-HE-Tag: 1651009645-760758 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 26 Apr 2022 02:17:42 +0000 Wei Yang wrote: > node_page_list would always be !empty on finishing the loop, except > page_list is empty. > > Let's handle empty page_list before doing any real work including > touching PF_MEMALLOC flag. Please see https://lkml.kernel.org/r/20220425111232.23182-3-linmiaohe@huawei.com I'll skip this patch.