From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71C21C433EF for ; Wed, 27 Apr 2022 09:02:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EA88B6B0071; Wed, 27 Apr 2022 05:02:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E58936B0072; Wed, 27 Apr 2022 05:02:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D1FAA6B0073; Wed, 27 Apr 2022 05:02:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.25]) by kanga.kvack.org (Postfix) with ESMTP id BFF976B0071 for ; Wed, 27 Apr 2022 05:02:38 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 8BDE822F3 for ; Wed, 27 Apr 2022 09:02:38 +0000 (UTC) X-FDA: 79402068396.20.40E5672 Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by imf11.hostedemail.com (Postfix) with ESMTP id EE9F14004A for ; Wed, 27 Apr 2022 09:02:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1651050157; x=1682586157; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=UL15N/x/0PaD4yOmTgyMWnbE5WlJbznG7609HmCzlUI=; b=guu5US5fkg6ngmkQsmeblKWoJD7TJWsf5juok8/ez+lzbAVSGsgfT1K7 RJedONKHa1BXtHbW5sj1o+nBeebkC9RAlXW9GXlRjyp3PP0x/TnZWxeia l6to4WJaOiIUcNog0LRUjyrQ6yETWV09unDBwztmvf+fZApaRbagWmHaE t6IPyojPxGONYYjM5ybUy5iTlsGeZO5ezN3VJk8PAwQN0UjPLFHsIWzEs Qn3Ren6sojXFd5Bm85XaA6lO5dKNgTdreO6TUnTdfu+xvNbOnPUbk7Zjv 2N/VGWMy/xTPO33Lr2AxST+NoBgHaM6VDIm8L/JNQ2lHvQQfRc5HtdwrK Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10329"; a="326358455" X-IronPort-AV: E=Sophos;i="5.90,292,1643702400"; d="scan'208";a="326358455" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Apr 2022 02:02:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,292,1643702400"; d="scan'208";a="513590185" Received: from lkp-server01.sh.intel.com (HELO 5056e131ad90) ([10.239.97.150]) by orsmga003.jf.intel.com with ESMTP; 27 Apr 2022 02:02:34 -0700 Received: from kbuild by 5056e131ad90 with local (Exim 4.95) (envelope-from ) id 1njdZC-0004XB-0o; Wed, 27 Apr 2022 09:02:34 +0000 Date: Wed, 27 Apr 2022 17:01:54 +0800 From: kernel test robot To: Xu Yu , linux-mm@kvack.org Cc: kbuild-all@lists.01.org, akpm@linux-foundation.org, naoya.horiguchi@nec.com, shy828301@gmail.com Subject: Re: [PATCH 2/2] mm/huge_memory: do not overkill when splitting huge_zero_page Message-ID: <202204271636.UqHlxRwk-lkp@intel.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: wnc3qkqx3nokqt3e4zr89mpfgm4cs1ff Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=guu5US5f; spf=none (imf11.hostedemail.com: domain of lkp@intel.com has no SPF policy when checking 134.134.136.31) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: EE9F14004A X-HE-Tag: 1651050154-845736 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Xu, Thank you for the patch! Yet something to improve: [auto build test ERROR on hnaz-mm/master] url: https://github.com/intel-lab-lkp/linux/commits/Xu-Yu/mm-memory-failure-rework-fix-on-huge_zero_page-splitting/20220427-141253 base: https://github.com/hnaz/linux-mm master config: s390-randconfig-r044-20220425 (https://download.01.org/0day-ci/archive/20220427/202204271636.UqHlxRwk-lkp@intel.com/config) compiler: s390-linux-gcc (GCC) 11.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/988ec6e274e00e5706be7590a4a39427fbe856b1 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Xu-Yu/mm-memory-failure-rework-fix-on-huge_zero_page-splitting/20220427-141253 git checkout 988ec6e274e00e5706be7590a4a39427fbe856b1 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=s390 SHELL=/bin/bash If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): In file included from include/linux/bits.h:22, from include/linux/ratelimit_types.h:5, from include/linux/printk.h:10, from include/asm-generic/bug.h:22, from arch/s390/include/asm/bug.h:68, from include/linux/bug.h:5, from include/linux/mmdebug.h:5, from include/linux/mm.h:6, from mm/huge_memory.c:8: mm/huge_memory.c: In function 'split_huge_page_to_list': >> include/linux/build_bug.h:30:33: error: void value not ignored as it ought to be 30 | #define BUILD_BUG_ON_INVALID(e) ((void)(sizeof((__force long)(e)))) | ^ include/linux/mmdebug.h:81:43: note: in expansion of macro 'BUILD_BUG_ON_INVALID' 81 | #define VM_WARN_ON_ONCE_PAGE(cond, page) BUILD_BUG_ON_INVALID(cond) | ^~~~~~~~~~~~~~~~~~~~ mm/huge_memory.c:2553:13: note: in expansion of macro 'VM_WARN_ON_ONCE_PAGE' 2553 | if (VM_WARN_ON_ONCE_PAGE(is_huge_zero_page(head), head)) | ^~~~~~~~~~~~~~~~~~~~ vim +30 include/linux/build_bug.h 527edbc18a70e74 Masahiro Yamada 2019-01-03 18 527edbc18a70e74 Masahiro Yamada 2019-01-03 19 /* Force a compilation error if a constant expression is not a power of 2 */ 527edbc18a70e74 Masahiro Yamada 2019-01-03 20 #define __BUILD_BUG_ON_NOT_POWER_OF_2(n) \ 527edbc18a70e74 Masahiro Yamada 2019-01-03 21 BUILD_BUG_ON(((n) & ((n) - 1)) != 0) 527edbc18a70e74 Masahiro Yamada 2019-01-03 22 #define BUILD_BUG_ON_NOT_POWER_OF_2(n) \ 527edbc18a70e74 Masahiro Yamada 2019-01-03 23 BUILD_BUG_ON((n) == 0 || (((n) & ((n) - 1)) != 0)) bc6245e5efd70c4 Ian Abbott 2017-07-10 24 bc6245e5efd70c4 Ian Abbott 2017-07-10 25 /* bc6245e5efd70c4 Ian Abbott 2017-07-10 26 * BUILD_BUG_ON_INVALID() permits the compiler to check the validity of the bc6245e5efd70c4 Ian Abbott 2017-07-10 27 * expression but avoids the generation of any code, even if that expression bc6245e5efd70c4 Ian Abbott 2017-07-10 28 * has side-effects. bc6245e5efd70c4 Ian Abbott 2017-07-10 29 */ bc6245e5efd70c4 Ian Abbott 2017-07-10 @30 #define BUILD_BUG_ON_INVALID(e) ((void)(sizeof((__force long)(e)))) bc6245e5efd70c4 Ian Abbott 2017-07-10 31 -- 0-DAY CI Kernel Test Service https://01.org/lkp