From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CC3DC433EF for ; Wed, 27 Apr 2022 12:18:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B0A606B0073; Wed, 27 Apr 2022 08:18:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AB9CD6B0078; Wed, 27 Apr 2022 08:18:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 981106B0080; Wed, 27 Apr 2022 08:18:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.27]) by kanga.kvack.org (Postfix) with ESMTP id 8630F6B0073 for ; Wed, 27 Apr 2022 08:18:30 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 58E3C283E1 for ; Wed, 27 Apr 2022 12:18:30 +0000 (UTC) X-FDA: 79402561980.07.1368D30 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by imf16.hostedemail.com (Postfix) with ESMTP id B34AF180050 for ; Wed, 27 Apr 2022 12:18:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1651061909; x=1682597909; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=U1KrAkavk/Tr6dLOtxSQIS3x9A2FmpeLGm4giGjTM2o=; b=DpH3MxBhP53odlKPT0r2LuO1hH+kdGs9CKZMoIL9sNKKagZR7C8ocwrq QJmDCcFmFA24jB1w8r9c9rl2cGhi/62jfv4CVsI88P/na4KcCerXbOjPi DfWJVnCbM7TwoRtLHVjiD/1vD9jwG2US1jomwoIpl9tUhqQY/GdsC2LJP qSRZJmiBw6GOnVj5MN4Pu+fpRzU3acNg0hXTiv0qjFs63wGlmXQyMTsvi 6gMqwYDklgZw6OPDDTnYXaeAqabfniEJshvDFanUryXlGXBFg54Dzqzsb Pc0CViX8Xrxxge4WuD7s7YjoG9y5BFHAR0AnQ2O+t8NlyL8yxAT4IxHGd A==; X-IronPort-AV: E=McAfee;i="6400,9594,10329"; a="328852681" X-IronPort-AV: E=Sophos;i="5.90,292,1643702400"; d="scan'208";a="328852681" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Apr 2022 05:18:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,292,1643702400"; d="scan'208";a="876392050" Received: from lkp-server01.sh.intel.com (HELO 5056e131ad90) ([10.239.97.150]) by fmsmga005.fm.intel.com with ESMTP; 27 Apr 2022 05:18:24 -0700 Received: from kbuild by 5056e131ad90 with local (Exim 4.95) (envelope-from ) id 1njgci-0004eE-9P; Wed, 27 Apr 2022 12:18:24 +0000 Date: Wed, 27 Apr 2022 20:18:16 +0800 From: kernel test robot To: cgel.zte@gmail.com, glider@google.com, elver@google.com, akpm@linux-foundation.org Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org, dvyukov@google.com, kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, xu xin , Zeal Robot Subject: Re: [PATCH] mm/kfence: fix a potential NULL pointer dereference Message-ID: <202204272015.3JRd9BKR-lkp@intel.com> References: <20220427071100.3844081-1-xu.xin16@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220427071100.3844081-1-xu.xin16@zte.com.cn> X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: B34AF180050 X-Stat-Signature: a7i4pr6uo4wx3zr79acbhi481gseurr7 Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=DpH3MxBh; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf16.hostedemail.com: domain of lkp@intel.com has no SPF policy when checking 134.134.136.100) smtp.mailfrom=lkp@intel.com X-Rspam-User: X-HE-Tag: 1651061905-689967 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi, Thank you for the patch! Yet something to improve: [auto build test ERROR on hnaz-mm/master] url: https://github.com/intel-lab-lkp/linux/commits/cgel-zte-gmail-com/mm-kfence-fix-a-potential-NULL-pointer-dereference/20220427-151258 base: https://github.com/hnaz/linux-mm master config: x86_64-randconfig-a014 (https://download.01.org/0day-ci/archive/20220427/202204272015.3JRd9BKR-lkp@intel.com/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 1cddcfdc3c683b393df1a5c9063252eb60e52818) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/920e9e639493bc72bee803c763f09760e3acd063 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review cgel-zte-gmail-com/mm-kfence-fix-a-potential-NULL-pointer-dereference/20220427-151258 git checkout 920e9e639493bc72bee803c763f09760e3acd063 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): >> mm/kfence/core.c:1067:23: error: use of undeclared identifier 'addr' kfence_guarded_free(addr, meta, false); ^ mm/kfence/core.c:1075:23: warning: incompatible pointer to integer conversion passing 'void *' to parameter of type 'unsigned long' [-Wint-conversion] kfence_report_error(addr, false, NULL, NULL, KFENCE_ERROR_INVALID); ^~~~ mm/kfence/kfence.h:129:40: note: passing argument to parameter 'address' here void kfence_report_error(unsigned long address, bool is_write, struct pt_regs *regs, ^ 1 warning and 1 error generated. vim +/addr +1067 mm/kfence/core.c 0ce20dd840897b1 Alexander Potapenko 2021-02-25 1050 0ce20dd840897b1 Alexander Potapenko 2021-02-25 1051 920e9e639493bc7 xu xin 2022-04-27 1052 /* Require: meta is not NULL*/ 920e9e639493bc7 xu xin 2022-04-27 1053 static __always_inline void __try_free_kfence_meta(struct kfence_metadata *meta) 920e9e639493bc7 xu xin 2022-04-27 1054 { 8f0b36497303487 Muchun Song 2022-04-01 1055 #ifdef CONFIG_MEMCG 8f0b36497303487 Muchun Song 2022-04-01 1056 KFENCE_WARN_ON(meta->objcg); 8f0b36497303487 Muchun Song 2022-04-01 1057 #endif 0ce20dd840897b1 Alexander Potapenko 2021-02-25 1058 /* 0ce20dd840897b1 Alexander Potapenko 2021-02-25 1059 * If the objects of the cache are SLAB_TYPESAFE_BY_RCU, defer freeing 0ce20dd840897b1 Alexander Potapenko 2021-02-25 1060 * the object, as the object page may be recycled for other-typed 0ce20dd840897b1 Alexander Potapenko 2021-02-25 1061 * objects once it has been freed. meta->cache may be NULL if the cache 0ce20dd840897b1 Alexander Potapenko 2021-02-25 1062 * was destroyed. 0ce20dd840897b1 Alexander Potapenko 2021-02-25 1063 */ 0ce20dd840897b1 Alexander Potapenko 2021-02-25 1064 if (unlikely(meta->cache && (meta->cache->flags & SLAB_TYPESAFE_BY_RCU))) 0ce20dd840897b1 Alexander Potapenko 2021-02-25 1065 call_rcu(&meta->rcu_head, rcu_guarded_free); 0ce20dd840897b1 Alexander Potapenko 2021-02-25 1066 else 0ce20dd840897b1 Alexander Potapenko 2021-02-25 @1067 kfence_guarded_free(addr, meta, false); 0ce20dd840897b1 Alexander Potapenko 2021-02-25 1068 } 0ce20dd840897b1 Alexander Potapenko 2021-02-25 1069 -- 0-DAY CI Kernel Test Service https://01.org/lkp