From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E845C433F5 for ; Wed, 27 Apr 2022 12:29:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 77A936B0071; Wed, 27 Apr 2022 08:29:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 72AE56B0072; Wed, 27 Apr 2022 08:29:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5CAD46B0073; Wed, 27 Apr 2022 08:29:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.28]) by kanga.kvack.org (Postfix) with ESMTP id 4ED196B0071 for ; Wed, 27 Apr 2022 08:29:29 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 16346256B1 for ; Wed, 27 Apr 2022 12:29:29 +0000 (UTC) X-FDA: 79402589658.16.A342E9B Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by imf06.hostedemail.com (Postfix) with ESMTP id B7DBB180056 for ; Wed, 27 Apr 2022 12:29:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1651062568; x=1682598568; h=date:from:to:cc:subject:message-id:mime-version; bh=cioCVOTttubaoq5HOn+8Y30dVodEj0KAlKAoealdiBk=; b=jWL59MdEbsctsebCggu2S/9eECGHbU5ehEtb2CcAaXOyPzGBzJFtMXt6 Pb2bdxSmi/MIBo7ChlLzS+YktAq7wcKI0IyZtr7BRfkKum2P3pPXk+Pe1 sT3tdgzX6qgcegxsC7MNTFW9XrRWx9M6jNXsBXGr4j4TGJ4IHo22+TebZ n6+9Wly2/ha7UJgr8i6Y5FFWfIhv+F79EX0K2MH//EMKvT4+D1+ZbwEbE K3tzm9Jm1ZuVTgrcW4MSkgZAwusWL7lAEBDWWdy6Z/Kh/Mbxe8yAzo8lG c4kMP0ErnjKogyp8H7mGxDIC5DSTLOCdc7bRwk12Hq0LQJE2tVG+M7Itc g==; X-IronPort-AV: E=McAfee;i="6400,9594,10329"; a="291061635" X-IronPort-AV: E=Sophos;i="5.90,292,1643702400"; d="scan'208";a="291061635" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Apr 2022 05:29:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,293,1643702400"; d="scan'208";a="617487556" Received: from lkp-server01.sh.intel.com (HELO 5056e131ad90) ([10.239.97.150]) by fmsmga008.fm.intel.com with ESMTP; 27 Apr 2022 05:29:25 -0700 Received: from kbuild by 5056e131ad90 with local (Exim 4.95) (envelope-from ) id 1njgnM-0004eU-JQ; Wed, 27 Apr 2022 12:29:24 +0000 Date: Wed, 27 Apr 2022 20:28:34 +0800 From: kernel test robot To: Nava kishore Manne Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org, Linux Memory Management List , Moritz Fischer Subject: [linux-next:master 4831/7265] drivers/fpga/zynq-fpga.c:246:14: warning: result of comparison of constant 170 with expression of type 'const char' is always false Message-ID: <202204272019.5oBcDYmF-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=jWL59MdE; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf06.hostedemail.com: domain of lkp@intel.com has no SPF policy when checking 192.55.52.88) smtp.mailfrom=lkp@intel.com X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: B7DBB180056 X-Rspam-User: X-Stat-Signature: suwbxf3bjgwobr54ao3toonisrp4aaro X-HE-Tag: 1651062566-982197 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: f02ac5c95dfd45d2f50ecc68d79177de326c668c commit: ada14a023a641107da1ada546e1d345ca3dc78a5 [4831/7265] fpga: zynq: Fix incorrect variable type config: mips-randconfig-r011-20220427 (https://download.01.org/0day-ci/archive/20220427/202204272019.5oBcDYmF-lkp@intel.com/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 1cddcfdc3c683b393df1a5c9063252eb60e52818) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install mips cross compiling tool for clang build # apt-get install binutils-mips-linux-gnu # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=ada14a023a641107da1ada546e1d345ca3dc78a5 git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git git fetch --no-tags linux-next master git checkout ada14a023a641107da1ada546e1d345ca3dc78a5 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=mips SHELL=/bin/bash drivers/fpga/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): >> drivers/fpga/zynq-fpga.c:246:14: warning: result of comparison of constant 170 with expression of type 'const char' is always false [-Wtautological-constant-out-of-range-compare] buf[3] == 0xaa) ~~~~~~ ^ ~~~~ drivers/fpga/zynq-fpga.c:245:50: warning: result of comparison of constant 153 with expression of type 'const char' is always false [-Wtautological-constant-out-of-range-compare] if (buf[0] == 0x66 && buf[1] == 0x55 && buf[2] == 0x99 && ~~~~~~ ^ ~~~~ 2 warnings generated. vim +246 drivers/fpga/zynq-fpga.c 37784706bf9e3b Moritz Fischer 2015-10-16 237 b496df86ac1bbe Jason Gunthorpe 2017-02-01 238 /* Sanity check the proposed bitstream. It must start with the sync word in b496df86ac1bbe Jason Gunthorpe 2017-02-01 239 * the correct byte order, and be dword aligned. The input is a Xilinx .bin b496df86ac1bbe Jason Gunthorpe 2017-02-01 240 * file with every 32 bit quantity swapped. b496df86ac1bbe Jason Gunthorpe 2017-02-01 241 */ ada14a023a6411 Nava kishore Manne 2022-04-21 242 static bool zynq_fpga_has_sync(const char *buf, size_t count) b496df86ac1bbe Jason Gunthorpe 2017-02-01 243 { b496df86ac1bbe Jason Gunthorpe 2017-02-01 244 for (; count >= 4; buf += 4, count -= 4) b496df86ac1bbe Jason Gunthorpe 2017-02-01 245 if (buf[0] == 0x66 && buf[1] == 0x55 && buf[2] == 0x99 && b496df86ac1bbe Jason Gunthorpe 2017-02-01 @246 buf[3] == 0xaa) b496df86ac1bbe Jason Gunthorpe 2017-02-01 247 return true; b496df86ac1bbe Jason Gunthorpe 2017-02-01 248 return false; b496df86ac1bbe Jason Gunthorpe 2017-02-01 249 } b496df86ac1bbe Jason Gunthorpe 2017-02-01 250 :::::: The code at line 246 was first introduced by commit :::::: b496df86ac1bbe393a55ddbfed35d46e74ef9767 fpga zynq: Check the bitstream for validity :::::: TO: Jason Gunthorpe :::::: CC: Greg Kroah-Hartman -- 0-DAY CI Kernel Test Service https://01.org/lkp