From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01D80C433F5 for ; Wed, 27 Apr 2022 22:46:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 675E36B007B; Wed, 27 Apr 2022 18:46:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 625776B007D; Wed, 27 Apr 2022 18:46:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4C8116B007E; Wed, 27 Apr 2022 18:46:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.a.hostedemail.com [64.99.140.24]) by kanga.kvack.org (Postfix) with ESMTP id 3E7376B007B for ; Wed, 27 Apr 2022 18:46:24 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id C65E8214A5 for ; Wed, 27 Apr 2022 22:46:23 +0000 (UTC) X-FDA: 79404144246.21.9E424D0 Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) by imf22.hostedemail.com (Postfix) with ESMTP id 2FADCC0040 for ; Wed, 27 Apr 2022 22:46:22 +0000 (UTC) Received: by mail-ej1-f45.google.com with SMTP id k23so6157040ejd.3 for ; Wed, 27 Apr 2022 15:46:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hDNmZdaTEeDFa+SYiy2FhMpx+6VvsSpHDLR10ll6ANk=; b=UMzpsSwwPouW1UdBJS7hpyHQxIRy9nsYXCcr9W+7hljC2F5PSqtNm+jQpv/doXqgu3 HHNb11Aqbv0E91en3I4gFKU/Ii3fTqFvtEZBSNF5NiNzxy7j5SmPrYkyEuZJEcgk+vHR ZBYuesRRia/y2TI4iP0yu4jutPxojq52zbsFu2RdahZURM8L2tUCeQzAxKnM83oJ703S XUBGD5Uv6V3JfnkZAjpopKPf+H6oN1OCemBpy3EBanwiEmr7AqU8d74HMf1j0Q6bg1NO TqQ6GfwQPXaSRTzatjK+ukk+PboYm1k7ZbL+p3l8tZoxaVsNYsQRJdofW2p1p6w8K24i 05qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hDNmZdaTEeDFa+SYiy2FhMpx+6VvsSpHDLR10ll6ANk=; b=WWG9oHGgpkvjxSaJOh685ux0bWgU8BywDpryStvWx4mqxluX+Dbwf1HKB3lwePI7zL ILl4kuWv5VoWikRmhb7iMIlWehKu4HExHxkI7pBjU8GNOtHrczGHmRFoprvSizdBkwK4 Fe1P9BJFCDAMY9RKT5jwGlqTwv02EwrvYiMP9sawbWotecyK1yZb5sDkgysuD6BHiVOn snTdnVqEwbhW/BAXstyGE0qCPJ+AkadBOwhG9MegcG3F6ZWa4vRX6a0DzdLsf9u3ySTB NlFmbDgA24QrmxhOgxOL0FHWW/4Nfxay7P3Rg9JfYLjuWQUf6ZaEXuSzgKgv3Ai83I6g 6jZQ== X-Gm-Message-State: AOAM533xHb//6Vi8p/h0RMLWAhM+ao2lTPrFnwAiW+23UvvHWDkXHh/N dTmIaDfQo2OEuPFufFWybRMnENjNSRo= X-Google-Smtp-Source: ABdhPJzH9KUeoZKiyyoLsMaGQe7aDUU5HjyOsWUmyNUcWFoDHmiTTlqcnelDOlnc1Dy+Vj4QInKYZw== X-Received: by 2002:a17:907:d24:b0:6f3:7c4f:f710 with SMTP id gn36-20020a1709070d2400b006f37c4ff710mr21160019ejc.6.1651099581835; Wed, 27 Apr 2022 15:46:21 -0700 (PDT) Received: from nlaptop.localdomain (ptr-dtfv0poj8u7zblqwbt6.18120a2.ip6.access.telenet.be. [2a02:1811:cc83:eef0:f2b6:6987:9238:41ca]) by smtp.gmail.com with ESMTPSA id o14-20020a170906774e00b006d5b915f27dsm7351657ejn.169.2022.04.27.15.46.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Apr 2022 15:46:21 -0700 (PDT) From: Niels Dossche To: Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Mina Almasry , Niels Dossche Subject: [PATCH 1/2] mm: mremap: fix sign for EFAULT error return value Date: Thu, 28 Apr 2022 00:44:38 +0200 Message-Id: <20220427224439.23828-2-dossche.niels@gmail.com> X-Mailer: git-send-email 2.35.2 In-Reply-To: <20220427224439.23828-1-dossche.niels@gmail.com> References: <20220427224439.23828-1-dossche.niels@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Stat-Signature: n75gm5wcurnxyz7yjuqfh5w6o8cfcu8e X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 2FADCC0040 X-Rspam-User: Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=UMzpsSww; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf22.hostedemail.com: domain of dossche.niels@gmail.com designates 209.85.218.45 as permitted sender) smtp.mailfrom=dossche.niels@gmail.com X-HE-Tag: 1651099582-42451 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The mremap syscall is supposed to return a pointer to the new virtual memory area on success, and a negative value of the error code in case of failure. Currently, EFAULT is returned when the VMA is not found, instead of -EFAULT. The users of this syscall will therefore believe the syscall succeeded in case the VMA didn't exist, as it returns a pointer to address 0xe (0xe being the value of EFAULT). Fix the sign of the error value. Fixes: 550a7d60bd5e ("mm, hugepages: add mremap() support for hugepage backed vma") Signed-off-by: Niels Dossche --- mm/mremap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/mremap.c b/mm/mremap.c index 303d3290b938..0b93fac76851 100644 --- a/mm/mremap.c +++ b/mm/mremap.c @@ -947,7 +947,7 @@ SYSCALL_DEFINE5(mremap, unsigned long, addr, unsigned long, old_len, return -EINTR; vma = vma_lookup(mm, addr); if (!vma) { - ret = EFAULT; + ret = -EFAULT; goto out; } -- 2.35.2