From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17BCDC433F5 for ; Mon, 2 May 2022 19:16:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 50AFF6B0072; Mon, 2 May 2022 15:16:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 492D96B0073; Mon, 2 May 2022 15:16:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 35A3F6B0074; Mon, 2 May 2022 15:16:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.28]) by kanga.kvack.org (Postfix) with ESMTP id 1EB706B0072 for ; Mon, 2 May 2022 15:16:04 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id D69A160F9B for ; Mon, 2 May 2022 19:16:03 +0000 (UTC) X-FDA: 79421758206.17.367581B Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by imf04.hostedemail.com (Postfix) with ESMTP id 8EB904008B for ; Mon, 2 May 2022 19:15:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1651518963; x=1683054963; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=/U2kyEhyWhIKt8R+Ejy5LPzrlcI6LU4mrgzqXc7j0I0=; b=ByuN7Z1LD2HuV4tUCda+vpU51o575xN9/U125i88ZJb6yEHQrERr0acx kzbGxzGcxaYMbMAAWECHzvaPwoUZdXCsxV2KHw7T78ib6o85PMG9HE14E Z2VN0c8Xo0TssQIKgepCC2A7m40nhvI6mf2sQMtIEWEXAEnef339GXdSz Xp5uIyn5bz9xfE6EuKWGzUpmSbzWCltaxSFoMzD3oJ0YNW11lJxixfoJS ucqAIgbletqvqKv+RYOav1LwHWXrF2UDGJKa8qMJjofMSO3EH74ZJ05vc TyKjj7F9JGIRJWE2zLWLq15ogwwGvDsFMSpOebh/RN76l3wq39MmST2BO Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10335"; a="266895778" X-IronPort-AV: E=Sophos;i="5.91,193,1647327600"; d="scan'208";a="266895778" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 May 2022 12:16:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,193,1647327600"; d="scan'208";a="598764299" Received: from lkp-server01.sh.intel.com (HELO 5056e131ad90) ([10.239.97.150]) by orsmga001.jf.intel.com with ESMTP; 02 May 2022 12:15:59 -0700 Received: from kbuild by 5056e131ad90 with local (Exim 4.95) (envelope-from ) id 1nlbWZ-0009nn-1w; Mon, 02 May 2022 19:15:59 +0000 Date: Tue, 3 May 2022 03:15:11 +0800 From: kernel test robot To: Minchan Kim , Andrew Morton Cc: kbuild-all@lists.01.org, Linux Memory Management List , LKML , John Hubbard , John Dias , Minchan Kim Subject: Re: [PATCH] mm: fix is_pinnable_page against on cma page Message-ID: <202205030306.in794Jr3-lkp@intel.com> References: <20220502173558.2510641-1-minchan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220502173558.2510641-1-minchan@kernel.org> X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 8EB904008B Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=ByuN7Z1L; spf=none (imf04.hostedemail.com: domain of lkp@intel.com has no SPF policy when checking 134.134.136.24) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com X-Rspam-User: X-Stat-Signature: 6zui6mz6cuz53yxrramupim7ddg1iaa5 X-HE-Tag: 1651518956-44588 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Minchan, I love your patch! Yet something to improve: [auto build test ERROR on hnaz-mm/master] url: https://github.com/intel-lab-lkp/linux/commits/Minchan-Kim/mm-fix-is_pinnable_page-against-on-cma-page/20220503-013733 base: https://github.com/hnaz/linux-mm master config: nios2-defconfig (https://download.01.org/0day-ci/archive/20220503/202205030306.in794Jr3-lkp@intel.com/config) compiler: nios2-linux-gcc (GCC) 11.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/1b8636710c31d44310f1d344e337c207562b851d git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Minchan-Kim/mm-fix-is_pinnable_page-against-on-cma-page/20220503-013733 git checkout 1b8636710c31d44310f1d344e337c207562b851d # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=nios2 prepare If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): In file included from include/linux/pid_namespace.h:7, from include/linux/ptrace.h:10, from arch/nios2/kernel/asm-offsets.c:9: include/linux/mm.h: In function 'is_pinnable_page': >> include/linux/mm.h:1630:54: error: 'MIGRATE_CMA' undeclared (first use in this function); did you mean 'MIGRATE_SYNC'? 1630 | return !(is_zone_movable_page(page) || mt == MIGRATE_CMA || | ^~~~~~~~~~~ | MIGRATE_SYNC include/linux/mm.h:1630:54: note: each undeclared identifier is reported only once for each function it appears in >> include/linux/mm.h:1631:23: error: 'MIGRATE_ISOLATE' undeclared (first use in this function); did you mean 'MIGRATE_MOVABLE'? 1631 | mt == MIGRATE_ISOLATE || is_zero_pfn(page_to_pfn(page))); | ^~~~~~~~~~~~~~~ | MIGRATE_MOVABLE make[2]: *** [scripts/Makefile.build:122: arch/nios2/kernel/asm-offsets.s] Error 1 make[2]: Target '__build' not remade because of errors. make[1]: *** [Makefile:1283: prepare0] Error 2 make[1]: Target 'prepare' not remade because of errors. make: *** [Makefile:226: __sub-make] Error 2 make: Target 'prepare' not remade because of errors. vim +1630 include/linux/mm.h 1623 1624 /* MIGRATE_CMA and ZONE_MOVABLE do not allow pin pages */ 1625 #ifdef CONFIG_MIGRATION 1626 static inline bool is_pinnable_page(struct page *page) 1627 { 1628 int mt = get_pageblock_migratetype(page); 1629 > 1630 return !(is_zone_movable_page(page) || mt == MIGRATE_CMA || > 1631 mt == MIGRATE_ISOLATE || is_zero_pfn(page_to_pfn(page))); 1632 } 1633 #else 1634 static inline bool is_pinnable_page(struct page *page) 1635 { 1636 return true; 1637 } 1638 #endif 1639 -- 0-DAY CI Kernel Test Service https://01.org/lkp