From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@lists.01.org, Carl Huang <quic_cjhuang@quicinc.com>
Cc: lkp@intel.com, kbuild-all@lists.01.org,
Linux Memory Management List <linux-mm@kvack.org>,
Kalle Valo <quic_kvalo@quicinc.com>
Subject: [linux-next:master 408/8237] drivers/net/wireless/ath/ath11k/wow.c:712 ath11k_wow_op_resume() warn: inconsistent returns '&ar->conf_mutex'.
Date: Wed, 4 May 2022 11:46:27 +0300 [thread overview]
Message-ID: <202205032236.kofEquX3-lkp@intel.com> (raw)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 44a2f39e611ac0bc1f17c288a583d7f2e5684aa7
commit: 90bf5c8d0f7ecddf96fc1cd9434af4e157b51970 [408/8237] ath11k: purge rx pktlog when entering WoW
config: i386-randconfig-m021-20220502 (https://download.01.org/0day-ci/archive/20220503/202205032236.kofEquX3-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.2.0-20) 11.2.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/net/wireless/ath/ath11k/wow.c:712 ath11k_wow_op_resume() warn: inconsistent returns '&ar->conf_mutex'.
vim +712 drivers/net/wireless/ath/ath11k/wow.c
ba9177fcef21fa Carl Huang 2022-03-14 653 int ath11k_wow_op_resume(struct ieee80211_hw *hw)
ba9177fcef21fa Carl Huang 2022-03-14 654 {
ba9177fcef21fa Carl Huang 2022-03-14 655 struct ath11k *ar = hw->priv;
ba9177fcef21fa Carl Huang 2022-03-14 656 int ret;
ba9177fcef21fa Carl Huang 2022-03-14 657
ba9177fcef21fa Carl Huang 2022-03-14 658 mutex_lock(&ar->conf_mutex);
ba9177fcef21fa Carl Huang 2022-03-14 659
ba9177fcef21fa Carl Huang 2022-03-14 660 ret = ath11k_hif_resume(ar->ab);
ba9177fcef21fa Carl Huang 2022-03-14 661 if (ret) {
ba9177fcef21fa Carl Huang 2022-03-14 662 ath11k_warn(ar->ab, "failed to resume hif: %d\n", ret);
ba9177fcef21fa Carl Huang 2022-03-14 663 goto exit;
ba9177fcef21fa Carl Huang 2022-03-14 664 }
ba9177fcef21fa Carl Huang 2022-03-14 665
ba9177fcef21fa Carl Huang 2022-03-14 666 ath11k_hif_ce_irq_enable(ar->ab);
ba9177fcef21fa Carl Huang 2022-03-14 667 ath11k_hif_irq_enable(ar->ab);
ba9177fcef21fa Carl Huang 2022-03-14 668
90bf5c8d0f7ecd Carl Huang 2022-03-14 669 ret = ath11k_dp_rx_pktlog_start(ar->ab);
90bf5c8d0f7ecd Carl Huang 2022-03-14 670 if (ret) {
90bf5c8d0f7ecd Carl Huang 2022-03-14 671 ath11k_warn(ar->ab, "failed to start rx pktlog from wow: %d\n", ret);
90bf5c8d0f7ecd Carl Huang 2022-03-14 672 return ret;
goto exit;
90bf5c8d0f7ecd Carl Huang 2022-03-14 673 }
90bf5c8d0f7ecd Carl Huang 2022-03-14 674
ba9177fcef21fa Carl Huang 2022-03-14 675 ret = ath11k_wow_wakeup(ar->ab);
fec4b898f369a9 Carl Huang 2022-03-14 676 if (ret) {
ba9177fcef21fa Carl Huang 2022-03-14 677 ath11k_warn(ar->ab, "failed to wakeup from wow: %d\n", ret);
fec4b898f369a9 Carl Huang 2022-03-14 678 goto exit;
fec4b898f369a9 Carl Huang 2022-03-14 679 }
fec4b898f369a9 Carl Huang 2022-03-14 680
fec4b898f369a9 Carl Huang 2022-03-14 681 ret = ath11k_wow_nlo_cleanup(ar);
fec4b898f369a9 Carl Huang 2022-03-14 682 if (ret) {
fec4b898f369a9 Carl Huang 2022-03-14 683 ath11k_warn(ar->ab, "failed to cleanup nlo: %d\n", ret);
fec4b898f369a9 Carl Huang 2022-03-14 684 goto exit;
fec4b898f369a9 Carl Huang 2022-03-14 685 }
ba9177fcef21fa Carl Huang 2022-03-14 686
c417b247ba0421 Carl Huang 2022-03-14 687 ret = ath11k_wow_clear_hw_filter(ar);
c417b247ba0421 Carl Huang 2022-03-14 688 if (ret) {
c417b247ba0421 Carl Huang 2022-03-14 689 ath11k_warn(ar->ab, "failed to clear hw filter: %d\n", ret);
c417b247ba0421 Carl Huang 2022-03-14 690 goto exit;
c417b247ba0421 Carl Huang 2022-03-14 691 }
c417b247ba0421 Carl Huang 2022-03-14 692
ba9177fcef21fa Carl Huang 2022-03-14 693 exit:
ba9177fcef21fa Carl Huang 2022-03-14 694 if (ret) {
ba9177fcef21fa Carl Huang 2022-03-14 695 switch (ar->state) {
ba9177fcef21fa Carl Huang 2022-03-14 696 case ATH11K_STATE_ON:
ba9177fcef21fa Carl Huang 2022-03-14 697 ar->state = ATH11K_STATE_RESTARTING;
ba9177fcef21fa Carl Huang 2022-03-14 698 ret = 1;
ba9177fcef21fa Carl Huang 2022-03-14 699 break;
ba9177fcef21fa Carl Huang 2022-03-14 700 case ATH11K_STATE_OFF:
ba9177fcef21fa Carl Huang 2022-03-14 701 case ATH11K_STATE_RESTARTING:
ba9177fcef21fa Carl Huang 2022-03-14 702 case ATH11K_STATE_RESTARTED:
ba9177fcef21fa Carl Huang 2022-03-14 703 case ATH11K_STATE_WEDGED:
ba9177fcef21fa Carl Huang 2022-03-14 704 ath11k_warn(ar->ab, "encountered unexpected device state %d on resume, cannot recover\n",
ba9177fcef21fa Carl Huang 2022-03-14 705 ar->state);
ba9177fcef21fa Carl Huang 2022-03-14 706 ret = -EIO;
ba9177fcef21fa Carl Huang 2022-03-14 707 break;
ba9177fcef21fa Carl Huang 2022-03-14 708 }
ba9177fcef21fa Carl Huang 2022-03-14 709 }
ba9177fcef21fa Carl Huang 2022-03-14 710
ba9177fcef21fa Carl Huang 2022-03-14 711 mutex_unlock(&ar->conf_mutex);
ba9177fcef21fa Carl Huang 2022-03-14 @712 return ret;
ba9177fcef21fa Carl Huang 2022-03-14 713 }
--
0-DAY CI Kernel Test Service
https://01.org/lkp
next reply other threads:[~2022-05-04 8:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-04 8:46 Dan Carpenter [this message]
2022-05-04 16:23 ` [linux-next:master 408/8237] drivers/net/wireless/ath/ath11k/wow.c:712 ath11k_wow_op_resume() warn: inconsistent returns '&ar->conf_mutex' Kalle Valo
2022-05-05 1:29 ` Carl Huang
2022-05-05 5:58 ` Dan Carpenter
2022-05-06 8:46 ` Kalle Valo
2022-05-06 9:58 ` [kbuild-all] " Chen, Rong A
2022-05-06 10:24 ` Dan Carpenter
2022-05-06 13:25 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202205032236.kofEquX3-lkp@intel.com \
--to=dan.carpenter@oracle.com \
--cc=kbuild-all@lists.01.org \
--cc=kbuild@lists.01.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=quic_cjhuang@quicinc.com \
--cc=quic_kvalo@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).