From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19E2EC433F5 for ; Thu, 5 May 2022 10:58:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 953F96B0071; Thu, 5 May 2022 06:58:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8FD2D6B0078; Thu, 5 May 2022 06:58:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7C5F96B0075; Thu, 5 May 2022 06:58:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 65DB06B0071 for ; Thu, 5 May 2022 06:58:24 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 4202B61921 for ; Thu, 5 May 2022 10:58:24 +0000 (UTC) X-FDA: 79431390528.01.1F43A22 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by imf29.hostedemail.com (Postfix) with ESMTP id E47F01200A1 for ; Thu, 5 May 2022 10:58:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1651748303; x=1683284303; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=KT3yvpmhOyvkbJzjKsPlMjHAaN9ntkeKdCV6ZerT2h4=; b=MKWigWjwY2Wvk+S7VW6tl7e3ulfPceHhnZae4OpHKP7/68Dv529ljyCG FIKWWpdB3SZ7y8ak7HlPo1Xbb9tjfRyUYkW98oFIAZnrdlV/QlN9q6Juf IZz1sxv7/A586h9jJ6we7ynLkpQa/oGipSb3oGBNr1Kciw/nimXu1jw6k gBNvNcuEHhptSX4YuHZgTYkqp6jdpCTrMBs0onNY3c/Y//sgB9euPi0KD besT+dMHKHZH9+AMCKl3gvtfaPpN7qDAjEyINaIvDKtAzV5N3ImIttpUM o8eB9c9Lxih5zsrPpZVXg3yDtYhlNBmDPv+StrEhSyQ+quh91ymn7CAGW A==; X-IronPort-AV: E=McAfee;i="6400,9594,10337"; a="265668487" X-IronPort-AV: E=Sophos;i="5.91,201,1647327600"; d="scan'208";a="265668487" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 May 2022 03:58:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,201,1647327600"; d="scan'208";a="708893373" Received: from lkp-server01.sh.intel.com (HELO 5056e131ad90) ([10.239.97.150]) by fmsmga001.fm.intel.com with ESMTP; 05 May 2022 03:58:19 -0700 Received: from kbuild by 5056e131ad90 with local (Exim 4.95) (envelope-from ) id 1nmZBb-000CJm-1N; Thu, 05 May 2022 10:58:19 +0000 Date: Thu, 5 May 2022 18:57:42 +0800 From: kernel test robot To: Hyeonggon Yoo <42.hyeyoo@gmail.com>, Alexander Potapenko , Marco Elver , Dmitry Vyukov , Andrew Morton Cc: kbuild-all@lists.01.org, Linux Memory Management List , linux-kernel@vger.kernel.org, Hyeonggon Yoo <42.hyeyoo@gmail.com> Subject: Re: [PATCH] mm/kfence: reset PG_slab and memcg_data before freeing __kfence_pool Message-ID: <202205051852.M26PcwNj-lkp@intel.com> References: <20220505070105.1835745-1-42.hyeyoo@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220505070105.1835745-1-42.hyeyoo@gmail.com> Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=MKWigWjw; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf29.hostedemail.com: domain of lkp@intel.com has no SPF policy when checking 192.55.52.93) smtp.mailfrom=lkp@intel.com X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: E47F01200A1 X-Rspam-User: X-Stat-Signature: dkf6hgj4epfzriq6pjeniyh8tbcnyihd X-HE-Tag: 1651748297-99875 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Hyeonggon, Thank you for the patch! Yet something to improve: [auto build test ERROR on hnaz-mm/master] url: https://github.com/intel-lab-lkp/linux/commits/Hyeonggon-Yoo/mm-kfence-reset-PG_slab-and-memcg_data-before-freeing-__kfence_pool/20220505-150237 base: https://github.com/hnaz/linux-mm master config: s390-randconfig-r044-20220505 (https://download.01.org/0day-ci/archive/20220505/202205051852.M26PcwNj-lkp@intel.com/config) compiler: s390-linux-gcc (GCC) 11.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/ad166fcbcd464ea0251165580e1ea0152531fe56 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Hyeonggon-Yoo/mm-kfence-reset-PG_slab-and-memcg_data-before-freeing-__kfence_pool/20220505-150237 git checkout ad166fcbcd464ea0251165580e1ea0152531fe56 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=s390 SHELL=/bin/bash mm/kfence/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): mm/kfence/core.c: In function 'kfence_init_pool_early': >> mm/kfence/core.c:634:21: error: 'struct page' has no member named 'memcg_data' 634 | page->memcg_data = 0; | ^~ vim +634 mm/kfence/core.c 610 611 static bool __init kfence_init_pool_early(void) 612 { 613 unsigned long addr; 614 615 if (!__kfence_pool) 616 return false; 617 618 addr = kfence_init_pool(); 619 620 if (!addr) 621 return true; 622 623 /* 624 * Only release unprotected pages, and do not try to go back and change 625 * page attributes due to risk of failing to do so as well. If changing 626 * page attributes for some pages fails, it is very likely that it also 627 * fails for the first page, and therefore expect addr==__kfence_pool in 628 * most failure cases. 629 */ 630 for (char *p = (char *)addr; p < __kfence_pool + KFENCE_POOL_SIZE; p += PAGE_SIZE) { 631 struct page *page; 632 633 page = virt_to_page(p); > 634 page->memcg_data = 0; 635 __ClearPageSlab(page); 636 } 637 memblock_free_late(__pa(addr), KFENCE_POOL_SIZE - (addr - (unsigned long)__kfence_pool)); 638 __kfence_pool = NULL; 639 return false; 640 } 641 -- 0-DAY CI Kernel Test Service https://01.org/lkp