From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2266AC433F5 for ; Fri, 6 May 2022 08:55:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 61A606B0074; Fri, 6 May 2022 04:55:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5CA306B0075; Fri, 6 May 2022 04:55:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4B8866B0078; Fri, 6 May 2022 04:55:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 3E4536B0074 for ; Fri, 6 May 2022 04:55:43 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 062F7896 for ; Fri, 6 May 2022 08:55:43 +0000 (UTC) X-FDA: 79434710166.17.0E70D06 Received: from out0.migadu.com (out0.migadu.com [94.23.1.103]) by imf14.hostedemail.com (Postfix) with ESMTP id A9827100033 for ; Fri, 6 May 2022 08:55:40 +0000 (UTC) Date: Fri, 6 May 2022 17:55:32 +0900 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1651827340; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LAUW0vSgJcAftQD8gzfhfsgS87APTTZohbWrvT0aZGc=; b=vVcRx4Q1/7tV3fymAg7pwv6CQFfOuPeqMnQmsIIHvuQDmG7uoL/PbuWU0rymoy71tXjBwF xasqAW8jXWf/GIaRFr6Bf9I5rTVe3knV+N9GpPxP6JeP9KmDz3nKxKBVBf8l2v6D5OoSvt H2z7/mRKiBC4umQOwN+sItNdk+/wNxM= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Naoya Horiguchi To: zhenwei pi Cc: akpm@linux-foundation.org, naoya.horiguchi@nec.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Wu Fengguang Subject: Re: [PATCH 1/4] mm/memory-failure.c: move clear_hwpoisoned_pages Message-ID: <20220506085532.GA1356094@u2004> References: <20220429142206.294714-1-pizhenwei@bytedance.com> <20220429142206.294714-2-pizhenwei@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220429142206.294714-2-pizhenwei@bytedance.com> X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=vVcRx4Q1; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf14.hostedemail.com: domain of naoya.horiguchi@linux.dev designates 94.23.1.103 as permitted sender) smtp.mailfrom=naoya.horiguchi@linux.dev X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: A9827100033 X-Rspam-User: X-Stat-Signature: a9np6rdkoqwuqaokdkz8ga5znrtrxjzf X-HE-Tag: 1651827340-918961 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Apr 29, 2022 at 10:22:03PM +0800, zhenwei pi wrote: > clear_hwpoisoned_pages() clears HWPoison flag and decreases the number > of poisoned pages, this actually works as part of memory failure. > > Move this function from sparse.c to memory-failure.c, finally there > is no CONFIG_MEMORY_FAILURE in sparse.c. > > Cc: Wu Fengguang > Signed-off-by: zhenwei pi > --- > mm/internal.h | 11 +++++++++++ > mm/memory-failure.c | 21 +++++++++++++++++++++ > mm/sparse.c | 27 --------------------------- > 3 files changed, 32 insertions(+), 27 deletions(-) > > diff --git a/mm/internal.h b/mm/internal.h > index cf16280ce132..e8add8df4e0f 100644 > --- a/mm/internal.h > +++ b/mm/internal.h > @@ -758,4 +758,15 @@ struct folio *try_grab_folio(struct page *page, int refs, unsigned int flags); > > DECLARE_PER_CPU(struct per_cpu_nodestat, boot_nodestats); > > +/* > + * mm/memory-failure.c > + */ > +#ifdef CONFIG_MEMORY_FAILURE > +void clear_hwpoisoned_pages(struct page *memmap, int nr_pages); > +#else > +static inline void clear_hwpoisoned_pages(struct page *memmap, int nr_pages) > +{ > +} > +#endif This code may be put near the definitions of hwpoison_filter* in mm/internal.h because they are also called from mm/memory-failure. Otherwise, looks good to me. Acked-by: Naoya Horiguchi