[linux-next:master 7193/9759] arch/sh/kernel/crash_dump.c:23:36: sparse: sparse: incorrect type in argument 1 (different address spaces)

[linux-next:master 7193/9759] arch/sh/kernel/crash_dump.c:23:36: sparse: sparse: incorrect type in argument 1 (different address spaces)

[kernel test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   38a288f5941ef03752887ad86f2d85442358c99a
commit: 5d8de293c224896a4da99763fce4f9794308caf4 [7193/9759] vmcore: convert copy_oldmem_page() to take an iov_iter
config: sh-randconfig-s032-20220506 (https://download.01.org/0day-ci/archive/20220506/202205062129.oGoY3bdy-lkp@intel.com/config)
compiler: sh4-linux-gcc (GCC) 11.3.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.4-dirty
        # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=5d8de293c224896a4da99763fce4f9794308caf4
        git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
        git fetch --no-tags linux-next master
        git checkout 5d8de293c224896a4da99763fce4f9794308caf4
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=sh SHELL=/bin/bash arch/sh/kernel/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)
>> arch/sh/kernel/crash_dump.c:23:36: sparse: sparse: incorrect type in argument 1 (different address spaces) @@     expected void const *addr @@     got void [noderef] __iomem * @@
   arch/sh/kernel/crash_dump.c:23:36: sparse:     expected void const *addr
   arch/sh/kernel/crash_dump.c:23:36: sparse:     got void [noderef] __iomem *

vim +23 arch/sh/kernel/crash_dump.c

    13	
    14	ssize_t copy_oldmem_page(struct iov_iter *iter, unsigned long pfn,
    15				 size_t csize, unsigned long offset)
    16	{
    17		void  __iomem *vaddr;
    18	
    19		if (!csize)
    20			return 0;
    21	
    22		vaddr = ioremap(pfn << PAGE_SHIFT, PAGE_SIZE);
  > 23		csize = copy_to_iter(vaddr + offset, csize, iter);

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

Re: [linux-next:master 7193/9759] arch/sh/kernel/crash_dump.c:23:36: sparse: sparse: incorrect type in argument 1 (different address spaces)

[Matthew Wilcox]

On Fri, May 06, 2022 at 09:59:14PM +0800, kernel test robot wrote:
> sparse warnings: (new ones prefixed by >>)
> >> arch/sh/kernel/crash_dump.c:23:36: sparse: sparse: incorrect type in argument 1 (different address spaces) @@     expected void const *addr @@     got void [noderef] __iomem * @@
>    arch/sh/kernel/crash_dump.c:23:36: sparse:     expected void const *addr
>    arch/sh/kernel/crash_dump.c:23:36: sparse:     got void [noderef] __iomem *

This code already produces a warning; the patch simply moves the warning
around.  INVALID, WONTFIX, please stop reporting it.

Re: [linux-next:master 7193/9759] arch/sh/kernel/crash_dump.c:23:36: sparse: sparse: incorrect type in argument 1 (different address spaces)

[Baoquan He]

On 05/06/22 at 09:59pm, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head:   38a288f5941ef03752887ad86f2d85442358c99a
> commit: 5d8de293c224896a4da99763fce4f9794308caf4 [7193/9759] vmcore: convert copy_oldmem_page() to take an iov_iter

This is an existed warning, not related to the code change in patch
"vmcore: convert copy_oldmem_page() to take an iov_iter". I have queued
a patch to fix the warning, will send it to SuperH maintainer.

> config: sh-randconfig-s032-20220506 (https://download.01.org/0day-ci/archive/20220506/202205062129.oGoY3bdy-lkp@intel.com/config)
> compiler: sh4-linux-gcc (GCC) 11.3.0
> reproduce:
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # apt-get install sparse
>         # sparse version: v0.6.4-dirty
>         # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=5d8de293c224896a4da99763fce4f9794308caf4
>         git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
>         git fetch --no-tags linux-next master
>         git checkout 5d8de293c224896a4da99763fce4f9794308caf4
>         # save the config file
>         mkdir build_dir && cp config build_dir/.config
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=sh SHELL=/bin/bash arch/sh/kernel/
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> 
> 
> sparse warnings: (new ones prefixed by >>)
> >> arch/sh/kernel/crash_dump.c:23:36: sparse: sparse: incorrect type in argument 1 (different address spaces) @@     expected void const *addr @@     got void [noderef] __iomem * @@
>    arch/sh/kernel/crash_dump.c:23:36: sparse:     expected void const *addr
>    arch/sh/kernel/crash_dump.c:23:36: sparse:     got void [noderef] __iomem *
> 
> vim +23 arch/sh/kernel/crash_dump.c
> 
>     13	
>     14	ssize_t copy_oldmem_page(struct iov_iter *iter, unsigned long pfn,
>     15				 size_t csize, unsigned long offset)
>     16	{
>     17		void  __iomem *vaddr;
>     18	
>     19		if (!csize)
>     20			return 0;
>     21	
>     22		vaddr = ioremap(pfn << PAGE_SHIFT, PAGE_SIZE);
>   > 23		csize = copy_to_iter(vaddr + offset, csize, iter);
> 
> -- 
> 0-DAY CI Kernel Test Service
> https://01.org/lkp
>