From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A95CC433EF for ; Fri, 6 May 2022 20:38:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0929E6B0071; Fri, 6 May 2022 16:38:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 01A236B0073; Fri, 6 May 2022 16:38:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DD5DA6B0074; Fri, 6 May 2022 16:38:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0206.hostedemail.com [216.40.44.206]) by kanga.kvack.org (Postfix) with ESMTP id C85506B0071 for ; Fri, 6 May 2022 16:38:28 -0400 (EDT) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 6BCAA18525555 for ; Fri, 6 May 2022 20:38:28 +0000 (UTC) X-FDA: 79436481096.25.38F3C65 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by imf14.hostedemail.com (Postfix) with ESMTP id A843E100009 for ; Fri, 6 May 2022 20:38:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1651869504; x=1683405504; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=2b+dWfxndlwKVu8r56BjaXCpV9WofllYiBZQXaA0tCY=; b=dM+Wb+UHKHXZpTrWAk72wd6y3tCuXt47vbVqOiONgOyL3hnr1gXUjdF1 v/NhmeRVeix8Y9dQ9mBbbf6HlnSuKNfWec9YTqmMkvLsV1mfVABhfj181 jyuv2swtFoiWxa5VZBXv7i+j3gZ2a9k1VBxVWp2w5Fwd2k3FhI2fsthnE CXW0w79CK9OigmCZ1H7kdZBTsbUx8tn7+Hf0roJDQo3tJRceJkkIzCCjf kHH8iZUdg6tkPuhaXrjcEBzilxhZFPYuGS1Z80pCN74P0ig+JmX+cjfio iZ6urj2yp0ET/ZxIgn+A0N2uYkexI+pZWyBgPxclGSy1MLP+nFYnGRRkj g==; X-IronPort-AV: E=McAfee;i="6400,9594,10339"; a="331558484" X-IronPort-AV: E=Sophos;i="5.91,205,1647327600"; d="scan'208";a="331558484" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 May 2022 13:38:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,205,1647327600"; d="scan'208";a="564011788" Received: from lkp-server01.sh.intel.com (HELO 5056e131ad90) ([10.239.97.150]) by orsmga007.jf.intel.com with ESMTP; 06 May 2022 13:38:18 -0700 Received: from kbuild by 5056e131ad90 with local (Exim 4.95) (envelope-from ) id 1nn4iQ-000DsG-38; Fri, 06 May 2022 20:38:18 +0000 Date: Sat, 7 May 2022 04:38:04 +0800 From: kernel test robot To: Vasily Averin , Shakeel Butt , Steven Rostedt , Ingo Molnar Cc: kbuild-all@lists.01.org, kernel@openvz.org, linux-kernel@vger.kernel.org, Roman Gushchin , Vlastimil Babka , Michal Hocko , cgroups@vger.kernel.org, Andrew Morton , Linux Memory Management List , Dennis Zhou , Tejun Heo , Christoph Lameter Subject: Re: [PATCH] percpu: improve percpu_alloc_percpu event trace Message-ID: <202205070420.aAhuqpYk-lkp@intel.com> References: <8d627f02-183f-c4e7-7c15-77b2b438536b@openvz.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8d627f02-183f-c4e7-7c15-77b2b438536b@openvz.org> X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: A843E100009 X-Stat-Signature: 87a9dg5bsdm1nawucf86qufiytp6krgi X-Rspam-User: Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=dM+Wb+UH; spf=none (imf14.hostedemail.com: domain of lkp@intel.com has no SPF policy when checking 134.134.136.100) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com X-HE-Tag: 1651869502-878426 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Vasily, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on rostedt-trace/for-next] [also build test WARNING on hnaz-mm/master v5.18-rc5] [cannot apply to dennis-percpu/for-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Vasily-Averin/percpu-improve-percpu_alloc_percpu-event-trace/20220506-124742 base: https://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git for-next config: i386-randconfig-s001 (https://download.01.org/0day-ci/archive/20220507/202205070420.aAhuqpYk-lkp@intel.com/config) compiler: gcc-11 (Debian 11.2.0-20) 11.2.0 reproduce: # apt-get install sparse # sparse version: v0.6.4-dirty # https://github.com/intel-lab-lkp/linux/commit/dee6876db0a7a4715516e673f9edaca2ba40677c git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Vasily-Averin/percpu-improve-percpu_alloc_percpu-event-trace/20220506-124742 git checkout dee6876db0a7a4715516e673f9edaca2ba40677c # save the config file mkdir build_dir && cp config build_dir/.config make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=i386 SHELL=/bin/bash If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot sparse warnings: (new ones prefixed by >>) mm/percpu.c: note: in included file (through include/trace/trace_events.h, include/trace/define_trace.h, include/trace/events/percpu.h): >> include/trace/events/percpu.h:11:1: sparse: sparse: cast from restricted gfp_t >> include/trace/events/percpu.h:11:1: sparse: sparse: cast from restricted gfp_t >> include/trace/events/percpu.h:11:1: sparse: sparse: cast from restricted gfp_t >> include/trace/events/percpu.h:11:1: sparse: sparse: cast from restricted gfp_t >> include/trace/events/percpu.h:11:1: sparse: sparse: cast from restricted gfp_t >> include/trace/events/percpu.h:11:1: sparse: sparse: cast from restricted gfp_t >> include/trace/events/percpu.h:11:1: sparse: sparse: cast from restricted gfp_t >> include/trace/events/percpu.h:11:1: sparse: sparse: cast from restricted gfp_t >> include/trace/events/percpu.h:11:1: sparse: sparse: cast from restricted gfp_t >> include/trace/events/percpu.h:11:1: sparse: sparse: cast from restricted gfp_t >> include/trace/events/percpu.h:11:1: sparse: sparse: cast from restricted gfp_t >> include/trace/events/percpu.h:11:1: sparse: sparse: cast from restricted gfp_t >> include/trace/events/percpu.h:11:1: sparse: sparse: cast from restricted gfp_t >> include/trace/events/percpu.h:11:1: sparse: sparse: cast from restricted gfp_t >> include/trace/events/percpu.h:11:1: sparse: sparse: cast from restricted gfp_t >> include/trace/events/percpu.h:11:1: sparse: sparse: cast from restricted gfp_t >> include/trace/events/percpu.h:11:1: sparse: sparse: cast from restricted gfp_t >> include/trace/events/percpu.h:11:1: sparse: sparse: cast from restricted gfp_t >> include/trace/events/percpu.h:11:1: sparse: sparse: cast from restricted gfp_t >> include/trace/events/percpu.h:11:1: sparse: sparse: cast from restricted gfp_t >> include/trace/events/percpu.h:11:1: sparse: sparse: cast from restricted gfp_t >> include/trace/events/percpu.h:11:1: sparse: sparse: cast from restricted gfp_t >> include/trace/events/percpu.h:11:1: sparse: sparse: cast from restricted gfp_t >> include/trace/events/percpu.h:11:1: sparse: sparse: cast from restricted gfp_t >> include/trace/events/percpu.h:11:1: sparse: sparse: cast from restricted gfp_t >> include/trace/events/percpu.h:11:1: sparse: sparse: cast from restricted gfp_t >> include/trace/events/percpu.h:11:1: sparse: sparse: cast from restricted gfp_t >> include/trace/events/percpu.h:11:1: sparse: sparse: cast from restricted gfp_t >> include/trace/events/percpu.h:11:1: sparse: sparse: cast from restricted gfp_t >> include/trace/events/percpu.h:11:1: sparse: sparse: cast from restricted gfp_t >> include/trace/events/percpu.h:11:1: sparse: sparse: cast from restricted gfp_t >> include/trace/events/percpu.h:11:1: sparse: sparse: cast from restricted gfp_t >> include/trace/events/percpu.h:11:1: sparse: sparse: cast from restricted gfp_t >> include/trace/events/percpu.h:11:1: sparse: sparse: cast from restricted gfp_t >> include/trace/events/percpu.h:11:1: sparse: sparse: cast from restricted gfp_t >> include/trace/events/percpu.h:11:1: sparse: sparse: cast from restricted gfp_t >> include/trace/events/percpu.h:11:1: sparse: sparse: cast from restricted gfp_t >> include/trace/events/percpu.h:11:1: sparse: sparse: incorrect type in argument 3 (different base types) @@ expected unsigned long flags @@ got restricted gfp_t [usertype] gfp_flags @@ include/trace/events/percpu.h:11:1: sparse: expected unsigned long flags include/trace/events/percpu.h:11:1: sparse: got restricted gfp_t [usertype] gfp_flags mm/percpu.c: note: in included file (through include/trace/trace_events.h, include/trace/define_trace.h, include/trace/events/percpu.h): >> include/trace/events/percpu.h:11:1: sparse: sparse: cast to restricted gfp_t >> include/trace/events/percpu.h:11:1: sparse: sparse: cast to restricted gfp_t >> include/trace/events/percpu.h:11:1: sparse: sparse: restricted gfp_t degrades to integer >> include/trace/events/percpu.h:11:1: sparse: sparse: restricted gfp_t degrades to integer mm/percpu.c:2012:24: sparse: sparse: context imbalance in 'pcpu_balance_free' - unexpected unlock vim +11 include/trace/events/percpu.h df95e795a72289 Dennis Zhou 2017-06-19 10 df95e795a72289 Dennis Zhou 2017-06-19 @11 TRACE_EVENT(percpu_alloc_percpu, df95e795a72289 Dennis Zhou 2017-06-19 12 df95e795a72289 Dennis Zhou 2017-06-19 13 TP_PROTO(bool reserved, bool is_atomic, size_t size, dee6876db0a7a4 Vasily Averin 2022-05-06 14 size_t align, void *base_addr, int off, dee6876db0a7a4 Vasily Averin 2022-05-06 15 void __percpu *ptr, size_t bytes_alloc, gfp_t gfp_flags), df95e795a72289 Dennis Zhou 2017-06-19 16 dee6876db0a7a4 Vasily Averin 2022-05-06 17 TP_ARGS(reserved, is_atomic, size, align, base_addr, off, ptr, dee6876db0a7a4 Vasily Averin 2022-05-06 18 bytes_alloc, gfp_flags), df95e795a72289 Dennis Zhou 2017-06-19 19 df95e795a72289 Dennis Zhou 2017-06-19 20 TP_STRUCT__entry( df95e795a72289 Dennis Zhou 2017-06-19 21 __field( bool, reserved ) df95e795a72289 Dennis Zhou 2017-06-19 22 __field( bool, is_atomic ) df95e795a72289 Dennis Zhou 2017-06-19 23 __field( size_t, size ) df95e795a72289 Dennis Zhou 2017-06-19 24 __field( size_t, align ) df95e795a72289 Dennis Zhou 2017-06-19 25 __field( void *, base_addr ) df95e795a72289 Dennis Zhou 2017-06-19 26 __field( int, off ) df95e795a72289 Dennis Zhou 2017-06-19 27 __field( void __percpu *, ptr ) dee6876db0a7a4 Vasily Averin 2022-05-06 28 __field( size_t, bytes_alloc ) dee6876db0a7a4 Vasily Averin 2022-05-06 29 __field( gfp_t, gfp_flags ) df95e795a72289 Dennis Zhou 2017-06-19 30 ), df95e795a72289 Dennis Zhou 2017-06-19 31 TP_fast_assign( df95e795a72289 Dennis Zhou 2017-06-19 32 __entry->reserved = reserved; df95e795a72289 Dennis Zhou 2017-06-19 33 __entry->is_atomic = is_atomic; df95e795a72289 Dennis Zhou 2017-06-19 34 __entry->size = size; df95e795a72289 Dennis Zhou 2017-06-19 35 __entry->align = align; df95e795a72289 Dennis Zhou 2017-06-19 36 __entry->base_addr = base_addr; df95e795a72289 Dennis Zhou 2017-06-19 37 __entry->off = off; df95e795a72289 Dennis Zhou 2017-06-19 38 __entry->ptr = ptr; dee6876db0a7a4 Vasily Averin 2022-05-06 39 __entry->bytes_alloc = bytes_alloc; dee6876db0a7a4 Vasily Averin 2022-05-06 40 __entry->gfp_flags = gfp_flags; df95e795a72289 Dennis Zhou 2017-06-19 41 ), df95e795a72289 Dennis Zhou 2017-06-19 42 dee6876db0a7a4 Vasily Averin 2022-05-06 43 TP_printk("reserved=%d is_atomic=%d size=%zu align=%zu base_addr=%p off=%d ptr=%p bytes_alloc=%zu gfp_flags=%s", df95e795a72289 Dennis Zhou 2017-06-19 44 __entry->reserved, __entry->is_atomic, df95e795a72289 Dennis Zhou 2017-06-19 45 __entry->size, __entry->align, dee6876db0a7a4 Vasily Averin 2022-05-06 46 __entry->base_addr, __entry->off, __entry->ptr, dee6876db0a7a4 Vasily Averin 2022-05-06 47 __entry->bytes_alloc, show_gfp_flags(__entry->gfp_flags)) df95e795a72289 Dennis Zhou 2017-06-19 48 ); df95e795a72289 Dennis Zhou 2017-06-19 49 -- 0-DAY CI Kernel Test Service https://01.org/lkp