linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: SeongJae Park <sj@kernel.org>
To: SeongJae Park <sj@kernel.org>
Cc: Gautam Menghani <gautammenghani201@gmail.com>,
	skhan@linuxfoundation.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/damon : Add documentation for Enum value
Date: Mon,  9 May 2022 08:11:54 +0000	[thread overview]
Message-ID: <20220509081154.1834-1-sj@kernel.org> (raw)
In-Reply-To: <20220508091943.47042-1-sj@kernel.org>

Hi Gautam,


I just found this patch is not cleanly applicable on top of the mm-unstable
branch[1].  Could you please rebase?

[1] https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git/log/?h=mm-unstable


Thanks,
SJ

On Sun, 8 May 2022 09:19:43 +0000 SeongJae Park <sj@kernel.org> wrote:

> Hi Gautam,
> 
> 
> On Sun, 8 May 2022 13:03:16 +0530 Gautam Menghani <gautammenghani201@gmail.com> wrote:
> 
> > Fix the warning - "Enum value 'NR_DAMON_OPS' not described in 
> > enum 'damon_ops_id'" generated by the command "make pdfdocs"
> > 
> > Signed-off-by: Gautam Menghani <gautammenghani201@gmail.com>
> > ---
> > Changes in v3:
> > - Add the subsystem in subject.
> > - Modify the description for NR_DAMON_OPS field.
> 
> Thank you for making the changes.
> 
> Reviewed-by: SeongJae Park <sj@kernel.org>
> 
> 
> Thanks,
> SJ
> 
> > 
> > Changes in v2:
> > - Fix checkpatch warning of 75 characters per line
> > - Fix email mismatch in from and signed by field
> > 
> >  include/linux/damon.h | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/include/linux/damon.h b/include/linux/damon.h
> > index f23cbfa4248d..b972a7a3b6f0 100644
> > --- a/include/linux/damon.h
> > +++ b/include/linux/damon.h
> > @@ -262,6 +262,7 @@ struct damos {
> >   *
> >   * @DAMON_OPS_VADDR:	Monitoring operations for virtual address spaces
> >   * @DAMON_OPS_PADDR:	Monitoring operations for the physical address space
> > + * @NR_DAMON_OPS:	Number of monitoring operations implementations
> >   */
> >  enum damon_ops_id {
> >  	DAMON_OPS_VADDR,
> > -- 
> > 2.25.1
> > 


  reply	other threads:[~2022-05-09  8:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-08  7:33 [PATCH] mm/damon : Add documentation for Enum value Gautam Menghani
2022-05-08  9:19 ` SeongJae Park
2022-05-09  8:11   ` SeongJae Park [this message]
2022-05-10 22:27     ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220509081154.1834-1-sj@kernel.org \
    --to=sj@kernel.org \
    --cc=gautammenghani201@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).