From: Andrew Morton <akpm@linux-foundation.org>
To: Rei Yamamoto <yamamoto.rei@jp.fujitsu.com>
Cc: linmiaohe@huawei.com, aquini@redhat.com, ddutile@redhat.com,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
mgorman@techsingularity.net, vvghjk1234@gmail.com
Subject: Re: [PATCH] mm, compaction: fast_find_migrateblock() should return pfn in the target zone
Date: Wed, 11 May 2022 19:20:00 -0700 [thread overview]
Message-ID: <20220511192000.d4851d55c5560e720e1e2914@linux-foundation.org> (raw)
In-Reply-To: <20220512014736.16376-1-yamamoto.rei@jp.fujitsu.com>
On Thu, 12 May 2022 10:47:36 +0900 Rei Yamamoto <yamamoto.rei@jp.fujitsu.com> wrote:
> ...
>
> > Sorry, I think you're right. And could you please add the runtime effect of this issue?
> >
> > Anyway, this patch looks good to me now. Thanks!
>
> Thank you for your review.
> The runtime effect is that compaction become unintended behavior.
> For example, pages not in the target zone are added to cc->migratepages list in isolate_migratepages_block().
> As a result, pages migrate between nodes unintentionally.
Thanks. I updated the changelog thusly:
: At present, pages not in the target zone are added to cc->migratepages
: list in isolate_migratepages_block(). As a result, pages may migrate
: between nodes unintentionally.
:
: Avoid returning a pfn outside the target zone in the case that it is
: not aligned with a pageblock boundary. Otherwise
: isolate_migratepages_block() will handle pages not in the target zone.
next prev parent reply other threads:[~2022-05-12 2:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-11 4:43 [PATCH] mm, compaction: fast_find_migrateblock() should return pfn in the target zone Rei Yamamoto
2022-05-11 6:25 ` Miaohe Lin
2022-05-11 7:07 ` Rei Yamamoto
2022-05-11 9:26 ` Miaohe Lin
2022-05-12 1:47 ` Rei Yamamoto
2022-05-12 2:20 ` Andrew Morton [this message]
2022-05-12 2:27 ` Miaohe Lin
2022-05-12 4:27 ` Rei Yamamoto
2022-05-12 20:49 ` Andrew Morton
2022-05-13 4:11 ` Rei Yamamoto
2022-05-13 21:01 ` Andrew Morton
2022-05-16 2:41 ` Rei Yamamoto
2022-05-12 9:04 ` Mel Gorman
2022-05-13 7:54 ` Oscar Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220511192000.d4851d55c5560e720e1e2914@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=aquini@redhat.com \
--cc=ddutile@redhat.com \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=vvghjk1234@gmail.com \
--cc=yamamoto.rei@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).