From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3878C433F5 for ; Fri, 13 May 2022 00:36:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 18A636B0073; Thu, 12 May 2022 20:36:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 13B726B0075; Thu, 12 May 2022 20:36:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 029346B0078; Thu, 12 May 2022 20:36:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id E7CB26B0073 for ; Thu, 12 May 2022 20:36:24 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id A72B161034 for ; Fri, 13 May 2022 00:36:24 +0000 (UTC) X-FDA: 79458853488.22.AA17BC5 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf10.hostedemail.com (Postfix) with ESMTP id CD9D3C0094 for ; Fri, 13 May 2022 00:35:59 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A73C3B82910; Fri, 13 May 2022 00:36:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3AECDC385B8; Fri, 13 May 2022 00:36:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1652402181; bh=YamEZ3xW3F+5L2aoDDsxvt+p4+fp1TcaW7VG7lie2EA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=DlXLjpB7tjOcsoABHj2WqvpbCi0VJ4jfI7RsczkeARZrYrD3y/p6FOFOwCSQH04bw xX4J4DwetmBpMrV9MwEV2vwVbVGI4TDgYKWamlclDiLGHkkfbfeqR25GeHLd+19qin 50jvhr221UvJad6SIV8AlGnzvwkeMeYzSvH+xRCw= Date: Thu, 12 May 2022 17:36:20 -0700 From: Andrew Morton To: Peter Xu Cc: David Hildenbrand , Bibo Mao , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Yang Shi Subject: Re: [PATCH v3] mm/khugepaged: sched to numa node when collapse huge page Message-Id: <20220512173620.2f5175c7a321e6ccea6e58e9@linux-foundation.org> In-Reply-To: References: <20220317065024.2635069-1-maobibo@loongson.cn> <3a441789-b3e4-236e-2e44-e7a1c7258a94@redhat.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: CD9D3C0094 X-Stat-Signature: 5oioncuhkp7anq85hp5tion9niyde481 X-Rspam-User: Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=DlXLjpB7; spf=pass (imf10.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-HE-Tag: 1652402159-965894 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 28 Apr 2022 12:34:07 -0400 Peter Xu wrote: > On Thu, Apr 28, 2022 at 05:17:07PM +0200, David Hildenbrand wrote: > > On 17.03.22 07:50, Bibo Mao wrote: > > > collapse huge page will copy huge page from general small pages, > > > dest node is calculated from most one of source pages, however > > > THP daemon is not scheduled on dest node. The performance may be > > > poor since huge page copying across nodes, also cache is not used > > > for target node. With this patch, khugepaged daemon switches to > > > the same numa node with huge page. It saves copying time and makes > > > use of local cache better. > > > > > > With this patch, specint 2006 base performance is improved with 6% > > > on Loongson 3C5000L platform with 32 cores and 8 numa nodes. > > > > If it helps, that's nice as long as it doesn't hurt other cases. > > Quite a bit of doubtful feedback and we have yet to hear from the author. I'll drop the patch. Bibo, please resend at a later time if you feel the patch remains desirable. Please attempt to address the feedback via code changes and/or changelogging.