From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD913C433F5 for ; Fri, 13 May 2022 00:42:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 30AB36B0073; Thu, 12 May 2022 20:42:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2B8BC6B0075; Thu, 12 May 2022 20:42:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 15AAF6B0078; Thu, 12 May 2022 20:42:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 034476B0073 for ; Thu, 12 May 2022 20:42:52 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id CF5DB31A76 for ; Fri, 13 May 2022 00:42:51 +0000 (UTC) X-FDA: 79458869742.24.A7B3A67 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf07.hostedemail.com (Postfix) with ESMTP id A6194400A3 for ; Fri, 13 May 2022 00:42:44 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C35FDB82BA8; Fri, 13 May 2022 00:42:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E2DE7C385B8; Fri, 13 May 2022 00:42:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1652402568; bh=n+YkgIXMbs5r/IrOg8NDKPb5pr+3M20tWFLhucxHzTw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=z9kjB3CuAN5ZwzDK7nRXCRFIMR2e3iFFqvaypZxsQnn2tBmW32umPWUIIWJIu7Ekt CzfUdZ0WXvcuwPdWqFBWhpVpY+gWfwUQe33y2QAZ9ifDzMDi/lKXfVIWoyq/vMIQEY 6v0CLYJ10ftLPxn14WLZs2y6JwdM0aY3rGgbSnp8= Date: Thu, 12 May 2022 17:42:47 -0700 From: Andrew Morton To: Miaohe Lin Cc: HORIGUCHI =?ISO-8859-1?Q?NAOYA?=(=?UTF-8?Q?=E5=A0=80=E5=8F=A3_?= =?UTF-8?Q?=E7=9B=B4=E4=B9=9F?=) , "willy@infradead.org" , "vbabka@suse.cz" , "dhowells@redhat.com" , "neilb@suse.de" , "david@redhat.com" , "apopple@nvidia.com" , "surenb@google.com" , "minchan@kernel.org" , "peterx@redhat.com" , "sfr@canb.auug.org.au" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v3 1/3] mm/swapfile: unuse_pte can map random data if swap read fails Message-Id: <20220512174247.c4e178334879fb6b10134c2c@linux-foundation.org> In-Reply-To: <2a95aebe-3a00-4699-12d4-fc5d934dde2c@huawei.com> References: <20220424091105.48374-1-linmiaohe@huawei.com> <20220424091105.48374-2-linmiaohe@huawei.com> <20220510061712.GA162496@hori.linux.bs1.fc.nec.co.jp> <2a95aebe-3a00-4699-12d4-fc5d934dde2c@huawei.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: ouiqmusui9worhxxo3inptbmneum3eey Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=z9kjB3Cu; spf=pass (imf07.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: A6194400A3 X-HE-Tag: 1652402564-189718 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 10 May 2022 14:58:05 +0800 Miaohe Lin wrote: > >> Signed-off-by: Miaohe Lin > >> Acked-by: David Hildenbrand > > > > When I reproduced the issue (generated read error with dm-dust), I saw > > infinite loop in the while loop in shmem_unuse_inode() (and this happens > > even with this patch). I confirmed that shmem_swapin_page() returns -EIO, > > but shmem_unuse_swap_entries() does not return the error to the callers, > > so the while loop in shmem_unuse_inode() seems not break. > > > > Many thanks for your report! I didn't test the shmem case because I saw -EIO > is returned. So I just focus on the normal page case. Sorry about it. :( > > > So maybe you need more code around shmem_unuse_inode() to handle the error? > > I will try to reproduce it and come up a fixup patch asap! And if you like, you > can kindly solve this issue too. ;) Seems that this patch didn't cause the infinite loop, so as far as I can tell it is good to be merged up. But the problem it solves isn't urgent and fixing that infinite loop might impact this change so I think I'll drop this version.