From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0FBEC433F5 for ; Fri, 13 May 2022 01:49:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5EFA06B0073; Thu, 12 May 2022 21:49:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 59FD16B0075; Thu, 12 May 2022 21:49:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4672E6B0078; Thu, 12 May 2022 21:49:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 3650B6B0073 for ; Thu, 12 May 2022 21:49:12 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 08D3732752 for ; Fri, 13 May 2022 01:49:12 +0000 (UTC) X-FDA: 79459036944.23.F4BBE1B Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf03.hostedemail.com (Postfix) with ESMTP id 04103200A1 for ; Fri, 13 May 2022 01:49:02 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 66FFA62113; Fri, 13 May 2022 01:49:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 90F9AC34114; Fri, 13 May 2022 01:49:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1652406549; bh=KrxWD2CuSg9dzECF9702XBUPnwyF2cUFYN6lqGyJS4M=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=OI7tWbNycPGvskqqqe1hAO6VTJf2so+OQ4ixn9hlGBABsyXshcWqUcbYMRi2Cuakg fgEposrmOERKAGqLqH+QMcxX4DIRDN+SuKu+voWrchvd4vr1SPmBD9AukaVQwDIJPu b9R2vSe5t0sVsEA3/kQIjLEikOZz70tS4Vzi7aQQ= Date: Thu, 12 May 2022 18:49:08 -0700 From: Andrew Morton To: maobibo Cc: Peter Xu , David Hildenbrand , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Yang Shi Subject: Re: [PATCH v3] mm/khugepaged: sched to numa node when collapse huge page Message-Id: <20220512184908.0852e1efcb6fd78aea52b557@linux-foundation.org> In-Reply-To: <69c4f018-2012-8af5-569b-289d2a8a80f5@loongson.cn> References: <20220317065024.2635069-1-maobibo@loongson.cn> <3a441789-b3e4-236e-2e44-e7a1c7258a94@redhat.com> <20220512173620.2f5175c7a321e6ccea6e58e9@linux-foundation.org> <8c1fc6d4-7d3a-85dd-ebd9-fc8e221f1878@loongson.cn> <69c4f018-2012-8af5-569b-289d2a8a80f5@loongson.cn> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 04103200A1 X-Stat-Signature: po7qj9tjuqqtaf6ui56c4antyf41e9h1 Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=OI7tWbNy; dmarc=none; spf=pass (imf03.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1652406542-229824 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 13 May 2022 09:29:07 +0800 maobibo wrote: > > > >> and/or changelogging. > > Sorry for the late response, the mail is filtered and I did not notice that. The result is not so obvious after bandwidth is improved between nodes, it is only about 1% improvement for specint2006 for 32 core on my box. > > > > Now I do not see negative effective about this patch unless user wants to keep some cores separated from khugepaged daemon process. > > Can we provide an extra parameter to let khugepaged daemon scheduling binded to node or freely? If can, I will provide updated patch. It has always surprised me that we have a single khugepaged thread. If we had a thread per node, you'd be all fixed up, yes? Ditto ksmd.