From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55E20C433F5 for ; Tue, 17 May 2022 23:39:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AE3246B0072; Tue, 17 May 2022 19:39:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A93106B0073; Tue, 17 May 2022 19:39:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 95B006B0074; Tue, 17 May 2022 19:39:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 884DE6B0072 for ; Tue, 17 May 2022 19:39:12 -0400 (EDT) Received: from smtpin31.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 63F301CCF for ; Tue, 17 May 2022 23:39:12 +0000 (UTC) X-FDA: 79476853344.31.31804E1 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf13.hostedemail.com (Postfix) with ESMTP id C5DD3200C8 for ; Tue, 17 May 2022 23:38:49 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 1ED90B81D62; Tue, 17 May 2022 23:39:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 70938C385B8; Tue, 17 May 2022 23:39:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1652830748; bh=JEWdfhbC5CbWSi17hxZuBVoj601BdghMmPGpjgottKo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=MjeauKwgia4b2KAd9VrN1ZKzelXPYmVvRqOQKfHOfWBf/zSiTNHV+qvACr/8++N94 i5Hcame/r39FW5rqsjTWcFaJb2fzcM6g/5Y02n0Xoo5Em8TcypXr/WHPZy80qsDxjX lxNll3G/mRyfWRzhB4hMql3m5y5pgAi6gFjAy5Jc= Date: Tue, 17 May 2022 16:39:07 -0700 From: Andrew Morton To: Miaohe Lin Cc: David Hildenbrand , , , , , , , , , , Subject: Re: [PATCH 06/15] mm/swap: remove buggy cache->nr check in refill_swap_slots_cache Message-Id: <20220517163907.223f16f071b57b9e3d062ff8@linux-foundation.org> In-Reply-To: <8b03aa8a-5023-6915-64c6-f6f298f19f36@huawei.com> References: <20220509131416.17553-1-linmiaohe@huawei.com> <20220509131416.17553-7-linmiaohe@huawei.com> <8b03aa8a-5023-6915-64c6-f6f298f19f36@huawei.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=MjeauKwg; dmarc=none; spf=pass (imf13.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: C5DD3200C8 X-Rspam-User: X-Stat-Signature: 67gkr9n153fbdtc1xbu8mqesih9ocnaq X-HE-Tag: 1652830729-330694 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 16 May 2022 10:00:43 +0800 Miaohe Lin wrote: > On 2022/5/12 21:37, David Hildenbrand wrote: > > On 09.05.22 15:14, Miaohe Lin wrote: > >> refill_swap_slots_cache is always called when cache->nr is 0. And if > >> cache->nr != 0, we should return cache->nr instead of 0. So remove > >> such buggy and confusing check. > > > > Not sure about the "cache->nr != 0, we should return cache->nr instead > > of 0" part, I'd just drop that from the patch description. We'd actually > > end up overwriting cache->nr after your change, which doesn't sound > > right and also different to what you describe here. > > Will do. I've updated the changleog to simply : refill_swap_slots_cache is always called when cache->nr is 0. So remove : such buggy and confusing check.